You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Steven Gill <st...@gmail.com> on 2016/02/17 22:41:50 UTC
Github issue and PR templates
Cool new feature from github!
https://github.com/blog/2111-issue-and-pull-request-templates
Since we don't do issues on github, that feature isn't useful to us. But
providing PR templates sounds like a good idea. Just need to add a
PULL_REQUEST_TEMPLATE.md to the root of our repos.
What type of information would we ask for from PRs?
* Issue number
If it is a plugin
* which platforms
Thoughts?
RE: Github issue and PR templates
Posted by Nikhil Khandelwal <ni...@microsoft.com>.
I have submitted a PR to add a pull request to cordova-plugin-camera: https://github.com/apache/cordova-plugin-camera/pull/213
Please review and provide feedback. I intend to add this to all other repos.
-Nikhil
-----Original Message-----
From: Dmitry Blotsky [mailto:dblotsky@microsoft.com]
Sent: Thursday, February 18, 2016 6:39 PM
To: dev@cordova.apache.org
Subject: RE: Github issue and PR templates
I like the idea. I suggest starting small and expanding as necessary. Right now the two most important pieces of information that I think our PRs could use are:
Did you sign the ICLA? [ ] Yes / [ ] No
Related JIRA: CB-[ ]
Kindly,
Dmitry
-----Original Message-----
From: Carlos Santana [mailto:csantana23@gmail.com]
Sent: Thursday, February 18, 2016 5:55 PM
To: dev@cordova.apache.org
Subject: Re: Github issue and PR templates
I agree, Running tests as easy as npm install && npm run config && npm test
:-)
On Thu, Feb 18, 2016 at 4:40 PM Nikhil Khandelwal <ni...@microsoft.com>
wrote:
> I think for plugins, platform name should be required as part of title
> of the PR and commit message in addition to JIRA number.
>
> Checklist:
> [ ] Tests that were added or run for a new feature/regressions [ ]
> Does the new feature broadly apply to multiple platforms?
>
> We probably need to make it easier for contributors to run tests for
> plugins.
>
> -Nikhil
>
> -----Original Message-----
> From: Steven Gill [mailto:stevengill97@gmail.com]
> Sent: Wednesday, February 17, 2016 1:42 PM
> To: dev@cordova.apache.org
> Subject: Github issue and PR templates
>
> Cool new feature from github!
> https://github.com/blog/2111-issue-and-pull-request-templates
>
> Since we don't do issues on github, that feature isn't useful to us.
> But providing PR templates sounds like a good idea. Just need to add a
> PULL_REQUEST_TEMPLATE.md to the root of our repos.
>
> What type of information would we ask for from PRs?
>
> * Issue number
>
> If it is a plugin
> * which platforms
>
> Thoughts?
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
RE: Github issue and PR templates
Posted by Dmitry Blotsky <db...@microsoft.com>.
I like the idea. I suggest starting small and expanding as necessary. Right now the two most important pieces of information that I think our PRs could use are:
Did you sign the ICLA? [ ] Yes / [ ] No
Related JIRA: CB-[ ]
Kindly,
Dmitry
-----Original Message-----
From: Carlos Santana [mailto:csantana23@gmail.com]
Sent: Thursday, February 18, 2016 5:55 PM
To: dev@cordova.apache.org
Subject: Re: Github issue and PR templates
I agree, Running tests as easy as npm install && npm run config && npm test
:-)
On Thu, Feb 18, 2016 at 4:40 PM Nikhil Khandelwal <ni...@microsoft.com>
wrote:
> I think for plugins, platform name should be required as part of title
> of the PR and commit message in addition to JIRA number.
>
> Checklist:
> [ ] Tests that were added or run for a new feature/regressions [ ]
> Does the new feature broadly apply to multiple platforms?
>
> We probably need to make it easier for contributors to run tests for
> plugins.
>
> -Nikhil
>
> -----Original Message-----
> From: Steven Gill [mailto:stevengill97@gmail.com]
> Sent: Wednesday, February 17, 2016 1:42 PM
> To: dev@cordova.apache.org
> Subject: Github issue and PR templates
>
> Cool new feature from github!
> https://github.com/blog/2111-issue-and-pull-request-templates
>
> Since we don't do issues on github, that feature isn't useful to us.
> But providing PR templates sounds like a good idea. Just need to add a
> PULL_REQUEST_TEMPLATE.md to the root of our repos.
>
> What type of information would we ask for from PRs?
>
> * Issue number
>
> If it is a plugin
> * which platforms
>
> Thoughts?
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: Github issue and PR templates
Posted by Carlos Santana <cs...@gmail.com>.
I agree, Running tests as easy as npm install && npm run config && npm test
:-)
On Thu, Feb 18, 2016 at 4:40 PM Nikhil Khandelwal <ni...@microsoft.com>
wrote:
> I think for plugins, platform name should be required as part of title of
> the PR and commit message in addition to JIRA number.
>
> Checklist:
> [ ] Tests that were added or run for a new feature/regressions
> [ ] Does the new feature broadly apply to multiple platforms?
>
> We probably need to make it easier for contributors to run tests for
> plugins.
>
> -Nikhil
>
> -----Original Message-----
> From: Steven Gill [mailto:stevengill97@gmail.com]
> Sent: Wednesday, February 17, 2016 1:42 PM
> To: dev@cordova.apache.org
> Subject: Github issue and PR templates
>
> Cool new feature from github!
> https://github.com/blog/2111-issue-and-pull-request-templates
>
> Since we don't do issues on github, that feature isn't useful to us. But
> providing PR templates sounds like a good idea. Just need to add a
> PULL_REQUEST_TEMPLATE.md to the root of our repos.
>
> What type of information would we ask for from PRs?
>
> * Issue number
>
> If it is a plugin
> * which platforms
>
> Thoughts?
>
RE: Github issue and PR templates
Posted by Nikhil Khandelwal <ni...@microsoft.com>.
I think for plugins, platform name should be required as part of title of the PR and commit message in addition to JIRA number.
Checklist:
[ ] Tests that were added or run for a new feature/regressions
[ ] Does the new feature broadly apply to multiple platforms?
We probably need to make it easier for contributors to run tests for plugins.
-Nikhil
-----Original Message-----
From: Steven Gill [mailto:stevengill97@gmail.com]
Sent: Wednesday, February 17, 2016 1:42 PM
To: dev@cordova.apache.org
Subject: Github issue and PR templates
Cool new feature from github!
https://github.com/blog/2111-issue-and-pull-request-templates
Since we don't do issues on github, that feature isn't useful to us. But providing PR templates sounds like a good idea. Just need to add a PULL_REQUEST_TEMPLATE.md to the root of our repos.
What type of information would we ask for from PRs?
* Issue number
If it is a plugin
* which platforms
Thoughts?