[GitHub] merlimat commented on a change in pull request #971: BOOKKEEPER-934: Additional stats to track netty latencies in PCBC

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #971: BOOKKEEPER-934: Additional stats to track netty latencies in PCBC
URL: https://github.com/apache/bookkeeper/pull/971#discussion_r161170556
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
 ##########
 @@ -861,7 +875,21 @@ private void writeAndFlush(final Channel channel,
         }
 
         try {
-            channel.writeAndFlush(request, channel.voidPromise());
+            final long startTime = MathUtils.nowInNano();
+            ChannelFuture future = channel.writeAndFlush(request, channel.voidPromise());
 
 Review comment:
   with `voidPromise` the returned future will be the one from the `voidPromise`, so not very useful :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services