You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/24 08:38:14 UTC
[GitHub] [flink] zjffdu opened a new pull request #10676:
[FLINK-15380][scala-shell]. Unable to set number of TM and number of Slot
for MiniCluster in Scala shell
zjffdu opened a new pull request #10676: [FLINK-15380][scala-shell]. Unable to set number of TM and number of Slot for MiniCluster in Scala shell
URL: https://github.com/apache/flink/pull/10676
# What is the purpose of the change
User often do testing in local mode(especially in flink scala shell), but for now in scala shell it is uanble to set number of TM and number of Slot, that means we always get 1 TM with 1 slot which is usually doesn't work for streaming job. This PR is a straightforward fix for this issue.
## Brief change log
This PR just set number of TM and slot per TM in MiniClusterConfiguration before creating MiniCluster.
## Verifying this change
*(Please pick either of the following options)*
Verify it manually in scala shell.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10676:
[FLINK-15380][scala-shell]. Unable to set number of TM and number of Slot
for MiniCluster in Scala shell
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10676: [FLINK-15380][scala-shell]. Unable to set number of TM and number of Slot for MiniCluster in Scala shell
URL: https://github.com/apache/flink/pull/10676#issuecomment-568700688
<!--
Meta data
Hash:b5568763cb1c0fa7002ac2cc583801e69bf43139 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142206028 TriggerType:PUSH TriggerID:b5568763cb1c0fa7002ac2cc583801e69bf43139
Hash:b5568763cb1c0fa7002ac2cc583801e69bf43139 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3883 TriggerType:PUSH TriggerID:b5568763cb1c0fa7002ac2cc583801e69bf43139
Hash:b5568763cb1c0fa7002ac2cc583801e69bf43139 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142206028 TriggerType:MANUAL TriggerID:570174504
Hash:b5568763cb1c0fa7002ac2cc583801e69bf43139 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3883 TriggerType:MANUAL TriggerID:570174519
-->
## CI report:
* b5568763cb1c0fa7002ac2cc583801e69bf43139 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142206028) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3883)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10676:
[FLINK-15380][scala-shell]. Unable to set number of TM and number of Slot
for MiniCluster in Scala shell
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10676: [FLINK-15380][scala-shell]. Unable to set number of TM and number of Slot for MiniCluster in Scala shell
URL: https://github.com/apache/flink/pull/10676#issuecomment-568700688
<!--
Meta data
Hash:b5568763cb1c0fa7002ac2cc583801e69bf43139 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:b5568763cb1c0fa7002ac2cc583801e69bf43139
-->
## CI report:
* b5568763cb1c0fa7002ac2cc583801e69bf43139 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on issue #10676:
[FLINK-15380][scala-shell]. Unable to set number of TM and number of Slot
for MiniCluster in Scala shell
Posted by GitBox <gi...@apache.org>.
aljoscha commented on issue #10676: [FLINK-15380][scala-shell]. Unable to set number of TM and number of Slot for MiniCluster in Scala shell
URL: https://github.com/apache/flink/pull/10676#issuecomment-570174519
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun commented on issue #10676:
[FLINK-15380][scala-shell]. Unable to set number of TM and number of Slot
for MiniCluster in Scala shell
Posted by GitBox <gi...@apache.org>.
TisonKun commented on issue #10676: [FLINK-15380][scala-shell]. Unable to set number of TM and number of Slot for MiniCluster in Scala shell
URL: https://github.com/apache/flink/pull/10676#issuecomment-570514599
OK. Merging...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10676:
[FLINK-15380][scala-shell]. Unable to set number of TM and number of Slot
for MiniCluster in Scala shell
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10676: [FLINK-15380][scala-shell]. Unable to set number of TM and number of Slot for MiniCluster in Scala shell
URL: https://github.com/apache/flink/pull/10676#issuecomment-568700688
<!--
Meta data
Hash:b5568763cb1c0fa7002ac2cc583801e69bf43139 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142206028 TriggerType:PUSH TriggerID:b5568763cb1c0fa7002ac2cc583801e69bf43139
Hash:b5568763cb1c0fa7002ac2cc583801e69bf43139 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3883 TriggerType:PUSH TriggerID:b5568763cb1c0fa7002ac2cc583801e69bf43139
-->
## CI report:
* b5568763cb1c0fa7002ac2cc583801e69bf43139 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142206028) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3883)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10676:
[FLINK-15380][scala-shell]. Unable to set number of TM and number of Slot
for MiniCluster in Scala shell
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10676: [FLINK-15380][scala-shell]. Unable to set number of TM and number of Slot for MiniCluster in Scala shell
URL: https://github.com/apache/flink/pull/10676#issuecomment-568700688
<!--
Meta data
Hash:b5568763cb1c0fa7002ac2cc583801e69bf43139 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142206028 TriggerType:PUSH TriggerID:b5568763cb1c0fa7002ac2cc583801e69bf43139
Hash:b5568763cb1c0fa7002ac2cc583801e69bf43139 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3883 TriggerType:PUSH TriggerID:b5568763cb1c0fa7002ac2cc583801e69bf43139
-->
## CI report:
* b5568763cb1c0fa7002ac2cc583801e69bf43139 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142206028) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3883)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10676:
[FLINK-15380][scala-shell]. Unable to set number of TM and number of Slot
for MiniCluster in Scala shell
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10676: [FLINK-15380][scala-shell]. Unable to set number of TM and number of Slot for MiniCluster in Scala shell
URL: https://github.com/apache/flink/pull/10676#issuecomment-568700688
<!--
Meta data
Hash:b5568763cb1c0fa7002ac2cc583801e69bf43139 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142206028 TriggerType:PUSH TriggerID:b5568763cb1c0fa7002ac2cc583801e69bf43139
Hash:b5568763cb1c0fa7002ac2cc583801e69bf43139 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3883 TriggerType:PUSH TriggerID:b5568763cb1c0fa7002ac2cc583801e69bf43139
Hash:b5568763cb1c0fa7002ac2cc583801e69bf43139 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142206028 TriggerType:MANUAL TriggerID:570174504
Hash:b5568763cb1c0fa7002ac2cc583801e69bf43139 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3883 TriggerType:MANUAL TriggerID:570174519
Hash:b5568763cb1c0fa7002ac2cc583801e69bf43139 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142206028 TriggerType:MANUAL TriggerID:570174519
-->
## CI report:
* b5568763cb1c0fa7002ac2cc583801e69bf43139 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142206028) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3883)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on issue #10676:
[FLINK-15380][scala-shell]. Unable to set number of TM and number of Slot
for MiniCluster in Scala shell
Posted by GitBox <gi...@apache.org>.
aljoscha commented on issue #10676: [FLINK-15380][scala-shell]. Unable to set number of TM and number of Slot for MiniCluster in Scala shell
URL: https://github.com/apache/flink/pull/10676#issuecomment-570514391
Looks good, @TisonKun do you want to go ahead and merge on `master` and `release-1.10`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10676:
[FLINK-15380][scala-shell]. Unable to set number of TM and number of Slot
for MiniCluster in Scala shell
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10676: [FLINK-15380][scala-shell]. Unable to set number of TM and number of Slot for MiniCluster in Scala shell
URL: https://github.com/apache/flink/pull/10676#issuecomment-568700688
<!--
Meta data
Hash:b5568763cb1c0fa7002ac2cc583801e69bf43139 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142206028 TriggerType:PUSH TriggerID:b5568763cb1c0fa7002ac2cc583801e69bf43139
Hash:b5568763cb1c0fa7002ac2cc583801e69bf43139 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3883 TriggerType:PUSH TriggerID:b5568763cb1c0fa7002ac2cc583801e69bf43139
Hash:b5568763cb1c0fa7002ac2cc583801e69bf43139 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142206028 TriggerType:MANUAL TriggerID:570174504
Hash:b5568763cb1c0fa7002ac2cc583801e69bf43139 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3883 TriggerType:MANUAL TriggerID:570174519
Hash:b5568763cb1c0fa7002ac2cc583801e69bf43139 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142206028 TriggerType:MANUAL TriggerID:570174519
-->
## CI report:
* b5568763cb1c0fa7002ac2cc583801e69bf43139 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142206028) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3883)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10676:
[FLINK-15380][scala-shell]. Unable to set number of TM and number of Slot
for MiniCluster in Scala shell
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10676: [FLINK-15380][scala-shell]. Unable to set number of TM and number of Slot for MiniCluster in Scala shell
URL: https://github.com/apache/flink/pull/10676#issuecomment-568700688
<!--
Meta data
Hash:b5568763cb1c0fa7002ac2cc583801e69bf43139 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142206028 TriggerType:PUSH TriggerID:b5568763cb1c0fa7002ac2cc583801e69bf43139
Hash:b5568763cb1c0fa7002ac2cc583801e69bf43139 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3883 TriggerType:PUSH TriggerID:b5568763cb1c0fa7002ac2cc583801e69bf43139
-->
## CI report:
* b5568763cb1c0fa7002ac2cc583801e69bf43139 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142206028) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3883)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10676:
[FLINK-15380][scala-shell]. Unable to set number of TM and number of Slot
for MiniCluster in Scala shell
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10676: [FLINK-15380][scala-shell]. Unable to set number of TM and number of Slot for MiniCluster in Scala shell
URL: https://github.com/apache/flink/pull/10676#issuecomment-568695193
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit b5568763cb1c0fa7002ac2cc583801e69bf43139 (Tue Dec 24 08:41:48 UTC 2019)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15380).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun closed pull request #10676:
[FLINK-15380][scala-shell]. Unable to set number of TM and number of Slot
for MiniCluster in Scala shell
Posted by GitBox <gi...@apache.org>.
TisonKun closed pull request #10676: [FLINK-15380][scala-shell]. Unable to set number of TM and number of Slot for MiniCluster in Scala shell
URL: https://github.com/apache/flink/pull/10676
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on issue #10676:
[FLINK-15380][scala-shell]. Unable to set number of TM and number of Slot
for MiniCluster in Scala shell
Posted by GitBox <gi...@apache.org>.
aljoscha commented on issue #10676: [FLINK-15380][scala-shell]. Unable to set number of TM and number of Slot for MiniCluster in Scala shell
URL: https://github.com/apache/flink/pull/10676#issuecomment-570174504
@flinkbot run travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zjffdu commented on issue #10676:
[FLINK-15380][scala-shell]. Unable to set number of TM and number of Slot
for MiniCluster in Scala shell
Posted by GitBox <gi...@apache.org>.
zjffdu commented on issue #10676: [FLINK-15380][scala-shell]. Unable to set number of TM and number of Slot for MiniCluster in Scala shell
URL: https://github.com/apache/flink/pull/10676#issuecomment-568694603
@aljoscha @kl0u @TisonKun Could you help review it ? It would be nice to merge it in 1.10 as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services