You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "eren-terzioglu (via GitHub)" <gi...@apache.org> on 2024/10/10 15:05:44 UTC
[PR] esp32[c3]: Add BLE support [nuttx]
eren-terzioglu opened a new pull request, #14068:
URL: https://github.com/apache/nuttx/pull/14068
## Summary
Add ble support for ESP32C3
- esp32[c3]: Add BLE support
## Impact
ESP32C3
## Testing
`esp32c3-generic:ble` config used with these commands and output:
```
nsh> ifconfig
bnep0 Link encap:UNSPEC at DOWN mtu -9
inet addr:0.0.0.0 DRaddr:0.0.0.0 Mask:0.0.0.0
nsh> bt bnep0 info
Device: bnep0
BDAddr: ...
Flags: 0000
Free: 20
ACL: 20
SCO: 0
Max:
ACL: 24
SCO: 0
MTU:
ACL: 70
SCO: 70
Policy: 0
Type: 0
nsh> bt bnep0 scan start
nsh> bt bnep0 scan stop
nsh> bt bnep0 scan get
Scan result:
1. addr: ... type: 1
rssi: ...
response type: 4
advertiser data:
2. addr: ... type: 1
rssi: ...
response type: 0
advertiser data: ...
3. addr: ... type: 1
rssi: ...
response type: 4
advertiser data:
4. addr: ... type: 1
rssi: ...
response type: 0
advertiser data: ...
5. addr: ... type: 1
rssi: ...
response type: 4
advertiser data:
nsh>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] esp32[c3]: Add BLE support [nuttx]
Posted by "eren-terzioglu (via GitHub)" <gi...@apache.org>.
eren-terzioglu commented on code in PR #14068:
URL: https://github.com/apache/nuttx/pull/14068#discussion_r1796530372
##########
arch/risc-v/src/common/espressif/Make.defs:
##########
@@ -120,8 +120,8 @@ ifeq ($(CONFIG_ESP_WIRELESS),y)
ifeq ($(CONFIG_ESPRESSIF_WIFI),y)
CHIP_CSRCS += esp_wifi_init.c
CHIP_CSRCS += esp_wlan.c
- CHIP_CSRCS += esp_wifi_utils.c
endif
+ CHIP_CSRCS += esp_wifi_utils.c
Review Comment:
We are using that file just for one function instead of repeating code again which is called `esp_wifi_to_errno`. I will have a look again but there won't be a huge issue at least for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] esp32[c3]: Add BLE support [nuttx]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14068:
URL: https://github.com/apache/nuttx/pull/14068#issuecomment-2421603041
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] esp32[c3]: Add BLE support [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #14068:
URL: https://github.com/apache/nuttx/pull/14068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] esp32[c3]: Add BLE support [nuttx]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14068:
URL: https://github.com/apache/nuttx/pull/14068#issuecomment-2405387109
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] esp32[c3]: Add BLE support [nuttx]
Posted by "FelipeMdeO (via GitHub)" <gi...@apache.org>.
FelipeMdeO commented on code in PR #14068:
URL: https://github.com/apache/nuttx/pull/14068#discussion_r1795661768
##########
arch/risc-v/src/common/espressif/Make.defs:
##########
@@ -120,8 +120,8 @@ ifeq ($(CONFIG_ESP_WIRELESS),y)
ifeq ($(CONFIG_ESPRESSIF_WIFI),y)
CHIP_CSRCS += esp_wifi_init.c
CHIP_CSRCS += esp_wlan.c
- CHIP_CSRCS += esp_wifi_utils.c
endif
+ CHIP_CSRCS += esp_wifi_utils.c
Review Comment:
I cannot understand it, why we can enable wifi_utils, without init wifi?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org