You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Bharat Viswanadham <bh...@us.ibm.com> on 2017/05/02 17:28:01 UTC
Review Request 58927: AMBARI-20908 Kafka advertised.listeners
replaced in Kerberos Mode
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58927/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Di Li.
Repository: ambari
Description
-------
AMBARI-20908 Kafka advertised.listeners replaced in Kerberos Mode
Diffs
-----
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py 680dd32
Diff: https://reviews.apache.org/r/58927/diff/1/
Testing
-------
Tested with default installation and added advertised.listeners
and enabled kerberos and then checked advertised.listeners to see if it is same as user provided.
Thanks,
Bharat Viswanadham
Re: Review Request 58927: AMBARI-20908 Kafka advertised.listeners
replaced in Kerberos Mode
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58927/#review173612
-----------------------------------------------------------
Ship it!
Ship It!
- Di Li
On May 2, 2017, 5:28 p.m., Bharat Viswanadham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58927/
> -----------------------------------------------------------
>
> (Updated May 2, 2017, 5:28 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Di Li.
>
>
> Bugs: AMBARI-20908
> https://issues.apache.org/jira/browse/AMBARI-20908
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AMBARI-20908 Kafka advertised.listeners replaced in Kerberos Mode
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py 680dd32
>
>
> Diff: https://reviews.apache.org/r/58927/diff/1/
>
>
> Testing
> -------
>
> Tested with default installation and added advertised.listeners
> and enabled kerberos and then checked advertised.listeners to see if it is same as user provided.
>
>
> Thanks,
>
> Bharat Viswanadham
>
>
Re: Review Request 58927: AMBARI-20908 Kafka advertised.listeners
replaced in Kerberos Mode
Posted by Jayush Luniya <jl...@hortonworks.com>.
> On Jan. 23, 2018, 5:13 p.m., Jayush Luniya wrote:
> > Ship It!
Bharat,
Can you commit this patch to trunk and branch-2.6 so that it gets picked up in the next Ambari release?
- Jayush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58927/#review196035
-----------------------------------------------------------
On May 2, 2017, 5:28 p.m., Bharat Viswanadham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58927/
> -----------------------------------------------------------
>
> (Updated May 2, 2017, 5:28 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Di Li.
>
>
> Bugs: AMBARI-20908
> https://issues.apache.org/jira/browse/AMBARI-20908
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AMBARI-20908 Kafka advertised.listeners replaced in Kerberos Mode
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py 680dd32
>
>
> Diff: https://reviews.apache.org/r/58927/diff/1/
>
>
> Testing
> -------
>
> Tested with default installation and added advertised.listeners
> and enabled kerberos and then checked advertised.listeners to see if it is same as user provided.
>
>
> Thanks,
>
> Bharat Viswanadham
>
>
Re: Review Request 58927: AMBARI-20908 Kafka advertised.listeners
replaced in Kerberos Mode
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58927/#review196035
-----------------------------------------------------------
Ship it!
Ship It!
- Jayush Luniya
On May 2, 2017, 5:28 p.m., Bharat Viswanadham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58927/
> -----------------------------------------------------------
>
> (Updated May 2, 2017, 5:28 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Di Li.
>
>
> Bugs: AMBARI-20908
> https://issues.apache.org/jira/browse/AMBARI-20908
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AMBARI-20908 Kafka advertised.listeners replaced in Kerberos Mode
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py 680dd32
>
>
> Diff: https://reviews.apache.org/r/58927/diff/1/
>
>
> Testing
> -------
>
> Tested with default installation and added advertised.listeners
> and enabled kerberos and then checked advertised.listeners to see if it is same as user provided.
>
>
> Thanks,
>
> Bharat Viswanadham
>
>
Re: Review Request 58927: AMBARI-20908 Kafka advertised.listeners
replaced in Kerberos Mode
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58927/#review173620
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py
Line 85 (original), 85 (patched)
<https://reviews.apache.org/r/58927/#comment246616>
I'm not familiar enough with Kafka to comment on this.
- Alejandro Fernandez
On May 2, 2017, 5:28 p.m., Bharat Viswanadham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58927/
> -----------------------------------------------------------
>
> (Updated May 2, 2017, 5:28 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Di Li.
>
>
> Bugs: AMBARI-20908
> https://issues.apache.org/jira/browse/AMBARI-20908
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AMBARI-20908 Kafka advertised.listeners replaced in Kerberos Mode
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py 680dd32
>
>
> Diff: https://reviews.apache.org/r/58927/diff/1/
>
>
> Testing
> -------
>
> Tested with default installation and added advertised.listeners
> and enabled kerberos and then checked advertised.listeners to see if it is same as user provided.
>
>
> Thanks,
>
> Bharat Viswanadham
>
>
Re: Review Request 58927: AMBARI-20908 Kafka advertised.listeners
replaced in Kerberos Mode
Posted by Bharat Viswanadham <bh...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58927/
-----------------------------------------------------------
(Updated May 2, 2017, 5:28 p.m.)
Review request for Ambari, Alejandro Fernandez and Di Li.
Bugs: AMBARI-20908
https://issues.apache.org/jira/browse/AMBARI-20908
Repository: ambari
Description
-------
AMBARI-20908 Kafka advertised.listeners replaced in Kerberos Mode
Diffs
-----
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py 680dd32
Diff: https://reviews.apache.org/r/58927/diff/1/
Testing
-------
Tested with default installation and added advertised.listeners
and enabled kerberos and then checked advertised.listeners to see if it is same as user provided.
Thanks,
Bharat Viswanadham