[GitHub] [inlong] EMsnap commented on a diff in pull request #8607: [INLONG-8602][Sort] Fix StackOverflowError of Oracle CDC

["EMsnap (via GitHub)" <gi...@apache.org>]

EMsnap commented on code in PR #8607:
URL: https://github.com/apache/inlong/pull/8607#discussion_r1281452279


##########
inlong-sort/sort-flink/sort-flink-v1.13/sort-connectors/oracle-cdc/src/main/java/org/apache/inlong/sort/cdc/oracle/debezium/table/RowDataDebeziumDeserializeSchema.java:
##########
@@ -797,7 +797,32 @@ private Object getValueWithSchema(Object fieldValue, String schemaName) {
 
     @Override
     public void deserialize(SourceRecord record, Collector<RowData> out) throws Exception {
-        deserialize(record, out);
+        Envelope.Operation op = Envelope.operationFor(record);

Review Comment:
   There are same code in public void deserialize(SourceRecord record, Collector<RowData> out,TableChange tableSchema) , maybe reuse them is a better idea



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org