You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by Carsten Ziegeler <cz...@apache.org> on 2005/03/21 10:01:00 UTC
[IMP] Taglib block broken in 2.1.7-dev
I just tried to fix the reported problem with the taglib block:
http://issues.apache.org/bugzilla/show_bug.cgi?id=34086
but for me it seems now that the block is totally broken, for example
inside a for each loop no variables are available. I think this is due
to the fact, that each lookup of a JXPathCocoonContexts in the
VarTagSupport class results in a different instance. So the for each tag
sets the variables accordingly in its own context while the out tag then
gets a new/fresh context without any variables.
I can't fix it, can anyone else?
I don't want to delay the release just because of problems in the taglib
block (it seems that its not used very often anyways), so the question
is what do we want to do now?
Carsten
--
Carsten Ziegeler - Open Source Group, S&N AG
http://www.s-und-n.de
http://www.osoco.org/weblogs/rael/
Re: [IMP] Taglib block broken in 2.1.7-dev
Posted by Vadim Gritsenko <va...@reverycodes.com>.
Carsten Ziegeler wrote:
> Vadim Gritsenko wrote:
>
>>I'd suggested before to switch instead to JSTL instead - it would make it way
>>easier to port jsps to taglib block. Don't think yet another expression language
>>is needed in the taglib block.
>
> Hmm, don't know - I think the taglib block is really superfluous. What
> does it provide that jxtg/template block does not?
It's mimicking JSP taglib / provides JSP taglib "compatibility layer". It's
relatively easy to port JSP taglib application to the Cocoon using taglib block.
If it were to use JSTL, then it will be even more "compatible" with JSP.
Vadim
Re: [IMP] Taglib block broken in 2.1.7-dev
Posted by Carsten Ziegeler <cz...@apache.org>.
Vadim Gritsenko wrote:
> Carsten Ziegeler wrote:
>
>>Ok, just an update: I think I fixed the problem - if someone with more
>>knowledge of the taglib block could have a look at it I would be very
>>happy ;)
>>
>>But this does not block our release anymore :)
>
>
> It was not blocker in a first place - 2.1.6 was released with the same bugs.
Oh, didn't know that - but I think noone reported it.
>
> I'd suggested before to switch instead to JSTL instead - it would make it way
> easier to port jsps to taglib block. Don't think yet another expression language
> is needed in the taglib block.
>
Hmm, don't know - I think the taglib block is really superfluous. What
does it provide that jxtg/template block does not?
Carsten
--
Carsten Ziegeler - Open Source Group, S&N AG
http://www.s-und-n.de
http://www.osoco.org/weblogs/rael/
Re: [IMP] Taglib block broken in 2.1.7-dev
Posted by Vadim Gritsenko <va...@reverycodes.com>.
Carsten Ziegeler wrote:
> Ok, just an update: I think I fixed the problem - if someone with more
> knowledge of the taglib block could have a look at it I would be very
> happy ;)
>
> But this does not block our release anymore :)
It was not blocker in a first place - 2.1.6 was released with the same bugs.
I'd suggested before to switch instead to JSTL instead - it would make it way
easier to port jsps to taglib block. Don't think yet another expression language
is needed in the taglib block.
Vadim
> Carsten
>
> Carsten Ziegeler wrote:
>
>>I just tried to fix the reported problem with the taglib block:
>>
>>http://issues.apache.org/bugzilla/show_bug.cgi?id=34086
>>
>>but for me it seems now that the block is totally broken, for example
>>inside a for each loop no variables are available. I think this is due
>>to the fact, that each lookup of a JXPathCocoonContexts in the
>>VarTagSupport class results in a different instance. So the for each tag
>>sets the variables accordingly in its own context while the out tag then
>>gets a new/fresh context without any variables.
>>I can't fix it, can anyone else?
>>
>>I don't want to delay the release just because of problems in the taglib
>>block (it seems that its not used very often anyways), so the question
>>is what do we want to do now?
>>
>>Carsten
Re: [IMP] Taglib block broken in 2.1.7-dev
Posted by Carsten Ziegeler <cz...@apache.org>.
Ok, just an update: I think I fixed the problem - if someone with more
knowledge of the taglib block could have a look at it I would be very
happy ;)
But this does not block our release anymore :)
Carsten
Carsten Ziegeler wrote:
> I just tried to fix the reported problem with the taglib block:
>
> http://issues.apache.org/bugzilla/show_bug.cgi?id=34086
>
> but for me it seems now that the block is totally broken, for example
> inside a for each loop no variables are available. I think this is due
> to the fact, that each lookup of a JXPathCocoonContexts in the
> VarTagSupport class results in a different instance. So the for each tag
> sets the variables accordingly in its own context while the out tag then
> gets a new/fresh context without any variables.
> I can't fix it, can anyone else?
>
> I don't want to delay the release just because of problems in the taglib
> block (it seems that its not used very often anyways), so the question
> is what do we want to do now?
>
> Carsten
>
--
Carsten Ziegeler - Open Source Group, S&N AG
http://www.s-und-n.de
http://www.osoco.org/weblogs/rael/