[GitHub] [pinot] walterddr commented on a change in pull request #8122: adding isInstantDelete API for segment deletion

[GitBox <gi...@apache.org>]

walterddr commented on a change in pull request #8122:
URL: https://github.com/apache/pinot/pull/8122#discussion_r808670480



##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java
##########
@@ -571,12 +571,15 @@ public SuccessResponse reloadAllSegmentsDeprecated2(
   @ApiOperation(value = "Delete a segment", notes = "Delete a segment")
   public SuccessResponse deleteSegment(
       @ApiParam(value = "Name of the table", required = true) @PathParam("tableName") String tableName,
-      @ApiParam(value = "Name of the segment", required = true) @PathParam("segmentName") @Encoded String segmentName) {
+      @ApiParam(value = "Name of the segment", required = true) @PathParam("segmentName") @Encoded String segmentName,
+      @ApiParam(value = "Whether to delete the segment instantly or move to deleted_segment prefix and let "
+          + "RetentionManager handle the actual file deletion") @QueryParam("instantDelete") @DefaultValue("false")

Review comment:
       with https://github.com/apache/pinot/pull/8176 we will be able to change the API to 
   ```suggestion
             + @ApiParam(value = "segment delete retention period, (for example 12h, 3d); setting it to 0d will instant delete the segments") @QueryParam("deleteRetention") @DefaultValue("7d") deleteRetentionPeriod
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org