You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stratos.apache.org by Vishanth Balasubramaniam <vi...@wso2.com> on 2015/04/25 22:03:11 UTC
[Code review notes] Deployment policy update with partition changes
Hi Devs,
Please find the code review notes for *Deployment policy update with
partition changes: Lahiru*
class: *AutoscalerServiceImpl *method: *updateClusterMonitors*
- Line comments in the implemented methods to explain complex logic
- Add a new exception something like CloudControllerFailureException and
throw it instead of InvalidDeploymentPolicyException
- Provide specific error message rather than having a generic exception
for exceptions
- log.error() can also log the exception with the custom message
class:* AutoscalerServiceImpl *method:* removeOldPartitionContext*
- can use Iterator instead of using while with size check
- Use third person writing in the comments
Regards,
Vishanth
--
*Vishanth Balasubramaniam*
Software Engineer
WSO2 Inc.; http://wso2.com
lean.enterprise.middleware
mobile: *+94771737718*
about me: *http://about.me/vishanth <http://about.me/vishanth>*