You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jonathan Hsieh (JIRA)" <ji...@apache.org> on 2013/08/19 18:02:47 UTC
[jira] [Updated] (HBASE-9262) Make KeyValue.KEY_COMPARATOR default
for HFile WriterFactory
[ https://issues.apache.org/jira/browse/HBASE-9262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-9262:
----------------------------------
Attachment: hbase-9246.patch
Patch does above but also has these modifications:
- Cleanup KeyValue#getType vs getTypeByte
- Refactor/remove some gratuitous KeyValue constructors.
- Privatizes some KeyValue methods.
- Move KeyValue#getRowComparator to TableName#getRowComparator
> Make KeyValue.KEY_COMPARATOR default for HFile WriterFactory
> ------------------------------------------------------------
>
> Key: HBASE-9262
> URL: https://issues.apache.org/jira/browse/HBASE-9262
> Project: HBase
> Issue Type: Sub-task
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-9262.patch
>
>
> This takes completed work mentioned in HBASE-9247 as a reasonably sized patch to build upon.
> * Fixed defaults in HFile.Writer factory to default to Key-format-aware comparator (KeyComparator, later converted to KVComparator) instead of a Key-format oblivious byte[] comparator. (Essentially all instances require specifying KEY_COMPARATOR – why not just make it the default).
> ** Found that TestSeekTo, TestReseekTo and a handful of others depend on a different comparator because – HBASE-7845 "breaks" assumptions in these tests.
> * Moved getComparator into TableName. (removed an instanceof bad smell)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira