You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@subversion.apache.org by Daniel Shahaf <d....@daniel.shahaf.name> on 2011/02/11 16:17:17 UTC

Re: svn commit: r1068249 - in /subversion/trunk/subversion: libsvn_fs_util/caching.c libsvn_subr/cache-membuffer.c

stefan2@apache.org wrote on Tue, Feb 08, 2011 at 02:08:41 -0000:
> @@ -111,16 +113,49 @@ svn_fs__get_global_membuffer_cache(void)
> +      /* don't terminate upon OOM but make pool return a NULL pointer
> +       * instead so we can disable caching gracefully and continue
> +       * operation without membuffer caches.
> +       */

Log an error?

(e.g., fs->warning_func())

> @@ -802,21 +813,9 @@ svn_cache__membuffer_cache_create(svn_me
> +          return svn_error_wrap_apr(APR_ENOMEM, _("OOM"));

Spell out "Out of memory"?