You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/08/17 20:27:38 UTC
[kudu-CR] Tag follower unavailable considered failed sec as runtime safe
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11261
Change subject: Tag follower_unavailable_considered_failed_sec as runtime safe
......................................................................
Tag follower_unavailable_considered_failed_sec as runtime safe
This patch tags the
follower_unavailable_considered_failed_sec flag as
runtime safe so that the set_flags tools do not
require the -force argument.
Change-Id: I3328f7824a6abfff017bc05ae5b053a9de9a834f
---
M src/kudu/consensus/consensus_queue.cc
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/11261/1
--
To view, visit http://gerrit.cloudera.org:8080/11261
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3328f7824a6abfff017bc05ae5b053a9de9a834f
Gerrit-Change-Number: 11261
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] Tag follower unavailable considered failed sec as runtime safe
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11261 )
Change subject: Tag follower_unavailable_considered_failed_sec as runtime safe
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11261/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11261/1//COMMIT_MSG@9
PS1, Line 9: This patch tags the
: follower_unavailable_considered_failed_sec flag as
: runtime safe so that the set_flags tools do not
: require the -force argument.
> Done
Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/11261
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3328f7824a6abfff017bc05ae5b053a9de9a834f
Gerrit-Change-Number: 11261
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 17 Aug 2018 20:39:42 +0000
Gerrit-HasComments: Yes
[kudu-CR] Tag follower unavailable considered failed sec as runtime safe
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11261 )
Change subject: Tag follower_unavailable_considered_failed_sec as runtime safe
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11261/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11261/1//COMMIT_MSG@9
PS1, Line 9: This patch tags the
: follower_unavailable_considered_failed_sec flag as
: runtime safe so that the set_flags tools do not
: require the -force argument.
> Could you add a note about this flag being runtime de facto due to the way
Done
--
To view, visit http://gerrit.cloudera.org:8080/11261
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3328f7824a6abfff017bc05ae5b053a9de9a834f
Gerrit-Change-Number: 11261
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 17 Aug 2018 20:38:31 +0000
Gerrit-HasComments: Yes
[kudu-CR] Tag follower unavailable considered failed sec as runtime safe
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11261
to look at the new patch set (#2).
Change subject: Tag follower_unavailable_considered_failed_sec as runtime safe
......................................................................
Tag follower_unavailable_considered_failed_sec as runtime safe
This patch tags the
follower_unavailable_considered_failed_sec flag as
runtime safe so that the set_flags tools do not
require the -force argument.
This flag has been defacto runtime changable since at least Kudu 1.5.0 but hasn’t been marked as such.
It is runtime changeable because the flag is checked each time the peer health status is checked.
Change-Id: I3328f7824a6abfff017bc05ae5b053a9de9a834f
---
M src/kudu/consensus/consensus_queue.cc
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/11261/2
--
To view, visit http://gerrit.cloudera.org:8080/11261
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3328f7824a6abfff017bc05ae5b053a9de9a834f
Gerrit-Change-Number: 11261
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Tag follower unavailable considered failed sec as runtime safe
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: Tag follower_unavailable_considered_failed_sec as runtime safe
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/11261
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I3328f7824a6abfff017bc05ae5b053a9de9a834f
Gerrit-Change-Number: 11261
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Tag follower unavailable considered failed sec as runtime safe
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11261 )
Change subject: Tag follower_unavailable_considered_failed_sec as runtime safe
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11261
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3328f7824a6abfff017bc05ae5b053a9de9a834f
Gerrit-Change-Number: 11261
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 17 Aug 2018 20:39:23 +0000
Gerrit-HasComments: No
[kudu-CR] Tag follower unavailable considered failed sec as runtime safe
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11261 )
Change subject: Tag follower_unavailable_considered_failed_sec as runtime safe
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11261/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11261/1//COMMIT_MSG@9
PS1, Line 9: This patch tags the
: follower_unavailable_considered_failed_sec flag as
: runtime safe so that the set_flags tools do not
: require the -force argument.
Could you add a note about this flag being runtime de facto due to the way it's used in the code?
--
To view, visit http://gerrit.cloudera.org:8080/11261
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3328f7824a6abfff017bc05ae5b053a9de9a834f
Gerrit-Change-Number: 11261
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 17 Aug 2018 20:35:14 +0000
Gerrit-HasComments: Yes
[kudu-CR] Tag follower unavailable considered failed sec as runtime safe
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11261 )
Change subject: Tag follower_unavailable_considered_failed_sec as runtime safe
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11261
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3328f7824a6abfff017bc05ae5b053a9de9a834f
Gerrit-Change-Number: 11261
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 20 Aug 2018 02:23:50 +0000
Gerrit-HasComments: No
[kudu-CR] Tag follower unavailable considered failed sec as runtime safe
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11261 )
Change subject: Tag follower_unavailable_considered_failed_sec as runtime safe
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11261
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3328f7824a6abfff017bc05ae5b053a9de9a834f
Gerrit-Change-Number: 11261
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Sat, 18 Aug 2018 13:16:24 +0000
Gerrit-HasComments: No
[kudu-CR] Tag follower unavailable considered failed sec as runtime safe
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11261 )
Change subject: Tag follower_unavailable_considered_failed_sec as runtime safe
......................................................................
Tag follower_unavailable_considered_failed_sec as runtime safe
This patch tags the
follower_unavailable_considered_failed_sec flag as
runtime safe so that the set_flags tools do not
require the -force argument.
This flag has been defacto runtime changable since
at least Kudu 1.5.0 but hasn’t been marked as such.
It is runtime changeable because the flag is checked
each time the peer health status is checked.
Change-Id: I3328f7824a6abfff017bc05ae5b053a9de9a834f
Reviewed-on: http://gerrit.cloudera.org:8080/11261
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Attila Bukor <ab...@apache.org>
Tested-by: Grant Henke <gr...@apache.org>
---
M src/kudu/consensus/consensus_queue.cc
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Attila Bukor: Looks good to me, approved
Grant Henke: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11261
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3328f7824a6abfff017bc05ae5b053a9de9a834f
Gerrit-Change-Number: 11261
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Tag follower unavailable considered failed sec as runtime safe
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11261
to look at the new patch set (#3).
Change subject: Tag follower_unavailable_considered_failed_sec as runtime safe
......................................................................
Tag follower_unavailable_considered_failed_sec as runtime safe
This patch tags the
follower_unavailable_considered_failed_sec flag as
runtime safe so that the set_flags tools do not
require the -force argument.
This flag has been defacto runtime changable since
at least Kudu 1.5.0 but hasn’t been marked as such.
It is runtime changeable because the flag is checked
each time the peer health status is checked.
Change-Id: I3328f7824a6abfff017bc05ae5b053a9de9a834f
---
M src/kudu/consensus/consensus_queue.cc
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/11261/3
--
To view, visit http://gerrit.cloudera.org:8080/11261
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3328f7824a6abfff017bc05ae5b053a9de9a834f
Gerrit-Change-Number: 11261
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins