[jira] Resolved: (PDFBOX-713) PDFont fails to close Font File.

["Andreas Lehmkühler (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/PDFBOX-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Lehmkühler resolved PDFBOX-713.
---------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5.0

I had to adapt the proposed patch as the affected code was moved to another class. Added the fix ion revision 1062489.

Thanks for the contribution!

> PDFont fails to close Font File.
> --------------------------------
>
>                 Key: PDFBOX-713
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-713
>             Project: PDFBox
>          Issue Type: Bug
>          Components: FontBox
>    Affects Versions: 1.1.0
>            Reporter: Peter_Lenahan@ibi.com
>            Assignee: Andreas Lehmkühler
>             Fix For: 1.5.0
>
>         Attachments: PDFont-Fails-toCloseFontFile.txt, PDFont.java
>
>
> Findbugs Reported this problem.
> I have include a patch which closes the file.
> BufferedReader in = new BufferedReader(new InputStreamReader(fontFile.getUnfilteredStream()));
> Bug: org.apache.pdfbox.pdmodel.font.PDFont.getEncodingFromFont() may fail to close stream
> Pattern id: OS_OPEN_STREAM, type: OS, category: BAD_PRACTICE
> The method creates an IO stream object, does not assign it to any fields, pass it to other methods that might close it, or return it, and does not appear to close the stream on all paths out of the method.  This may result in a file descriptor leak.  It is generally a good idea to use a finally block to ensure that streams are closed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.