You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Paul Lindner (JIRA)" <ji...@apache.org> on 2008/02/25 10:44:56 UTC
[jira] Created: (SHINDIG-94) Cached Flash proxy does not repsect
syncidator settings.
Cached Flash proxy does not repsect syncidator settings.
--------------------------------------------------------
Key: SHINDIG-94
URL: https://issues.apache.org/jira/browse/SHINDIG-94
Project: Shindig
Issue Type: Bug
Reporter: Paul Lindner
Assignee: Paul Lindner
The flash feature uses a fixed URL pattern to implement gadgets.flash. Instead we should use gadgets.io.getProxyUrl(url)
Patch:
arcwelder:shindig plindner$ svn diff features/flash/flash.js
Index: features/flash/flash.js
===================================================================
--- features/flash/flash.js (revision 630759)
+++ features/flash/flash.js (working copy)
@@ -176,9 +176,7 @@
*/
gadgets.flash.embedCachedFlash = function() {
var args = Array.prototype.slice.call(arguments);
- // TODO: This needs to use gadgets.io.getProxyUrl()
- args[0] = 'http://' + document.location.host + '/gadgets/proxy?url=' +
- args[0];
+ args[0] = gadgets.io.getProxyUrl(args[0]);
gadgets.flash.embedFlash.apply(this, args);
};
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Created: (SHINDIG-94) Cached Flash proxy does not repsect syncidator settings.
Posted by Cassie <do...@apache.org>.
+1
On Mon, Feb 25, 2008 at 11:40 AM, Kevin Brown <et...@google.com> wrote:
> Can you go ahead and commit this? I don't see any reason why not.
>
> On Mon, Feb 25, 2008 at 1:44 AM, Paul Lindner (JIRA) <ji...@apache.org>
> wrote:
>
> > Cached Flash proxy does not repsect syncidator settings.
> > --------------------------------------------------------
> >
> > Key: SHINDIG-94
> > URL: https://issues.apache.org/jira/browse/SHINDIG-94
> > Project: Shindig
> > Issue Type: Bug
> > Reporter: Paul Lindner
> > Assignee: Paul Lindner
> >
> >
> > The flash feature uses a fixed URL pattern to implement gadgets.flash.
> > Instead we should use gadgets.io.getProxyUrl(url)
> >
> > Patch:
> >
> > arcwelder:shindig plindner$ svn diff features/flash/flash.js
> > Index: features/flash/flash.js
> > ===================================================================
> > --- features/flash/flash.js (revision 630759)
> > +++ features/flash/flash.js (working copy)
> > @@ -176,9 +176,7 @@
> > */
> > gadgets.flash.embedCachedFlash = function() {
> > var args = Array.prototype.slice.call(arguments);
> > - // TODO: This needs to use gadgets.io.getProxyUrl()
> > - args[0] = 'http://' + document.location.host + '/gadgets/proxy?url='
> +
> > - args[0];
> > + args[0] = gadgets.io.getProxyUrl(args[0]);
> > gadgets.flash.embedFlash.apply(this, args);
> > };
> >
> > --
> > This message is automatically generated by JIRA.
> > -
> > You can reply to this email to add a comment to the issue online.
> >
> >
>
>
> --
> ~Kevin
>
> If you received this email by mistake, please delete it, cancel your mail
> account, destroy your hard drive, silence any witnesses, and burn down the
> building that you're in.
>
Re: [jira] Created: (SHINDIG-94) Cached Flash proxy does not repsect syncidator settings.
Posted by Kevin Brown <et...@google.com>.
Can you go ahead and commit this? I don't see any reason why not.
On Mon, Feb 25, 2008 at 1:44 AM, Paul Lindner (JIRA) <ji...@apache.org>
wrote:
> Cached Flash proxy does not repsect syncidator settings.
> --------------------------------------------------------
>
> Key: SHINDIG-94
> URL: https://issues.apache.org/jira/browse/SHINDIG-94
> Project: Shindig
> Issue Type: Bug
> Reporter: Paul Lindner
> Assignee: Paul Lindner
>
>
> The flash feature uses a fixed URL pattern to implement gadgets.flash.
> Instead we should use gadgets.io.getProxyUrl(url)
>
> Patch:
>
> arcwelder:shindig plindner$ svn diff features/flash/flash.js
> Index: features/flash/flash.js
> ===================================================================
> --- features/flash/flash.js (revision 630759)
> +++ features/flash/flash.js (working copy)
> @@ -176,9 +176,7 @@
> */
> gadgets.flash.embedCachedFlash = function() {
> var args = Array.prototype.slice.call(arguments);
> - // TODO: This needs to use gadgets.io.getProxyUrl()
> - args[0] = 'http://' + document.location.host + '/gadgets/proxy?url=' +
> - args[0];
> + args[0] = gadgets.io.getProxyUrl(args[0]);
> gadgets.flash.embedFlash.apply(this, args);
> };
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
--
~Kevin
If you received this email by mistake, please delete it, cancel your mail
account, destroy your hard drive, silence any witnesses, and burn down the
building that you're in.
[jira] Resolved: (SHINDIG-94) Cached Flash proxy does not repsect
syndicator settings.
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-94?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner resolved SHINDIG-94.
---------------------------------
Resolution: Fixed
Fixed in r60983
> Cached Flash proxy does not repsect syndicator settings.
> --------------------------------------------------------
>
> Key: SHINDIG-94
> URL: https://issues.apache.org/jira/browse/SHINDIG-94
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Reporter: Paul Lindner
> Assignee: Paul Lindner
>
> The flash feature uses a fixed URL pattern to implement gadgets.flash. Instead we should use gadgets.io.getProxyUrl(url)
> Patch:
> arcwelder:shindig plindner$ svn diff features/flash/flash.js
> Index: features/flash/flash.js
> ===================================================================
> --- features/flash/flash.js (revision 630759)
> +++ features/flash/flash.js (working copy)
> @@ -176,9 +176,7 @@
> */
> gadgets.flash.embedCachedFlash = function() {
> var args = Array.prototype.slice.call(arguments);
> - // TODO: This needs to use gadgets.io.getProxyUrl()
> - args[0] = 'http://' + document.location.host + '/gadgets/proxy?url=' +
> - args[0];
> + args[0] = gadgets.io.getProxyUrl(args[0]);
> gadgets.flash.embedFlash.apply(this, args);
> };
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-94) Cached Flash proxy does not repsect
syndicator settings.
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-94?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner updated SHINDIG-94:
--------------------------------
Summary: Cached Flash proxy does not repsect syndicator settings. (was: Cached Flash proxy does not repsect syncidator settings.)
> Cached Flash proxy does not repsect syndicator settings.
> --------------------------------------------------------
>
> Key: SHINDIG-94
> URL: https://issues.apache.org/jira/browse/SHINDIG-94
> Project: Shindig
> Issue Type: Bug
> Reporter: Paul Lindner
> Assignee: Paul Lindner
>
> The flash feature uses a fixed URL pattern to implement gadgets.flash. Instead we should use gadgets.io.getProxyUrl(url)
> Patch:
> arcwelder:shindig plindner$ svn diff features/flash/flash.js
> Index: features/flash/flash.js
> ===================================================================
> --- features/flash/flash.js (revision 630759)
> +++ features/flash/flash.js (working copy)
> @@ -176,9 +176,7 @@
> */
> gadgets.flash.embedCachedFlash = function() {
> var args = Array.prototype.slice.call(arguments);
> - // TODO: This needs to use gadgets.io.getProxyUrl()
> - args[0] = 'http://' + document.location.host + '/gadgets/proxy?url=' +
> - args[0];
> + args[0] = gadgets.io.getProxyUrl(args[0]);
> gadgets.flash.embedFlash.apply(this, args);
> };
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-94) Cached Flash proxy does not repsect
syndicator settings.
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-94?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner updated SHINDIG-94:
--------------------------------
Component/s: Javascript
> Cached Flash proxy does not repsect syndicator settings.
> --------------------------------------------------------
>
> Key: SHINDIG-94
> URL: https://issues.apache.org/jira/browse/SHINDIG-94
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Reporter: Paul Lindner
> Assignee: Paul Lindner
>
> The flash feature uses a fixed URL pattern to implement gadgets.flash. Instead we should use gadgets.io.getProxyUrl(url)
> Patch:
> arcwelder:shindig plindner$ svn diff features/flash/flash.js
> Index: features/flash/flash.js
> ===================================================================
> --- features/flash/flash.js (revision 630759)
> +++ features/flash/flash.js (working copy)
> @@ -176,9 +176,7 @@
> */
> gadgets.flash.embedCachedFlash = function() {
> var args = Array.prototype.slice.call(arguments);
> - // TODO: This needs to use gadgets.io.getProxyUrl()
> - args[0] = 'http://' + document.location.host + '/gadgets/proxy?url=' +
> - args[0];
> + args[0] = gadgets.io.getProxyUrl(args[0]);
> gadgets.flash.embedFlash.apply(this, args);
> };
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.