You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "amoghrajesh (via GitHub)" <gi...@apache.org> on 2025/08/04 06:40:08 UTC
[PR] Limit paramiko to `< 4.0.0` till we remove DSS support [airflow]
amoghrajesh opened a new pull request, #54078:
URL: https://github.com/apache/airflow/pull/54078
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
A new version of paramiko has been released:
```
< paramiko==3.5.1
---
> paramiko==4.0.0
```
Due to the paramiko bump, there is an compatibility issue with newer versions of paramiko (4.0+) where `DSSKey` has been removed for security reasons.
This was causing test failures in `test_should_be_importable` for providers that depend on the SSH provider.
Failure:
```
Traceback (most recent call last):
File "/opt/airflow/airflow-core/src/airflow/models/dagbag.py", line 432, in parse
loader.exec_module(new_module)
File "<frozen importlib._bootstrap_external>", line 883, in exec_module
File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
File "/opt/airflow/providers/google/tests/system/google/cloud/transfers/example_gcs_to_sftp.py", line 30, in <module>
from airflow.providers.google.cloud.transfers.gcs_to_sftp import GCSToSFTPOperator
File "/opt/airflow/providers/google/src/airflow/providers/google/cloud/transfers/gcs_to_sftp.py", line 31, in <module>
from airflow.providers.sftp.hooks.sftp import SFTPHook
File "/opt/airflow/providers/sftp/src/airflow/providers/sftp/hooks/sftp.py", line 39, in <module>
from airflow.providers.ssh.hooks.ssh import SSHHook
File "/opt/airflow/providers/ssh/src/airflow/providers/ssh/hooks/ssh.py", line 43, in <module>
class SSHHook(BaseHook):
File "/opt/airflow/providers/ssh/src/airflow/providers/ssh/hooks/ssh.py", line 81, in SSHHook
paramiko.DSSKey,
```
Example: https://github.com/apache/airflow/actions/runs/16713668042/job/47303410955.
An ideal way forward would be to remove the DSS support from airflow & bump the paramiko version with that, for now, to fix CI, i think limiting paramiko to < 4.0.0 would be good enough.
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Limit paramiko to `< 4.0.0` till we remove DSS support [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #54078:
URL: https://github.com/apache/airflow/pull/54078#discussion_r2250548621
##########
providers/sftp/pyproject.toml:
##########
@@ -59,7 +59,7 @@ requires-python = ">=3.10"
dependencies = [
"apache-airflow>=2.10.0",
"apache-airflow-providers-ssh>=4.0.0",
- "paramiko>=2.9.0",
+ "paramiko>=2.9.0,<4.0.0",
Review Comment:
lets have todo + link to github issue that explain what needs to be fixed to be compatible with 4.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Limit paramiko to `< 4.0.0` till we remove DSS support [airflow]
Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on PR #54078:
URL: https://github.com/apache/airflow/pull/54078#issuecomment-3150090688
I've manually cherry-picked this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Limit paramiko to `< 4.0.0` till we remove DSS support [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh merged PR #54078:
URL: https://github.com/apache/airflow/pull/54078
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Limit paramiko to `< 4.0.0` till we remove DSS support [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #54078:
URL: https://github.com/apache/airflow/pull/54078#issuecomment-3150079301
### Backport failed to create: v3-0-test. View the failure log <a href='https://github.com/apache/airflow/actions/runs/16720947656'> Run details </a>
<table>
<tr>
<th>Status</th>
<th>Branch</th>
<th>Result</th>
</tr>
<tr>
<td>❌</td>
<td>v3-0-test</td>
<td><a href="https://github.com/apache/airflow/commit/18d75db"><img src='https://img.shields.io/badge/Commit-18d75db-red' alt='Commit Link'></a></td>
</tr>
</table>
You can attempt to backport this manually by running:
```bash
cherry_picker 18d75db v3-0-test
```
This should apply the commit to the v3-0-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.
After you have resolved the conflicts, you can continue the backport process by running:
```bash
cherry_picker --continue
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Limit paramiko to `< 4.0.0` till we remove DSS support [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #54078:
URL: https://github.com/apache/airflow/pull/54078#discussion_r2250572983
##########
providers/sftp/pyproject.toml:
##########
@@ -59,7 +59,7 @@ requires-python = ">=3.10"
dependencies = [
"apache-airflow>=2.10.0",
"apache-airflow-providers-ssh>=4.0.0",
- "paramiko>=2.9.0",
+ "paramiko>=2.9.0,<4.0.0",
Review Comment:
Thanks, added it in the commit: https://github.com/apache/airflow/pull/54078/commits/16b4b64d4e6b234dc5e2c2732d7f98a08fb0bc2c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org