You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2015/02/02 22:08:51 UTC
Re: Review Request 29603: Exposed slave/containerizer/isolator.hpp as
mesos/slave/isolator.hpp
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29603/
-----------------------------------------------------------
(Updated Feb. 2, 2015, 4:08 p.m.)
Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.
Changes
-------
rebased
Bugs: MESOS-2096
https://issues.apache.org/jira/browse/MESOS-2096
Repository: mesos
Description
-------
[5/9] Build Mesos Modules outside Mesos source tree.
Expose "slave/state.hpp" and "slave/containerizer/isolator.hpp" to allow modules to include them directly from the Mesos install location.
Diffs (updated)
-----
src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e
src/examples/test_isolator_module.cpp dc107a1315271b0275c60819c4b5aaa1f527e73c
src/module/isolator.hpp 0f71e700ed2de20bdc9a1fdad087005a14e208a8
src/slave/containerizer/containerizer.cpp 421bb868b353e644578fa27f04bdd636bfc89134
src/slave/containerizer/external_containerizer.hpp 8363cec490a2918e08a8d30d9b8832fd1e2dd4f5
src/slave/containerizer/isolator.hpp a27c3e955ff25b87599af0ac2c97427a88b786f6
src/slave/containerizer/isolator.cpp 90a47c4fc8ce2d1a2aa09fa9ad905b76eab74c80
src/slave/containerizer/isolators/cgroups/cpushare.hpp 4ded0c4678ad61742a69e14233006a448f3fc3ca
src/slave/containerizer/isolators/cgroups/mem.hpp 2fa755571b4d21b8b13301fcfd57ae05ea66e6e6
src/slave/containerizer/isolators/cgroups/perf_event.hpp e511c3efe4cc4ec13cc74bdcda993477a4db2e36
src/slave/containerizer/isolators/filesystem/shared.hpp 727f63e16fa69293c472a4b6b95fb0be04e689c8
src/slave/containerizer/isolators/namespaces/pid.hpp 8da6cccff04edf11fa37f5a33648821299cf49d5
src/slave/containerizer/isolators/network/port_mapping.hpp 90d19a95092bc18c1077fbaec9ebf9c87291474c
src/slave/containerizer/isolators/posix.hpp 7a667e3e30712b98484947520b58965d3b768659
src/slave/containerizer/isolators/posix/disk.hpp cf4e143eb50cf5ee59ca0d47dd6f8d0a845c3732
src/slave/containerizer/launcher.hpp 18b3546a5e51e8a3819bca11630f699a0aadf762
src/slave/containerizer/mesos/containerizer.hpp 802988c90ac872b0cefa5e28f06e6fec98e8d032
src/slave/containerizer/mesos/containerizer.cpp d712278428889ebdfd598537690138329d8464f0
src/tests/containerizer_tests.cpp cfe31a6b528ec44c5f4ff9eaf453c68d9e518db4
src/tests/isolator.hpp 2c3a694fade996df6fb679e78f96876a7d32d214
src/tests/isolator_tests.cpp 1f1c26d4a8faf6fcea822fccc00bb58a478285f8
src/tests/module_tests.cpp df30e169a1e9ee2e6c419ba30612d55328e3adbc
src/tests/port_mapping_tests.cpp 18d58ff310d189f7461eead445e186172cbcd101
Diff: https://reviews.apache.org/r/29603/diff/
Testing
-------
make check.
Thanks,
Kapil Arya
Re: Review Request 29603: Exposed slave/containerizer/isolator.hpp as
mesos/slave/isolator.hpp
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29603/
-----------------------------------------------------------
(Updated Feb. 9, 2015, 9:53 p.m.)
Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.
Changes
-------
rebased
Bugs: MESOS-2096
https://issues.apache.org/jira/browse/MESOS-2096
Repository: mesos
Description
-------
[5/9] Build Mesos Modules outside Mesos source tree.
Expose "slave/state.hpp" and "slave/containerizer/isolator.hpp" to allow modules to include them directly from the Mesos install location.
Diffs (updated)
-----
src/Makefile.am 93537d17d3c7604a8532ee1453e405630c481ddc
src/examples/test_isolator_module.cpp 3b92b04e90ee7c2214597ed18c9b9270329ab545
src/module/isolator.hpp b5c86e38616a5e9068f06131094f473d933429a8
src/slave/containerizer/containerizer.cpp cf2ece80252350c25db38116e29cf28a3164662d
src/slave/containerizer/external_containerizer.hpp 12968781b47cbf53bef2529d6bbc3819b09c36e9
src/slave/containerizer/isolator.hpp e39a8a5e7ecd3273cabab2d7f4038eb7a6d88bb3
src/slave/containerizer/isolator.cpp bb4da46f2d0984956b57ffbb065dc3cc43ff8262
src/slave/containerizer/isolators/cgroups/cpushare.hpp 1050af7394fa7b181ce5e1d1841c397da7649b84
src/slave/containerizer/isolators/cgroups/mem.hpp 4de5c646d2869f5893158a260f973ec098bcc33e
src/slave/containerizer/isolators/cgroups/perf_event.hpp 6bf885820d09d6ee3190b465851207a46dacd038
src/slave/containerizer/isolators/filesystem/shared.hpp a5b5ca1dd598ea35aa6d08ded93f881eb6bc2c65
src/slave/containerizer/isolators/namespaces/pid.hpp 7052a033c1beeb8dab73ef0f4e75185d6130650a
src/slave/containerizer/isolators/network/port_mapping.hpp 1e4ed3d3929b648308dfd03d1f8b578988cf079d
src/slave/containerizer/isolators/posix.hpp b6d289bc2a7e9d0e86c2a2bf7134b9612754830f
src/slave/containerizer/isolators/posix/disk.hpp 58a06c7f47b33006705b1ded8f4fdcff95cabb2d
src/slave/containerizer/launcher.hpp b6fab38865c2be576ced5486a55ae931730572ed
src/slave/containerizer/mesos/containerizer.hpp b3aafe4efa9f3469d7a3fd39243ad66b46d6a54d
src/slave/containerizer/mesos/containerizer.cpp fa40d47aee7803833bcde6cce1e86a21d7cf27d0
src/tests/containerizer_tests.cpp 7300333ab17250160d640d2a7c79c58257d0c345
src/tests/isolator.hpp 7c40f3cb419057c91b307f164edcdb724d45c50d
src/tests/isolator_tests.cpp 093b9fd97c28efc008e790346f4cffa7a05ca275
src/tests/module_tests.cpp 2e113be2a48290fb862b04022f38458b4612ab26
src/tests/port_mapping_tests.cpp 462e49af866cb4873710a60fb1e1c5d68146f1d7
Diff: https://reviews.apache.org/r/29603/diff/
Testing
-------
make check.
Thanks,
Kapil Arya
Re: Review Request 29603: Exposed slave/containerizer/isolator.hpp as
mesos/slave/isolator.hpp
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29603/
-----------------------------------------------------------
(Updated Feb. 9, 2015, 9:38 p.m.)
Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.
Changes
-------
rebased
Bugs: MESOS-2096
https://issues.apache.org/jira/browse/MESOS-2096
Repository: mesos
Description
-------
[5/9] Build Mesos Modules outside Mesos source tree.
Expose "slave/state.hpp" and "slave/containerizer/isolator.hpp" to allow modules to include them directly from the Mesos install location.
Diffs (updated)
-----
src/Makefile.am 93537d17d3c7604a8532ee1453e405630c481ddc
src/examples/test_isolator_module.cpp 3b92b04e90ee7c2214597ed18c9b9270329ab545
src/module/isolator.hpp b5c86e38616a5e9068f06131094f473d933429a8
src/slave/containerizer/containerizer.cpp cf2ece80252350c25db38116e29cf28a3164662d
src/slave/containerizer/external_containerizer.hpp 12968781b47cbf53bef2529d6bbc3819b09c36e9
src/slave/containerizer/isolator.hpp e39a8a5e7ecd3273cabab2d7f4038eb7a6d88bb3
src/slave/containerizer/isolator.cpp bb4da46f2d0984956b57ffbb065dc3cc43ff8262
src/slave/containerizer/isolators/cgroups/cpushare.hpp 1050af7394fa7b181ce5e1d1841c397da7649b84
src/slave/containerizer/isolators/cgroups/mem.hpp 4de5c646d2869f5893158a260f973ec098bcc33e
src/slave/containerizer/isolators/cgroups/perf_event.hpp 6bf885820d09d6ee3190b465851207a46dacd038
src/slave/containerizer/isolators/filesystem/shared.hpp a5b5ca1dd598ea35aa6d08ded93f881eb6bc2c65
src/slave/containerizer/isolators/namespaces/pid.hpp 7052a033c1beeb8dab73ef0f4e75185d6130650a
src/slave/containerizer/isolators/network/port_mapping.hpp 1e4ed3d3929b648308dfd03d1f8b578988cf079d
src/slave/containerizer/isolators/posix.hpp b6d289bc2a7e9d0e86c2a2bf7134b9612754830f
src/slave/containerizer/isolators/posix/disk.hpp 58a06c7f47b33006705b1ded8f4fdcff95cabb2d
src/slave/containerizer/launcher.hpp b6fab38865c2be576ced5486a55ae931730572ed
src/slave/containerizer/mesos/containerizer.hpp b3aafe4efa9f3469d7a3fd39243ad66b46d6a54d
src/slave/containerizer/mesos/containerizer.cpp fa40d47aee7803833bcde6cce1e86a21d7cf27d0
src/tests/containerizer_tests.cpp 7300333ab17250160d640d2a7c79c58257d0c345
src/tests/isolator.hpp 7c40f3cb419057c91b307f164edcdb724d45c50d
src/tests/isolator_tests.cpp 093b9fd97c28efc008e790346f4cffa7a05ca275
src/tests/module_tests.cpp 2e113be2a48290fb862b04022f38458b4612ab26
src/tests/port_mapping_tests.cpp 462e49af866cb4873710a60fb1e1c5d68146f1d7
Diff: https://reviews.apache.org/r/29603/diff/
Testing
-------
make check.
Thanks,
Kapil Arya
Re: Review Request 29603: Exposed slave/containerizer/isolator.hpp as
mesos/slave/isolator.hpp
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29603/#review71743
-----------------------------------------------------------
Ship it!
- Niklas Nielsen
On Feb. 4, 2015, 7:15 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29603/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 7:15 p.m.)
>
>
> Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.
>
>
> Bugs: MESOS-2096
> https://issues.apache.org/jira/browse/MESOS-2096
>
>
> Repository: mesos
>
>
> Description
> -------
>
> [5/9] Build Mesos Modules outside Mesos source tree.
>
> Expose "slave/state.hpp" and "slave/containerizer/isolator.hpp" to allow modules to include them directly from the Mesos install location.
>
>
> Diffs
> -----
>
> src/Makefile.am 93537d17d3c7604a8532ee1453e405630c481ddc
> src/examples/test_isolator_module.cpp dc107a1315271b0275c60819c4b5aaa1f527e73c
> src/module/isolator.hpp 0f71e700ed2de20bdc9a1fdad087005a14e208a8
> src/slave/containerizer/containerizer.cpp 421bb868b353e644578fa27f04bdd636bfc89134
> src/slave/containerizer/external_containerizer.hpp 8363cec490a2918e08a8d30d9b8832fd1e2dd4f5
> src/slave/containerizer/isolator.hpp a27c3e955ff25b87599af0ac2c97427a88b786f6
> src/slave/containerizer/isolator.cpp 90a47c4fc8ce2d1a2aa09fa9ad905b76eab74c80
> src/slave/containerizer/isolators/cgroups/cpushare.hpp 4ded0c4678ad61742a69e14233006a448f3fc3ca
> src/slave/containerizer/isolators/cgroups/mem.hpp 2fa755571b4d21b8b13301fcfd57ae05ea66e6e6
> src/slave/containerizer/isolators/cgroups/perf_event.hpp e511c3efe4cc4ec13cc74bdcda993477a4db2e36
> src/slave/containerizer/isolators/filesystem/shared.hpp 727f63e16fa69293c472a4b6b95fb0be04e689c8
> src/slave/containerizer/isolators/namespaces/pid.hpp 8da6cccff04edf11fa37f5a33648821299cf49d5
> src/slave/containerizer/isolators/network/port_mapping.hpp 90d19a95092bc18c1077fbaec9ebf9c87291474c
> src/slave/containerizer/isolators/posix.hpp 7a667e3e30712b98484947520b58965d3b768659
> src/slave/containerizer/isolators/posix/disk.hpp cf4e143eb50cf5ee59ca0d47dd6f8d0a845c3732
> src/slave/containerizer/launcher.hpp 18b3546a5e51e8a3819bca11630f699a0aadf762
> src/slave/containerizer/mesos/containerizer.hpp 569119fc591ecb118ecff51b8b19d0a1b8090cb5
> src/slave/containerizer/mesos/containerizer.cpp d712278428889ebdfd598537690138329d8464f0
> src/tests/containerizer_tests.cpp cfe31a6b528ec44c5f4ff9eaf453c68d9e518db4
> src/tests/isolator.hpp 2c3a694fade996df6fb679e78f96876a7d32d214
> src/tests/isolator_tests.cpp 1f1c26d4a8faf6fcea822fccc00bb58a478285f8
> src/tests/module_tests.cpp df30e169a1e9ee2e6c419ba30612d55328e3adbc
> src/tests/port_mapping_tests.cpp 18d58ff310d189f7461eead445e186172cbcd101
>
> Diff: https://reviews.apache.org/r/29603/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 29603: Exposed slave/containerizer/isolator.hpp as
mesos/slave/isolator.hpp
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29603/
-----------------------------------------------------------
(Updated Feb. 4, 2015, 10:15 p.m.)
Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.
Changes
-------
rebased
Bugs: MESOS-2096
https://issues.apache.org/jira/browse/MESOS-2096
Repository: mesos
Description
-------
[5/9] Build Mesos Modules outside Mesos source tree.
Expose "slave/state.hpp" and "slave/containerizer/isolator.hpp" to allow modules to include them directly from the Mesos install location.
Diffs (updated)
-----
src/Makefile.am 93537d17d3c7604a8532ee1453e405630c481ddc
src/examples/test_isolator_module.cpp dc107a1315271b0275c60819c4b5aaa1f527e73c
src/module/isolator.hpp 0f71e700ed2de20bdc9a1fdad087005a14e208a8
src/slave/containerizer/containerizer.cpp 421bb868b353e644578fa27f04bdd636bfc89134
src/slave/containerizer/external_containerizer.hpp 8363cec490a2918e08a8d30d9b8832fd1e2dd4f5
src/slave/containerizer/isolator.hpp a27c3e955ff25b87599af0ac2c97427a88b786f6
src/slave/containerizer/isolator.cpp 90a47c4fc8ce2d1a2aa09fa9ad905b76eab74c80
src/slave/containerizer/isolators/cgroups/cpushare.hpp 4ded0c4678ad61742a69e14233006a448f3fc3ca
src/slave/containerizer/isolators/cgroups/mem.hpp 2fa755571b4d21b8b13301fcfd57ae05ea66e6e6
src/slave/containerizer/isolators/cgroups/perf_event.hpp e511c3efe4cc4ec13cc74bdcda993477a4db2e36
src/slave/containerizer/isolators/filesystem/shared.hpp 727f63e16fa69293c472a4b6b95fb0be04e689c8
src/slave/containerizer/isolators/namespaces/pid.hpp 8da6cccff04edf11fa37f5a33648821299cf49d5
src/slave/containerizer/isolators/network/port_mapping.hpp 90d19a95092bc18c1077fbaec9ebf9c87291474c
src/slave/containerizer/isolators/posix.hpp 7a667e3e30712b98484947520b58965d3b768659
src/slave/containerizer/isolators/posix/disk.hpp cf4e143eb50cf5ee59ca0d47dd6f8d0a845c3732
src/slave/containerizer/launcher.hpp 18b3546a5e51e8a3819bca11630f699a0aadf762
src/slave/containerizer/mesos/containerizer.hpp 569119fc591ecb118ecff51b8b19d0a1b8090cb5
src/slave/containerizer/mesos/containerizer.cpp d712278428889ebdfd598537690138329d8464f0
src/tests/containerizer_tests.cpp cfe31a6b528ec44c5f4ff9eaf453c68d9e518db4
src/tests/isolator.hpp 2c3a694fade996df6fb679e78f96876a7d32d214
src/tests/isolator_tests.cpp 1f1c26d4a8faf6fcea822fccc00bb58a478285f8
src/tests/module_tests.cpp df30e169a1e9ee2e6c419ba30612d55328e3adbc
src/tests/port_mapping_tests.cpp 18d58ff310d189f7461eead445e186172cbcd101
Diff: https://reviews.apache.org/r/29603/diff/
Testing
-------
make check.
Thanks,
Kapil Arya