Re: [PR] [cdc-cli][cdc-composer] Applying 'flink-config' for pipeline yaml [flink-cdc]

["lvyanquan (via GitHub)" <gi...@apache.org>]

lvyanquan commented on code in PR #3187:
URL: https://github.com/apache/flink-cdc/pull/3187#discussion_r1537533397


##########
flink-cdc-cli/src/main/java/org/apache/flink/cdc/cli/CliExecutor.java:
##########
@@ -69,10 +69,10 @@ public PipelineExecution.ExecutionInfo run() throws Exception {
         return execution.execute();
     }
 
-    private PipelineComposer getComposer(Configuration flinkConfig) {
+    private PipelineComposer getComposer(Configuration flinkConfig, Configuration pipelineConfig) {

Review Comment:
   Can we set flink config in PipelineComposer.compose https://github.com/apache/flink-cdc/blob/1c69a650e3187734962e824e40ed35de0d94ccfc/flink-cdc-composer/src/main/java/org/apache/flink/cdc/composer/flink/FlinkPipelineComposer.java#L96 method to avoid modifying these constructor?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org