You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@curator.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/10/21 04:19:00 UTC

[jira] [Commented] (CURATOR-438) Remove calls to MoreExecutors.sameThreadExecutor (deprecated)

    [ https://issues.apache.org/jira/browse/CURATOR-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16213722#comment-16213722 ] 

ASF GitHub Bot commented on CURATOR-438:
----------------------------------------

GitHub user kpm1985 opened a pull request:

    https://github.com/apache/curator/pull/240

    CURATOR-438 Replace Deprecated Methods

    This pull request addresses CURATOR-438 which replaces all occurrences of the deprecated MoreExecutors.sameTheadExecutor() with MoreExecutors.directExecutor(). 
    
    This has been an issue before a couple times, but some lingering calls remained so I searched them down and fixed them.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kpm1985/curator CURATOR-438

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/curator/pull/240.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #240
    
----
commit 6d36a4793b31cdacaf4bbf6554e05d68bc680001
Author: Kenneth McFarland <ke...@gmail.com>
Date:   2017-10-21T04:05:12Z

    Remove calls to deprecated MoreExecutors.sameThreadExecutor

----


> Remove calls to MoreExecutors.sameThreadExecutor (deprecated)
> -------------------------------------------------------------
>
>                 Key: CURATOR-438
>                 URL: https://issues.apache.org/jira/browse/CURATOR-438
>             Project: Apache Curator
>          Issue Type: Improvement
>          Components: Apache
>         Environment: master branch
>            Reporter: kenneth mcfarland
>
> There are existing calls to MoreExecutors.sameThreadExecutor(), this issue has been opened and closed before. A quick look shows CURATOR-370, CURATOR-200 etc.. 
> While these other issues address the same problem, the patches did not remove all calls to the method so I took the liberty of doing it while getting familiar with the codebase.
> Please accept my humble first PR for Curator. Because this is my first PR I will let you know fyi that I have signed the ICLA.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)