You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/06/01 06:02:01 UTC
[GitHub] [pinot] xiangfu0 commented on a diff in pull request #8810: Spark connector pom fixes
xiangfu0 commented on code in PR #8810:
URL: https://github.com/apache/pinot/pull/8810#discussion_r886345208
##########
pinot-connectors/pinot-spark-connector/pom.xml:
##########
@@ -199,19 +186,25 @@
</executions>
</plugin>
<plugin>
- <artifactId>maven-assembly-plugin</artifactId>
- <configuration>
- <descriptorRefs>
- <descriptorRef>jar-with-dependencies</descriptorRef>
- </descriptorRefs>
- </configuration>
+ <artifactId>maven-shade-plugin</artifactId>
<executions>
<execution>
- <id>assemble-all</id>
<phase>package</phase>
<goals>
- <goal>single</goal>
+ <goal>shade</goal>
</goals>
+ <configuration>
+ <relocations>
+ <relocation>
+ <pattern>com</pattern>
+ <shadedPattern>repackaged.com</shadedPattern>
Review Comment:
Consider follow the pattern here for presto, with your shadeBase parameter?
https://github.com/apache/pinot/blob/master/pinot-connectors/prestodb-pinot-dependencies/presto-pinot-driver/pom.xml#L39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org