You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "Prateek Maheshwari (JIRA)" <ji...@apache.org> on 2019/03/19 17:56:00 UTC
[jira] [Commented] (SAMZA-1766) FileUtil should use autoclosable
for the read/writeWithChecksum
[ https://issues.apache.org/jira/browse/SAMZA-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796352#comment-16796352 ]
Prateek Maheshwari commented on SAMZA-1766:
-------------------------------------------
[~xinyu] Is this still relevant?
> FileUtil should use autoclosable for the read/writeWithChecksum
> ---------------------------------------------------------------
>
> Key: SAMZA-1766
> URL: https://issues.apache.org/jira/browse/SAMZA-1766
> Project: Samza
> Issue Type: Bug
> Affects Versions: 0.15.0
> Reporter: Xinyu Liu
> Assignee: Xinyu Liu
> Priority: Major
>
> Multiple problems in the current impl:
> * close() of file stream and output stream without null check
> * we only need to close the objectstream once, it will close the file stream automatically
> We should use auto-closable in these helpers to avoid these side effects.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)