You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/26 20:24:23 UTC

[GitHub] [airflow] michalslowikowski00 opened a new pull request #10590: Removed bad characters from AWS operator

michalslowikowski00 opened a new pull request #10590:
URL: https://github.com/apache/airflow/pull/10590


   I found bad characters in AWS operator and I think they should be removed from code.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj merged pull request #10590: Removed bad characters from AWS operator

Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #10590:
URL: https://github.com/apache/airflow/pull/10590


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on a change in pull request #10590: Removed bad characters from AWS operator

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #10590:
URL: https://github.com/apache/airflow/pull/10590#discussion_r477610364



##########
File path: airflow/providers/amazon/aws/operators/athena.py
##########
@@ -127,7 +127,7 @@ def on_kill(self) -> None:
         Cancel the submitted athena query
         """
         if self.query_execution_id:
-            self.log.info('⚰️⚰️⚰️ Received a kill Signal. Time to Die')
+            self.log.info('Received a kill Signal. Time to Die')

Review comment:
       ```suggestion
               self.log.info('Received a kill Signal.')
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org