You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2017/08/30 22:27:09 UTC

[kudu-CR](branch-1.5.x) KUDU-1811: C++ client: use larger batches when fetching scan tokens

Dan Burkert has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7907

Change subject: KUDU-1811: C++ client: use larger batches when fetching scan tokens
......................................................................

KUDU-1811: C++ client: use larger batches when fetching scan tokens

Improve C++ client scan token generation performance
by fetching larger batches.

Change-Id: I79340dc9963944454770d82a2fbaba1b0c8a810e
Reviewed-on: http://gerrit.cloudera.org:8080/7748
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
(cherry picked from commit 738f345a19047ae07bbcc9704f2243f9e9c8bd40)
---
M src/kudu/client/meta_cache.cc
M src/kudu/client/meta_cache.h
M src/kudu/client/scan_token-internal.cc
3 files changed, 31 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/7907/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7907
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I79340dc9963944454770d82a2fbaba1b0c8a810e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jun He <ju...@gmail.com>

[kudu-CR](branch-1.5.x) KUDU-1811: C++ client: use larger batches when fetching scan tokens

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.

Change subject: KUDU-1811: C++ client: use larger batches when fetching scan tokens
......................................................................


KUDU-1811: C++ client: use larger batches when fetching scan tokens

Improve C++ client scan token generation performance
by fetching larger batches.

Change-Id: I79340dc9963944454770d82a2fbaba1b0c8a810e
Reviewed-on: http://gerrit.cloudera.org:8080/7748
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
(cherry picked from commit 738f345a19047ae07bbcc9704f2243f9e9c8bd40)
Reviewed-on: http://gerrit.cloudera.org:8080/7907
---
M src/kudu/client/meta_cache.cc
M src/kudu/client/meta_cache.h
M src/kudu/client/scan_token-internal.cc
3 files changed, 31 insertions(+), 14 deletions(-)

Approvals:
  Dan Burkert: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7907
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I79340dc9963944454770d82a2fbaba1b0c8a810e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jun He <ju...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR](branch-1.5.x) KUDU-1811: C++ client: use larger batches when fetching scan tokens

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: KUDU-1811: C++ client: use larger batches when fetching scan tokens
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7907
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I79340dc9963944454770d82a2fbaba1b0c8a810e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jun He <ju...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No