[jira] [Commented] (MAPREDUCE-5723) MR AM container log truncated on normal execution or empty if exception occurs

["Karthik Kambatla (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13879188#comment-13879188 ] 

Karthik Kambatla commented on MAPREDUCE-5723:
---------------------------------------------

+1. Looks good to me. Will commit this later today, if there are no objections. 

> MR AM container log truncated on normal execution or empty if exception occurs
> ------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5723
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5723
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: applicationmaster
>    Affects Versions: 2.2.0
>            Reporter: Mohammad Kamrul Islam
>            Assignee: Mohammad Kamrul Islam
>            Priority: Blocker
>         Attachments: MAPREDUCE-5723.1.patch, MAPREDUCE-5723.2.patch, MAPREDUCE-5723.3.patch, MAPREDUCE-5723.4.patch
>
>
> It occurs when the property "mapreduce.task.userlog.limit.kb" is set non-zero in mapped-site.xml.
> AM container syslog remains empty if any exception occurs. 
> Bug details:
> In MRAppMaster.java, the following code snippets show the bug.
> {code}
>     } catch (Throwable t) {
>        LOG.fatal("Error starting MRAppMaster", t);
>       System.exit(1);
>     }finally {
>        LogManager.shutdown();
>     }
> {code}
> In the catch block, we are exiting the JVM. So finally block (therefore LogManager.shutdown()) is never executed.
> Possible fix: 
> Make sure LogManager.shutdown() is executed in all cases.
>  



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)