You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/18 02:01:17 UTC

[GitHub] [pulsar] casuallc opened a new pull request #14364: Check if metadata write size is right

casuallc opened a new pull request #14364:
URL: https://github.com/apache/pulsar/pull/14364


   ### Motivation
   
   Should we check metadata real write size in `Command` to avoid some error like #13699 ?
   
   ### Modifications
   
   Add write size check.
   
   ### Verifying this change
   
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
   Check the box below and label this PR (if you have committer privilege).
   
   Need to update docs? 
     
   - [x] `no-need-doc`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] casuallc closed pull request #14364: Check if metadata write size is right

Posted by GitBox <gi...@apache.org>.
casuallc closed pull request #14364:
URL: https://github.com/apache/pulsar/pull/14364


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #14364: Check if metadata write size is right

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14364:
URL: https://github.com/apache/pulsar/pull/14364#issuecomment-1073415313


   The pr had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] casuallc edited a comment on pull request #14364: Check if metadata write size is right

Posted by GitBox <gi...@apache.org>.
casuallc edited a comment on pull request #14364:
URL: https://github.com/apache/pulsar/pull/14364#issuecomment-1075968110


   > This change make sense to me. But it's not obvious to me what side affect it brings if we throws Exception from here. Please help verify this.
   
   There is no affect to current version. 
   It would avoid these mistake on new feature. @Jason918 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] casuallc commented on pull request #14364: Check if metadata write size is right

Posted by GitBox <gi...@apache.org>.
casuallc commented on pull request #14364:
URL: https://github.com/apache/pulsar/pull/14364#issuecomment-1075964563


   > 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] casuallc removed a comment on pull request #14364: Check if metadata write size is right

Posted by GitBox <gi...@apache.org>.
casuallc removed a comment on pull request #14364:
URL: https://github.com/apache/pulsar/pull/14364#issuecomment-1075964563


   > 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] casuallc commented on pull request #14364: Check if metadata write size is right

Posted by GitBox <gi...@apache.org>.
casuallc commented on pull request #14364:
URL: https://github.com/apache/pulsar/pull/14364#issuecomment-1075968110


   > This change make sense to me. But it's not obvious to me what side affect it brings if we throws Exception from here. Please help verify this.
   
   There is no affect to current version. 
   It would avoid these mistake on new feature.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org