[GitHub] [camel-k] lburgazzoli commented on a change in pull request #765: Add timeout to maven operations

[GitBox <gi...@apache.org>]

lburgazzoli commented on a change in pull request #765: Add timeout to maven operations
URL: https://github.com/apache/camel-k/pull/765#discussion_r297054547
 
 

 ##########
 File path: pkg/controller/integrationplatform/initialize.go
 ##########
 @@ -132,12 +132,20 @@ func (action *initializeAction) Handle(ctx context.Context, ip *v1alpha1.Integra
 	if target.Spec.Build.PersistentVolumeClaim == "" {
 		target.Spec.Build.PersistentVolumeClaim = target.Name
 	}
+	if target.Spec.Build.Maven.Timeout.Duration == 0 {
+		target.Spec.Build.Maven.Timeout.Duration = 2 * time.Minute
 
 Review comment:
   We can increase it but should be lower than the build timeout imho, i.e. it could be set to 2/3 of the build time ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services