You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/23 04:36:38 UTC
[GitHub] [apisix-dashboard] idbeta opened a new pull request #1104: test: add frontend e2e test (smoke test for metrics page)
idbeta opened a new pull request #1104:
URL: https://github.com/apache/apisix-dashboard/pull/1104
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] E2E test
- [ ] New feature provided
- [ ] Improve performance
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1104: test: add frontend e2e test (smoke test for metrics page)
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1104:
URL: https://github.com/apache/apisix-dashboard/pull/1104#issuecomment-749930195
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1104?src=pr&el=h1) Report
> Merging [#1104](https://codecov.io/gh/apache/apisix-dashboard/pull/1104?src=pr&el=desc) (1137974) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/46bf1ef9cfe4f4c659752176424151bb4fc4952f?el=desc) (46bf1ef) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1104?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1104 +/- ##
=======================================
Coverage 41.06% 41.06%
=======================================
Files 28 28
Lines 1773 1773
=======================================
Hits 728 728
Misses 939 939
Partials 106 106
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1104?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1104?src=pr&el=footer). Last update [46bf1ef...1137974](https://codecov.io/gh/apache/apisix-dashboard/pull/1104?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1104: test: add frontend e2e test (smoke test for metrics page)
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #1104:
URL: https://github.com/apache/apisix-dashboard/pull/1104
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1104: test: add frontend e2e test (smoke test for metrics page)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1104:
URL: https://github.com/apache/apisix-dashboard/pull/1104#issuecomment-749930195
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1104?src=pr&el=h1) Report
> Merging [#1104](https://codecov.io/gh/apache/apisix-dashboard/pull/1104?src=pr&el=desc) (352083b) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/47e5345d09926bb8d360a666265dadbeeeec7274?el=desc) (47e5345) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1104?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1104 +/- ##
=======================================
Coverage 42.07% 42.07%
=======================================
Files 30 30
Lines 1856 1856
=======================================
Hits 781 781
Misses 965 965
Partials 110 110
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1104?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1104?src=pr&el=footer). Last update [47e5345...352083b](https://codecov.io/gh/apache/apisix-dashboard/pull/1104?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1104: test: add frontend e2e test (smoke test for metrics page)
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1104:
URL: https://github.com/apache/apisix-dashboard/pull/1104#discussion_r548817956
##########
File path: web/cypress/integration/metrics/metrics-smoketest.spec.js
##########
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+/* eslint-disable no-undef */
+
+context('metrics page smoke test', () => {
+ const domSelectors = {
+ pageContent: '.ant-pro-page-container'
+ };
+
+ beforeEach(() => {
+ // init login
+ cy.login();
+ })
+
+ it('visit metrics page', () => {
Review comment:
```suggestion
it('should visit metrics page', () => {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on a change in pull request #1104: test: add frontend e2e test (smoke test for metrics page)
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1104:
URL: https://github.com/apache/apisix-dashboard/pull/1104#discussion_r547854795
##########
File path: web/cypress/integration/metrics/metrics-smoketest.spec.js
##########
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+/* eslint-disable no-undef */
+
+context('ssl smoke test', () => {
Review comment:
?? bad title
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1104: test: add frontend e2e test (smoke test for metrics page)
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1104:
URL: https://github.com/apache/apisix-dashboard/pull/1104#discussion_r548817837
##########
File path: web/cypress/integration/metrics/metrics-smoketest.spec.js
##########
@@ -16,7 +16,7 @@
*/
/* eslint-disable no-undef */
-context('ssl smoke test', () => {
+context('metrics page smoke test', () => {
Review comment:
```suggestion
context('smoke test for Metrics module', () => {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #1104: test: add frontend e2e test (smoke test for metrics page)
Posted by GitBox <gi...@apache.org>.
idbeta commented on a change in pull request #1104:
URL: https://github.com/apache/apisix-dashboard/pull/1104#discussion_r548039021
##########
File path: web/cypress/integration/metrics/metrics-smoketest.spec.js
##########
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+/* eslint-disable no-undef */
+
+context('ssl smoke test', () => {
Review comment:
my fault, fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org