[GitHub] [nuttx] Ouss4 commented on a diff in pull request #7705: Don't download tarballs if a local git repo found

[GitBox <gi...@apache.org>]

Ouss4 commented on code in PR #7705:
URL: https://github.com/apache/nuttx/pull/7705#discussion_r1032949157


##########
libs/libxx/uClibc++.defs:
##########
@@ -20,22 +20,29 @@
 
 UCLIBCXX_VERSION=0.2.5
 
-$(TOPDIR)/include/uClibc++:
+# Download and unpack tarball if no git repo found
+ifeq ($(wildcard uClibc++/.git),)
+uClibc++:
 	curl -O -L https://git.busybox.net/uClibc++/snapshot/uClibc++-$(UCLIBCXX_VERSION).tar.bz2
 	$(Q) tar -xf uClibc++-$(UCLIBCXX_VERSION).tar.bz2
 	$(Q) $(DELFILE) uClibc++-$(UCLIBCXX_VERSION).tar.bz2
 	$(Q) mv uClibc++-$(UCLIBCXX_VERSION) uClibc++
-	$(Q) $(DIRLINK) $(CURDIR)/uClibc++/include $(TOPDIR)/include/uClibc++
-	$(Q) $(COPYFILE) $(CURDIR)/system_configuration.h $(TOPDIR)/include/uClibc++
 	$(Q) patch -p0 < 0001-uClibcxx-basic_definitions-fix-GCC-specific-definiti.patch
 	$(Q) patch -p0 < 0001-uclibxx-use-overload-constructor-of-filebuf-ostream.patch
+endif
+
+$(TOPDIR)/include/uClibc++: uClibc++
+	$(Q) $(DIRLINK) $(CURDIR)/uClibc++/include $(TOPDIR)/include/uClibc++
+	$(Q) $(COPYFILE) $(CURDIR)/system_configuration.h $(TOPDIR)/include/uClibc++
 
 context:: $(TOPDIR)/include/uClibc++
 
 distclean::
 	$(Q) $(DELFILE) $(TOPDIR)/include/uClibc++/system_configuration.h
 	$(Q) $(DIRUNLINK) $(TOPDIR)/include/uClibc++
+ifeq ($(wildcard uClibc++/.git),)

Review Comment:
   Since now it bypasses distclean, how does it get updated?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org