You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Tibor17 <gi...@git.apache.org> on 2014/12/30 23:55:33 UTC
[GitHub] maven pull request: Improved visibility of collections and variabl...
GitHub user Tibor17 opened a pull request:
https://github.com/apache/maven/pull/34
Improved visibility of collections and variables across multiple threads
Upon our discussion with Karl in
http://maven.40175.n5.nabble.com/Maven-Commit-3b671d07340b002e13775883d09e7f7e0d9a3c49-td5821660.html
i have improved MavenProject.java and surrounding code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Tibor17/maven-1 master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven/pull/34.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #34
----
commit 82ac1110d79fa4fd0428694bd694b094718c0a4f
Author: Tibor17 <ti...@lycos.com>
Date: 2014-12-30T22:34:27Z
Improved visibility of collections and variables across multiple threads
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: Improved visibility of collections and variabl...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the pull request:
https://github.com/apache/maven/pull/34#issuecomment-68561294
@jvanzyl
My ant build says BUILD SUCCESS.
I saw your TODO comments moreless related to immutable objects.
Currently the code is not ready for immutable objects and therefore it was simple toapply *concurrent* collections.
One way or another immutable objects:
+ improve code clarity
+ safe enough in multiple-threads env
+ every s/w is spaghetti code, but using immutable objects you simply put the barriers between parts of the code and then the contributors are willing to make bigger changes and spend their spare time
+ if this speeds up the development, you have chance to push the compettitors away
I am watching Maven Dev Hangout.
Will be glag if you talk about Maven stability.
The method `#getMetadataList()` returns unmodifiable collection, but It can be changed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: Improved visibility of collections and variabl...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the pull request:
https://github.com/apache/maven/pull/34#issuecomment-68440499
@jvanzyl
That's clear we must not break current users.
You kow my problem is, as always when i design any API, how much open the interfaces should be.
Here I tried to make final fields handling concurrent collections, but after breaking two tests I had to break idea with my code ideas. So it's hard to make perfect thread visibility, because here you have to use concurrent collections everywhere, break the shared collection instances and copy them everywhere, and run the tests million times by every single change with instance variable.
As I did in JUnit, the same regarding thread visibility, I had to struggle with another developer and it was really pain to talk with him due to he did not understand what i tried to explain what really happens in memory and so that theory is nice only on the paper.
You know, api with immutable model snapshots and modifiable services is much easier for making deterministic behavior.
`private Provider<MavenProject> provider;`
`private Service service;`
`MavenProject currentSnapshot = provider.get();`
`String pomProperty = currentSnapshot.getProperty("my-key");// only getters`
`service.setProperty("my-key", "new property value");`
The snapshot instance (umodifiable) is not the same as the internal one in project which is modifiable.
Wasn't you thinking about some kind of API emulator or adapter in Maven 4?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: Improved visibility of collections and variabl...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 closed the pull request at:
https://github.com/apache/maven/pull/34
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: Improved visibility of collections and variabl...
Posted by jvanzyl <gi...@git.apache.org>.
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/34#issuecomment-68700367
Apache is resource constrained so we have what we have. Please feel free to work with Stephen on the dev list to have something better setup. I'm open to improvement. Anyone who has contributed has not found running the ITs all that troublesome but that's the starting point of any further discussion. The patch can't even be considered if the ITs passing hasn't been validated.
If you don't want to run them to verify using[1] then I'll do it if someone doesn't get to it first. I'm in IRC if you want to discuss the patch.
[1]: http://takari.io/2014/06/01/contributing-to-maven-core.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: Improved visibility of collections and variabl...
Posted by hboutemy <gi...@git.apache.org>.
Github user hboutemy commented on the pull request:
https://github.com/apache/maven/pull/34#issuecomment-68425530
"The worst is that open implementation can change the status of objects by any plugin": yes, the API wasn't meant to be defensive when it was created, we could simply tell plugin developers "be collaborative, don't change anything"
nowadays, with parallel build, it's not about plugin developers, with a clear separation between core and plugin, but inside core: it's harder to define the limits of collaboration
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: Improved visibility of collections and variabl...
Posted by jvanzyl <gi...@git.apache.org>.
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/34#issuecomment-68426777
Much of the shitiness stems from leaving things in such a way that nothing was broken between Maven 2.x and 3.x. There are many weird interactions but the overriding goal for the transition was not to break anything. We did that but we're left with much that you look at and go "WTF? That's so gross", but such is life with mature systems that grow organically and in bursts. If we ever do get around to Maven 4.x there is a huge pile of cruft to be sheered off and if it breaks 10-15 integration tests so be it. You would would be shocked at how much code there is to preserve individual ITs passing but that's the way it is. The size of the core can be reduced by at least a 1/3 easily.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: Improved visibility of collections and variabl...
Posted by jvanzyl <gi...@git.apache.org>.
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/34#issuecomment-68680709
Tibor,
Empirically on the daily basis I work on a 900 module build using 8 threads with 1500+ developers and there aren't many concurrency issues. I'm not keen on incorporating this patch without a demonstration there is something wrong in the core. Igor and I took a look at creating a harness to test multithreaded builds but it's hard. But I think that needs to be done first to show that something is actually wrong. There may very well be but as I said empirically I haven't actually seen anything.
I would actually rather go the other way and create a patch that makes everything immutable and then watch a bunch of the ITs fail and then work toward making them work, or removing ITs that expect to mutate state. I think this will be far more informative and provide a path to cleaning up the core.
If I had witnessed all sorts of problems with concurrency issues I might be inclined to accept the patch but I don't think it particularly helps. Are you seeing lots of concurrency issues? If the code that clones the project per build thread is removed, yes, things don't work very well.
I'm happy to discuss more. Maybe pop into IRC, but as-is I'm not inclined to accept this. Also have you run the Maven ITs with your patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: Improved visibility of collections and variabl...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the pull request:
https://github.com/apache/maven/pull/34#issuecomment-68697988
Hi Jason,
the point of this patch is to force the devs to write `safe` code. Immediately as I have seen the code I recognized, same as Herve stated in my email, that the code is too open inside.
This means I wanted immutable objects in the core too, but ut is big change which needs the author(s) to improve the core.
I wasn't aware of ITs.
I would appreciate Jenkins build, like CloudBees or ASF machine, where I would be able to change the repo URL from master to my GitHub personal branch.
I don't kow how about you guys, but keeping the PC running and building the core with every bug appeared with my code change consumes the electricity I have to pay.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [GitHub] maven pull request: Improved visibility of collections and variabl...
Posted by Hervé BOUTEMY <he...@free.fr>.
yes, we should probably enhance the documentation: I had a look at it,
and it seems we have:
1. confusion bewteen "Guide to Developing Maven" [1] and "Guide to Building
Maven" [2],
2. confusion in these between Maven as Maven core only and any Maven
component, ie core or plugin or ...
I'm starting enhancements: feedback appreciated
Regards,
Hervé
[1] http://maven.apache.org/guides/development/guide-m2-development.html
[2] http://maven.apache.org/guides/development/guide-building-m2.html
Le vendredi 2 janvier 2015 22:27:59 Tibor17 a écrit :
> Github user Tibor17 commented on the pull request:
>
> https://github.com/apache/maven/pull/34#issuecomment-68568625
>
> The link should be in README.md.
> Look at README file @ JUnit and JavaHamcrest projects, where the most
> important is build status @ CloudBees and Travis
> https://github.com/junit-team/junit/blob/master/README.md
> https://github.com/hamcrest/JavaHamcrest
> Why such important projet does not have privilegies in CloudBees and
> free account?
>
> On Fri, Jan 2, 2015 at 10:09 PM, Jason van Zyl
> <no...@github.com>
> wrote:
> > Ant build? The ITs are in a separate repository. This may be helpful:
> >
> > http://takari.io/2014/06/01/contributing-to-maven-core.html
> >
> > There are are 700+ integration tests that need to pass for any change.
> >
> > â
> > Reply to this email directly or view it on GitHub
> > <https://github.com/apache/maven/pull/34#issuecomment-68562504>.
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [GitHub] maven pull request: Improved visibility of collections
and variabl...
Posted by Stephen Connolly <st...@gmail.com>.
On Friday, January 2, 2015, Tibor Digana <ti...@apache.org> wrote:
> Hey Stephen, I have discarded my CloudBees account because they wanted my
> bank card # to pay.
> The free accounts do not seem to be free any longer.
Oss accounts are still free, but not for 1-2 developer hobby projects...
Needs to be a serious oss project.
Surefire and maven would certainly qualify as does junit.
The real issue is ASF policy to relying on external resources...
That is where you risk a blocker. Get the PMC to request a free oss account
for maven and I am 99.999% certain we (cloudbees) will grant that
request... The bigger issue is whether the PMC is happy to make that
request of cloudbees, given some of the discussions that have recently been
taking place on lists that are not open to non-members with regards to
promoting (implicitly or accidentally) businesses by making visible links
outside of a clear promotions page (I.e. Ribbon banners, etc)
I wanted to have Surefire on CloudBees, but now won't be possible, and I
> really don't need top fast machines in Maven projects.
>
>
>
> --
> View this message in context:
> http://maven.40175.n5.nabble.com/GitHub-maven-pull-request-Improved-visibility-of-collections-and-variabl-tp5821775p5822205.html
> Sent from the Maven Developers mailing list archive at Nabble.com.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org <javascript:;>
> For additional commands, e-mail: dev-help@maven.apache.org <javascript:;>
>
>
--
Sent from my phone
Re: [GitHub] maven pull request: Improved visibility of collections
and variabl...
Posted by Tibor Digana <ti...@apache.org>.
Hey Stephen, I have discarded my CloudBees account because they wanted my
bank card # to pay.
The free accounts do not seem to be free any longer.
I wanted to have Surefire on CloudBees, but now won't be possible, and I
really don't need top fast machines in Maven projects.
--
View this message in context: http://maven.40175.n5.nabble.com/GitHub-maven-pull-request-Improved-visibility-of-collections-and-variabl-tp5821775p5822205.html
Sent from the Maven Developers mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [GitHub] maven pull request: Improved visibility of collections
and variabl...
Posted by Stephen Connolly <st...@gmail.com>.
On 2 January 2015 at 22:27, Tibor17 <gi...@git.apache.org> wrote:
> Github user Tibor17 commented on the pull request:
>
> https://github.com/apache/maven/pull/34#issuecomment-68568625
>
> The link should be in README.md.
> Look at README file @ JUnit and JavaHamcrest projects, where the most
> important is build status @ CloudBees and Travis
> https://github.com/junit-team/junit/blob/master/README.md
> https://github.com/hamcrest/JavaHamcrest
> Why such important projet does not have privilegies in CloudBees and
> free
> account?
>
I have recused myself from asking as I have a conflict (being a CloudBees
employee)... but I am not stopping anyone petitioning the PMC to make such
a request and if the PMC wanted such facilities I would suspect I could get
them granted for this project.
BTW this would need to be an action decided on by the PMC and driven by the
PMC.
-Stephen (PMC member and CloudBees employee)
>
> On Fri, Jan 2, 2015 at 10:09 PM, Jason van Zyl <
> notifications@github.com>
> wrote:
>
> > Ant build? The ITs are in a separate repository. This may be helpful:
> >
> > http://takari.io/2014/06/01/contributing-to-maven-core.html
> >
> > There are are 700+ integration tests that need to pass for any
> change.
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <https://github.com/apache/maven/pull/34#issuecomment-68562504>.
> >
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
[GitHub] maven pull request: Improved visibility of collections and variabl...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the pull request:
https://github.com/apache/maven/pull/34#issuecomment-68568625
The link should be in README.md.
Look at README file @ JUnit and JavaHamcrest projects, where the most
important is build status @ CloudBees and Travis
https://github.com/junit-team/junit/blob/master/README.md
https://github.com/hamcrest/JavaHamcrest
Why such important projet does not have privilegies in CloudBees and free
account?
On Fri, Jan 2, 2015 at 10:09 PM, Jason van Zyl <no...@github.com>
wrote:
> Ant build? The ITs are in a separate repository. This may be helpful:
>
> http://takari.io/2014/06/01/contributing-to-maven-core.html
>
> There are are 700+ integration tests that need to pass for any change.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/maven/pull/34#issuecomment-68562504>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: Improved visibility of collections and variabl...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the pull request:
https://github.com/apache/maven/pull/34#issuecomment-68410326
I wante to have final field o `MavenProject#dependencyArtifacts`, but in that case two tests would fail due to `DefaultProjectDependenciesResolver#process()` iterates over empty collection.
The solution for the first test would be to compare hashCodes of collections in `DependencyContext#isResolutionRequiredForCurrentProject()`.
Generally the domain model is excellent, but the implementation is totally open and really terrible.
The worst is that open implementation can change the status of objects by any plugin, it can set any collection and share the instance in whole Maven. The collections are not thread-safe. The methods hashCode/equals are not autogenerated and we have to compare collections by identity `==`.
The models should be immutable and plugins should inject services modifying the models with no setters. The setters should be in separate interface as a hint used by binternal builders as a hint over a constructor with thousands of params.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: Improved visibility of collections and variabl...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the pull request:
https://github.com/apache/maven/pull/34#issuecomment-68702414
Jason,
Don't worry about this patch, I'll close it - since I have private copy and the diff.
I will wait for you patch, and then I'll go through the diff and I will look for visibility issues again.
I reported one concurrency issue in JIRA against Maven two years ago. Since then I don't build Maven modules in parallel - personal attitude.
Usually the devs don't know that they have to think of Java concurrency at the point of architecture design. Usually they have no imagination of what happens with thread private copy of variables and when these copies reconcile with main memory via memory barriers and how this is related to Java Memory Model.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: Improved visibility of collections and variabl...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the pull request:
https://github.com/apache/maven/pull/34#issuecomment-68554366
@hboutemy
@jvanzyl
Any objections to push this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: Improved visibility of collections and variabl...
Posted by jvanzyl <gi...@git.apache.org>.
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/34#issuecomment-68701512
Does the patch apply for you? I just tried:
Applying: Improved visibility of collections and variables across multiple threads
error: patch failed: maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionResult.java:28
error: maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionResult.java: patch does not apply
Patch failed at 0001 Improved visibility of collections and variables across multiple threads
The copy of the patch that failed is found in:
/Users/jvanzyl/work/z-maven-with-pr-34/maven/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Applying 34.patch failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: Improved visibility of collections and variabl...
Posted by jvanzyl <gi...@git.apache.org>.
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/34#issuecomment-68555131
As a check did you run the ITs? There are a few collections that are expected to be mutable unfortunately. I haven't looked at the patch in detail to check but I can look early next week.
Ideally all configuration and projects should be immutable before the build starts. I made a significant change to the project building a few months ago which is a step in the right direction, and the next major refactor is entire construction of project with respect to plugin execution. Right now you can't know all the compile source roots without running a plugin which is admittedly bad, it should be declarative but it's not.
I was planning on talking about immutability and parallelism in the Maven Dev Hangout on January 15th if you're interested.
At any rate, if you know the ITs pass I'll take a look at the patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: Improved visibility of collections and variabl...
Posted by jvanzyl <gi...@git.apache.org>.
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/34#issuecomment-68562504
Ant build? The ITs are in a separate repository. This may be helpful:
http://takari.io/2014/06/01/contributing-to-maven-core.html
There are are 700+ integration tests that need to pass for any change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: Improved visibility of collections and variabl...
Posted by jvanzyl <gi...@git.apache.org>.
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/34#issuecomment-68705017
Sounds like a plan.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org