[GitHub] [superset] robdiciuccio commented on a change in pull request #14008: feat: Support feature flag overrides in ephemeral test envs

[GitBox <gi...@apache.org>]

robdiciuccio commented on a change in pull request #14008:
URL: https://github.com/apache/superset/pull/14008#discussion_r609966093



##########
File path: .github/workflows/ephemeral-env.yml
##########
@@ -28,6 +29,22 @@ jobs:
           const result = pattern.exec(context.payload.comment.body)
           return result === null ? 'noop' : result[1]
 
+    - name: Eval comment body for feature flags
+      uses: actions/github-script@v3
+      id: eval-feature-flags
+      with:
+        script: |
+          const pattern = /FEATURE_(\w+)=(\w+)/g;
+          let results = [];
+          [...context.payload.comment.body.matchAll(pattern)].forEach(match => {
+            const config = {
+              name: `SUPERSET_FEATURE_${match[1]}`,

Review comment:
       Namespacing and convention with other superset env vars.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org