You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/08 05:49:44 UTC

[GitHub] [arrow-datafusion] unvalley opened a new pull request, #3767: User Guide: Add `EXPLAIN` to SQL reference

unvalley opened a new pull request, #3767:
URL: https://github.com/apache/arrow-datafusion/pull/3767

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #3755 
   
    # Rationale for this change
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   # What changes are included in this PR?
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   Add explain section to SQL reference.
   
   # Are there any user-facing changes?
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] Dandandan commented on a diff in pull request #3767: User Guide: Add `EXPLAIN` to SQL reference

Posted by GitBox <gi...@apache.org>.
Dandandan commented on code in PR #3767:
URL: https://github.com/apache/arrow-datafusion/pull/3767#discussion_r990597329


##########
docs/source/user-guide/sql/explain.md:
##########
@@ -0,0 +1,69 @@
+<!---
+  Licensed to the Apache Software Foundation (ASF) under one
+  or more contributor license agreements.  See the NOTICE file
+  distributed with this work for additional information
+  regarding copyright ownership.  The ASF licenses this file
+  to you under the Apache License, Version 2.0 (the
+  "License"); you may not use this file except in compliance
+  with the License.  You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing,
+  software distributed under the License is distributed on an
+  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  KIND, either express or implied.  See the License for the
+  specific language governing permissions and limitations
+  under the License.
+-->
+
+# EXPLAIN
+
+The `EXPLAIN` command shows the logical and physical execution plan for the specified SQL statement.
+
+<pre>
+EXPLAIN [ANALYZE] [VERBOSE] statement
+</pre>
+
+## EXPLAIN
+
+Shows the execution plan of a statement.

Review Comment:
   Could we mention the info that `verbose` adds?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] ursabot commented on pull request #3767: User Guide: Add `EXPLAIN` to SQL reference

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3767:
URL: https://github.com/apache/arrow-datafusion/pull/3767#issuecomment-1273449058

   Benchmark runs are scheduled for baseline = a92119a0584322234a9005dc0897e94026464cad and contender = e395e30cd972ba9684020a4167c12d1424675698. e395e30cd972ba9684020a4167c12d1424675698 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/6607be2b013242e38c9b91f88bddae47...f898631a686c44d3ad68e8c649de01ba/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/b5aca6533b264642a640bb7e9eaf7b29...443483318e0042f0aabb0438fb6170c9/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a34fe860fff54460a12a421a2a4d43c3...ac7a17640a9a424493d6fee570f05f99/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8a7b9c6396314c7a81675353555d1f76...f72dbe5206714be68efc935add6c56f9/)
   Buildkite builds:
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] unvalley commented on a diff in pull request #3767: User Guide: Add `EXPLAIN` to SQL reference

Posted by GitBox <gi...@apache.org>.
unvalley commented on code in PR #3767:
URL: https://github.com/apache/arrow-datafusion/pull/3767#discussion_r990612405


##########
docs/source/user-guide/sql/explain.md:
##########
@@ -0,0 +1,69 @@
+<!---
+  Licensed to the Apache Software Foundation (ASF) under one
+  or more contributor license agreements.  See the NOTICE file
+  distributed with this work for additional information
+  regarding copyright ownership.  The ASF licenses this file
+  to you under the Apache License, Version 2.0 (the
+  "License"); you may not use this file except in compliance
+  with the License.  You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing,
+  software distributed under the License is distributed on an
+  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  KIND, either express or implied.  See the License for the
+  specific language governing permissions and limitations
+  under the License.
+-->
+
+# EXPLAIN
+
+The `EXPLAIN` command shows the logical and physical execution plan for the specified SQL statement.
+
+<pre>
+EXPLAIN [ANALYZE] [VERBOSE] statement
+</pre>
+
+## EXPLAIN
+
+Shows the execution plan of a statement.

Review Comment:
   I mentioned `VERBOSE` at [e9cf987](https://github.com/apache/arrow-datafusion/pull/3767/commits/e9cf98756625e5ec0516dbe6fab33de56c2895cb). 
   please take a look.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] andygrove merged pull request #3767: User Guide: Add `EXPLAIN` to SQL reference

Posted by GitBox <gi...@apache.org>.
andygrove merged PR #3767:
URL: https://github.com/apache/arrow-datafusion/pull/3767


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org