You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by el...@apache.org on 2018/12/07 22:28:54 UTC
[11/51] [abbrv] hbase git commit: HBASE-21377 Add debug log for
procedure stack id related operations
HBASE-21377 Add debug log for procedure stack id related operations
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/83dc38a1
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/83dc38a1
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/83dc38a1
Branch: refs/heads/HBASE-20952
Commit: 83dc38a1dffed76ea4d36f18409dd5bc86a3e19e
Parents: b8271c0
Author: Duo Zhang <zh...@apache.org>
Authored: Mon Nov 19 17:11:07 2018 +0800
Committer: Duo Zhang <zh...@apache.org>
Committed: Mon Nov 19 18:55:41 2018 +0800
----------------------------------------------------------------------
.../org/apache/hadoop/hbase/procedure2/RootProcedureState.java | 5 +++++
.../hadoop/hbase/procedure2/store/wal/WALProcedureTree.java | 3 +++
2 files changed, 8 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/83dc38a1/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/RootProcedureState.java
----------------------------------------------------------------------
diff --git a/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/RootProcedureState.java b/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/RootProcedureState.java
index 2fc0030..a7cdaab 100644
--- a/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/RootProcedureState.java
+++ b/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/RootProcedureState.java
@@ -24,6 +24,8 @@ import java.util.List;
import java.util.Set;
import org.apache.yetus.audience.InterfaceAudience;
import org.apache.yetus.audience.InterfaceStability;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
import org.apache.hadoop.hbase.shaded.protobuf.generated.ProcedureProtos.ProcedureState;
@@ -42,6 +44,8 @@ import org.apache.hadoop.hbase.shaded.protobuf.generated.ProcedureProtos.Procedu
@InterfaceStability.Evolving
class RootProcedureState<TEnvironment> {
+ private static final Logger LOG = LoggerFactory.getLogger(RootProcedureState.class);
+
private enum State {
RUNNING, // The Procedure is running or ready to run
FAILED, // The Procedure failed, waiting for the rollback executing
@@ -146,6 +150,7 @@ class RootProcedureState<TEnvironment> {
subprocStack = new ArrayList<>();
}
proc.addStackIndex(subprocStack.size());
+ LOG.debug("Add procedure {} as the {}th rollback step", proc, subprocStack.size());
subprocStack.add(proc);
}
http://git-wip-us.apache.org/repos/asf/hbase/blob/83dc38a1/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureTree.java
----------------------------------------------------------------------
diff --git a/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureTree.java b/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureTree.java
index c32bd7f..6e624b4 100644
--- a/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureTree.java
+++ b/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureTree.java
@@ -145,6 +145,9 @@ public final class WALProcedureTree {
private void collectStackId(Entry entry, Map<Integer, List<Entry>> stackId2Proc,
MutableInt maxStackId) {
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Procedure {} stack ids={}", entry, entry.proc.getStackIdList());
+ }
for (int i = 0, n = entry.proc.getStackIdCount(); i < n; i++) {
int stackId = entry.proc.getStackId(i);
if (stackId > maxStackId.intValue()) {