You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/10/27 20:39:13 UTC
[kudu-CR] [python] KUDU-1563. Add support for UPDATE IGNORE and DELETE IGNORE
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16667
Change subject: [python] KUDU-1563. Add support for UPDATE_IGNORE and DELETE_IGNORE
......................................................................
[python] KUDU-1563. Add support for UPDATE_IGNORE and DELETE_IGNORE
Implements Python support for the `UPDATE_IGNORE' and
`DELETE_IGNORE ` operations
Change-Id: Iad0fbd1db1edc140b88e1559ecf5d89bf6d9cbb9
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_client.py
4 files changed, 81 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/16667/1
--
To view, visit http://gerrit.cloudera.org:8080/16667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad0fbd1db1edc140b88e1559ecf5d89bf6d9cbb9
Gerrit-Change-Number: 16667
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [python] KUDU-1563. Add support for UPDATE IGNORE and DELETE IGNORE
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16667 )
Change subject: [python] KUDU-1563. Add support for UPDATE_IGNORE and DELETE_IGNORE
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16667/3/python/kudu/tests/test_client.py
File python/kudu/tests/test_client.py:
http://gerrit.cloudera.org:8080/#/c/16667/3/python/kudu/tests/test_client.py@221
PS3, Line 221: {'key': -998})
nit: can we also add an instantiation of new_delete_ignore() that supplies a tuple? Or is that not supported? It's a bit less obvious since deletes don't need to specify entire rows, and having a test would help serve as an example.
--
To view, visit http://gerrit.cloudera.org:8080/16667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad0fbd1db1edc140b88e1559ecf5d89bf6d9cbb9
Gerrit-Change-Number: 16667
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 28 Oct 2020 05:23:35 +0000
Gerrit-HasComments: Yes
[kudu-CR] [python] KUDU-1563. Add support for UPDATE IGNORE and DELETE IGNORE
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16667 )
Change subject: [python] KUDU-1563. Add support for UPDATE_IGNORE and DELETE_IGNORE
......................................................................
[python] KUDU-1563. Add support for UPDATE_IGNORE and DELETE_IGNORE
Implements Python support for the `UPDATE_IGNORE' and
`DELETE_IGNORE ` operations
Change-Id: Iad0fbd1db1edc140b88e1559ecf5d89bf6d9cbb9
Reviewed-on: http://gerrit.cloudera.org:8080/16667
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_client.py
4 files changed, 80 insertions(+), 2 deletions(-)
Approvals:
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iad0fbd1db1edc140b88e1559ecf5d89bf6d9cbb9
Gerrit-Change-Number: 16667
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [python] KUDU-1563. Add support for UPDATE IGNORE and DELETE IGNORE
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16667 )
Change subject: [python] KUDU-1563. Add support for UPDATE_IGNORE and DELETE_IGNORE
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16667/3/python/kudu/tests/test_client.py
File python/kudu/tests/test_client.py:
http://gerrit.cloudera.org:8080/#/c/16667/3/python/kudu/tests/test_client.py@221
PS3, Line 221: {'key': -998})
> nit: can we also add an instantiation of new_delete_ignore() that supplies
I tried this out a few ways and it looks like it's not supported in this case because the key is a single value.
--
To view, visit http://gerrit.cloudera.org:8080/16667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad0fbd1db1edc140b88e1559ecf5d89bf6d9cbb9
Gerrit-Change-Number: 16667
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 30 Oct 2020 14:08:12 +0000
Gerrit-HasComments: Yes
[kudu-CR] [python] KUDU-1563. Add support for UPDATE IGNORE and DELETE IGNORE
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16667 )
Change subject: [python] KUDU-1563. Add support for UPDATE_IGNORE and DELETE_IGNORE
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16667/3/python/kudu/tests/test_client.py
File python/kudu/tests/test_client.py:
http://gerrit.cloudera.org:8080/#/c/16667/3/python/kudu/tests/test_client.py@221
PS3, Line 221: {'key': -998})
> I tried this out a few ways and it looks like it's not supported in this ca
Womp. Thanks for checking
--
To view, visit http://gerrit.cloudera.org:8080/16667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad0fbd1db1edc140b88e1559ecf5d89bf6d9cbb9
Gerrit-Change-Number: 16667
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 30 Oct 2020 19:56:01 +0000
Gerrit-HasComments: Yes
[kudu-CR] [python] KUDU-1563. Add support for UPDATE IGNORE and DELETE IGNORE
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16667
to look at the new patch set (#2).
Change subject: [python] KUDU-1563. Add support for UPDATE_IGNORE and DELETE_IGNORE
......................................................................
[python] KUDU-1563. Add support for UPDATE_IGNORE and DELETE_IGNORE
Implements Python support for the `UPDATE_IGNORE' and
`DELETE_IGNORE ` operations
Change-Id: Iad0fbd1db1edc140b88e1559ecf5d89bf6d9cbb9
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_client.py
4 files changed, 80 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/16667/2
--
To view, visit http://gerrit.cloudera.org:8080/16667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iad0fbd1db1edc140b88e1559ecf5d89bf6d9cbb9
Gerrit-Change-Number: 16667
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)