[GitHub] [spark] peter-toth edited a comment on pull request #31818: [SPARK-34726][SQL][2.4] Fix collectToPython timeouts

[GitBox <gi...@apache.org>]

peter-toth edited a comment on pull request #31818:
URL: https://github.com/apache/spark/pull/31818#issuecomment-797669333


   > > This PR simply moves the socket server creation (2.) after running the listeners (3.). I think this approach has has a minor side effect that errors in socket server creation are not reported as onFailure events, but currently errors happening during opening the connection from Python side or data transfer from JVM to Python are also not reported as events so IMO this is not a big change.
   > 
   > Hmm, I'm not sure about this. It sounds like if any people rely `onFailure` events, there will be a breaking change for them. As 2.4.8 is the last release and is only maintenance release, above seems to be a behavior change so it is still risky to me.
   
   I think it is very rare that a `ServerSocket` throws an exception because it can't bind to some port on `127.0.0.1`. Other communication errors between Java and Python are also not reported as `onFailure` event currently...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org