You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/31 09:11:24 UTC
[GitHub] [pulsar] azhsmesos opened a new pull request, #16890: [feature][broker] offloader the data by topic compected
azhsmesos opened a new pull request, #16890:
URL: https://github.com/apache/pulsar/pull/16890
ospp 开源活动 任务
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on a diff in pull request #16890: [feature][broker] offloader the data by topic compacted
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on code in PR #16890:
URL: https://github.com/apache/pulsar/pull/16890#discussion_r934108392
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/NullLedgerOffloader.java:
##########
@@ -45,6 +47,11 @@ public CompletableFuture<Void> offload(ReadHandle ledger,
return promise;
}
+ @Override
+ public CompletableFuture<Void> offload(ByteBuf buf, long ledgerId, String topicName, UUID uid) {
+ return null;
Review Comment:
Should return `CompletableFuture.completedFuture(null);`
##########
managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/OffloadLedgerDeleteTest.java:
##########
@@ -110,6 +112,11 @@ public CompletableFuture<Void> offload(ReadHandle ledger,
return promise;
}
+ @Override
+ public CompletableFuture<Void> offload(ByteBuf buf, long ledgerId, String topicName, UUID uid) {
+ return null;
Review Comment:
CompletableFuture.completedFuture(null);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #16890: [feature][broker] offloader the data by topic compacted
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on PR #16890:
URL: https://github.com/apache/pulsar/pull/16890#issuecomment-1205252556
We need to start with a proposal for this one since it's a new feature introduced to Pulsar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #16890: [feature][broker] offloader the data by topic compacted
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16890:
URL: https://github.com/apache/pulsar/pull/16890#issuecomment-1200651551
@azhsmesos Please provide a correct documentation label for your PR.
Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on a diff in pull request #16890: [feature][broker] offloader the data by topic compacted
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on code in PR #16890:
URL: https://github.com/apache/pulsar/pull/16890#discussion_r934108264
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/LedgerOffloader.java:
##########
@@ -22,13 +22,16 @@
import java.util.Map;
import java.util.UUID;
import java.util.concurrent.CompletableFuture;
-import lombok.ToString;
+
Review Comment:
Remove empty line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] azhsmesos closed pull request #16890: [feature][broker] offloader the data by topic compacted
Posted by GitBox <gi...@apache.org>.
azhsmesos closed pull request #16890: [feature][broker] offloader the data by topic compacted
URL: https://github.com/apache/pulsar/pull/16890
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on a diff in pull request #16890: [feature][broker] offloader the data by topic compacted
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on code in PR #16890:
URL: https://github.com/apache/pulsar/pull/16890#discussion_r934108472
##########
managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/OffloadPrefixReadTest.java:
##########
@@ -231,6 +235,11 @@ public CompletableFuture<Void> offload(ReadHandle ledger,
return promise;
}
+ @Override
+ public CompletableFuture<Void> offload(ByteBuf buf, long ledgerId, String topicName, UUID uid) {
+ return null;
Review Comment:
CompletableFuture.completedFuture(null);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #16890: [feature][broker] offloader the data by topic compected
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16890:
URL: https://github.com/apache/pulsar/pull/16890#issuecomment-1200384267
@azhsmesos Please provide a correct documentation label for your PR.
Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org