You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Surya Hebbar (Code Review)" <ge...@cloudera.org> on 2023/05/08 19:40:34 UTC

[Impala-ASF-CR] IMPALA-11915: Support graphical plan and timeline exports in the WebUI

Surya Hebbar has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/19763 )

Change subject: IMPALA-11915: Support graphical plan and timeline exports in the WebUI
......................................................................

IMPALA-11915: Support graphical plan and timeline exports in the WebUI

This adds support for exporting the query plan and timeline
in SVG format for better scaling and text selection.

The plan export button embeds the CSS styling for
foreign objects and the rendered SVG viewport
into a blob, enclosed within HTML tags.

Memory resources consumed from the ObjectURLs
are cleared after each export, once previous
references are out of scope.

SVG viewer implementations for XML namespaces
to render foreign objects with CSS styling differs,
and are not always supported. To avoid such problems,
the plan export SVGs have been enclosed within a html wrapper.

Replacement of foreign objects in the graphical plan
with SVG elements such as <text> would allow
raw SVG exports, similar to timeline exports.

Testing: Manual testing with with TPC-H and TPS-DS queries

Change-Id: I1bd549318e220419ba3ee40be05f3671a9f1d8d9
---
M www/query_plan.tmpl
M www/query_timeline.tmpl
2 files changed, 128 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/19763/7
-- 
To view, visit http://gerrit.cloudera.org:8080/19763
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1bd549318e220419ba3ee40be05f3671a9f1d8d9
Gerrit-Change-Number: 19763
Gerrit-PatchSet: 7
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>