You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/29 23:44:56 UTC
[GitHub] [pulsar] leizhiyuan opened a new pull request #13564: feat: add lua wireshark for pulsar
leizhiyuan opened a new pull request #13564:
URL: https://github.com/apache/pulsar/pull/13564
Fixes #13517
### Motivation
add a Lua plugin
### Modifications
*Describe the modifications you've done.*
### Verifying this change
maybe need a code review
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
- [ ] `doc-required`
(If you need help on updating docs, create a doc issue)
- [ ] `no-need-doc`
(Please explain why)
- [ ] `doc`
(If this PR contains doc changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] leizhiyuan edited a comment on pull request #13564: feat: add lua wireshark for pulsar
Posted by GitBox <gi...@apache.org>.
leizhiyuan edited a comment on pull request #13564:
URL: https://github.com/apache/pulsar/pull/13564#issuecomment-1005331239
> > Missing header in: /Users/runner/work/pulsar/pulsar/wireshark/pulsar.lua
>
> The license is still missed. I think LUA is not commented by `/* ... */`. See https://en.wikibooks.org/wiki/Lua_Programming/comment. Before pushing your commit, you can run `mvn -B clean install -DskipTests` in your local env to ensure the license has been added correctly.
it seems lua comment can not be recognized, could I ignore .lua in config?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] leizhiyuan commented on pull request #13564: feat: add lua wireshark for pulsar
Posted by GitBox <gi...@apache.org>.
leizhiyuan commented on pull request #13564:
URL: https://github.com/apache/pulsar/pull/13564#issuecomment-1005331831
see https://mycila.carbou.me/license-maven-plugin/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #13564: feat: add lua wireshark for pulsar
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13564:
URL: https://github.com/apache/pulsar/pull/13564#issuecomment-1002815839
@leizhiyuan:Thanks for providing doc info!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower merged pull request #13564: feat: add lua wireshark for pulsar
Posted by GitBox <gi...@apache.org>.
BewareMyPower merged pull request #13564:
URL: https://github.com/apache/pulsar/pull/13564
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #13564: feat: add lua wireshark for pulsar
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #13564:
URL: https://github.com/apache/pulsar/pull/13564#discussion_r776548097
##########
File path: wireshark/README.md
##########
@@ -0,0 +1,16 @@
+# how to use
+
+## prepare PulsarApi.proto file
+you need to put PulsarApi.proto to a separate path, open your wireshark,go to
+Edit->Preferences->Protocols->ProtoBuf->Protobuf search paths，add the path of PulsarApi.proto
+
+## add pulsar.lua to plugins
+
+open wireshark, go to 'About Wireshark', click 'Folders', then click 'Personal Lua Plugins'
+go to the plugin path, add put pulsar.lua to this path.
+
+## start to use
+
+this plugin will register a pulsar protocol automatically in 6650, you can use it to decode pulsar message now.
Review comment:
@Demogorgon314 can you review the doc from the tech perspective? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #13564: feat: add lua wireshark for pulsar
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #13564:
URL: https://github.com/apache/pulsar/pull/13564#issuecomment-1015139510
Hi @BewareMyPower does the author resolve your concern?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #13564: feat: add lua wireshark for pulsar
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #13564:
URL: https://github.com/apache/pulsar/pull/13564#issuecomment-1005315489
> Missing header in: /Users/runner/work/pulsar/pulsar/wireshark/pulsar.lua
The license is still missed. I think LUA is not commented by `/* ... */`. See https://en.wikibooks.org/wiki/Lua_Programming/comment. Before pushing your commit, you can run `mvn -B clean install -DskipTests` in your local env to ensure the license has been added correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #13564: feat: add lua wireshark for pulsar
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13564:
URL: https://github.com/apache/pulsar/pull/13564#issuecomment-1002815422
@leizhiyuan:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #13564: feat: add lua wireshark for pulsar
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #13564:
URL: https://github.com/apache/pulsar/pull/13564#discussion_r776900595
##########
File path: wireshark/README.md
##########
@@ -0,0 +1,16 @@
+# how to use
+
+## prepare PulsarApi.proto file
Review comment:
```suggestion
## Step 1: prepare PulsarApi.proto file
```
##########
File path: wireshark/README.md
##########
@@ -0,0 +1,16 @@
+# how to use
+
+## prepare PulsarApi.proto file
+you need to put PulsarApi.proto to a separate path, open your wireshark,go to
+Edit->Preferences->Protocols->ProtoBuf->Protobuf search paths，add the path of PulsarApi.proto
+
+## add pulsar.lua to plugins
+
+open wireshark, go to 'About Wireshark', click 'Folders', then click 'Personal Lua Plugins'
+go to the plugin path, add put pulsar.lua to this path.
+
+## start to use
Review comment:
```suggestion
## Step 3: start to use
```
##########
File path: wireshark/README.md
##########
@@ -0,0 +1,16 @@
+# how to use
+
+## prepare PulsarApi.proto file
+you need to put PulsarApi.proto to a separate path, open your wireshark,go to
+Edit->Preferences->Protocols->ProtoBuf->Protobuf search paths，add the path of PulsarApi.proto
Review comment:
```suggestion
You need to put PulsarApi.proto to a separate path.
1. Open your Wireshark.
2. Go to **Edit > Preferences > Protocols > ProtoBuf > Protobuf**, and then search paths.
3. Add the path of PulsarApi.proto.
```
do you mean this?
##########
File path: wireshark/README.md
##########
@@ -0,0 +1,16 @@
+# how to use
+
+## prepare PulsarApi.proto file
+you need to put PulsarApi.proto to a separate path, open your wireshark,go to
+Edit->Preferences->Protocols->ProtoBuf->Protobuf search paths，add the path of PulsarApi.proto
+
+## add pulsar.lua to plugins
+
+open wireshark, go to 'About Wireshark', click 'Folders', then click 'Personal Lua Plugins'
+go to the plugin path, add put pulsar.lua to this path.
Review comment:
```suggestion
1. Open Wireshark.
2. Go to **About Wireshark > Folders > Personal Lua Plugins > Plugin Path**.
3. Add pulsar.lua to this path.
```
do you mean this?
##########
File path: wireshark/README.md
##########
@@ -0,0 +1,16 @@
+# how to use
+
+## prepare PulsarApi.proto file
+you need to put PulsarApi.proto to a separate path, open your wireshark,go to
+Edit->Preferences->Protocols->ProtoBuf->Protobuf search paths，add the path of PulsarApi.proto
+
+## add pulsar.lua to plugins
Review comment:
```suggestion
## Step 2: add pulsar.lua to plugins
```
##########
File path: wireshark/README.md
##########
@@ -0,0 +1,16 @@
+# how to use
Review comment:
```suggestion
# How to use
```
##########
File path: wireshark/README.md
##########
@@ -0,0 +1,16 @@
+# how to use
+
+## prepare PulsarApi.proto file
+you need to put PulsarApi.proto to a separate path, open your wireshark,go to
+Edit->Preferences->Protocols->ProtoBuf->Protobuf search paths，add the path of PulsarApi.proto
+
+## add pulsar.lua to plugins
+
+open wireshark, go to 'About Wireshark', click 'Folders', then click 'Personal Lua Plugins'
+go to the plugin path, add put pulsar.lua to this path.
+
+## start to use
+
+this plugin will register a pulsar protocol automatically in 6650, you can use it to decode pulsar message now.
Review comment:
```suggestion
This plugin registers a Pulsar protocol automatically in 6650. You can use it to decode Pulsar messages now.
```
English syntax details: https://docs.google.com/document/d/1lc5j4RtuLIzlEYCBo97AC8-U_3Erzs_lxpkDuseU0n4/edit#bookmark=id.e8uqh1awkcnp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #13564: feat: add lua wireshark for pulsar
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #13564:
URL: https://github.com/apache/pulsar/pull/13564#issuecomment-1004953418
I think you should add the license in the LUA script.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] leizhiyuan removed a comment on pull request #13564: feat: add lua wireshark for pulsar
Posted by GitBox <gi...@apache.org>.
leizhiyuan removed a comment on pull request #13564:
URL: https://github.com/apache/pulsar/pull/13564#issuecomment-1005331239
> > Missing header in: /Users/runner/work/pulsar/pulsar/wireshark/pulsar.lua
>
> The license is still missed. I think LUA is not commented by `/* ... */`. See https://en.wikibooks.org/wiki/Lua_Programming/comment. Before pushing your commit, you can run `mvn -B clean install -DskipTests` in your local env to ensure the license has been added correctly.
it seems lua comment can not be recognized, could I ignore .lua in config?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] leizhiyuan commented on pull request #13564: feat: add lua wireshark for pulsar
Posted by GitBox <gi...@apache.org>.
leizhiyuan commented on pull request #13564:
URL: https://github.com/apache/pulsar/pull/13564#issuecomment-1005331239
> > Missing header in: /Users/runner/work/pulsar/pulsar/wireshark/pulsar.lua
>
> The license is still missed. I think LUA is not commented by `/* ... */`. See https://en.wikibooks.org/wiki/Lua_Programming/comment. Before pushing your commit, you can run `mvn -B clean install -DskipTests` in your local env to ensure the license has been added correctly.
it seems lua comment can not be recognized, could I ignore .lua in config?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org