You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/06/09 15:50:37 UTC
[GitHub] [geode] DonalEvans opened a new pull request #5223: Revert "GEODE-7458: Adding option in gfsh command "start gateway send…
DonalEvans opened a new pull request #5223:
URL: https://github.com/apache/geode/pull/5223
…er" to control clearing of existing queues (#4387)"
This reverts commit 19d5f7866848a31e49a0c64dc1192e98c1d29b4d.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] DonalEvans commented on pull request #5223: Revert "GEODE-7458: Adding option in gfsh command "start gateway send…
Posted by GitBox <gi...@apache.org>.
DonalEvans commented on pull request #5223:
URL: https://github.com/apache/geode/pull/5223#issuecomment-641366892
The reason for this revert is due to internal tests failing with non-empty serial gateway sender queues. While shutting down gateway senders, events are marked as possible duplicates and the queues are not cleared of these events:
`[info 2020/05/27 00:02:35.859 PDT <vm_19_thr_80_peer_4_4_host1_19147> tid=0x705] Stopped SerialGatewaySender{id=sender_ds_4_to_ds_3,remoteDsId=3,isRunning =false,isPrimary =true}
[info 2020/05/27 00:02:37.382 PDT <vm_17_thr_69_peer_4_2_host1_19135> tid=0x8df] Stopped SerialGatewaySender{id=sender_ds_4_to_ds_1,remoteDsId=1,isRunning =false,isPrimary =true}
[info 2020/05/27 00:02:37.432 PDT <Event Processor for GatewaySender_sender_ds_4_to_ds_1.1> tid=0x5f] SerialGatewaySender{id=sender_ds_4_to_ds_1,remoteDsId=1,isRunning =true,isPrimary =true} : Marking 5 events as possible duplicates
[info 2020/05/27 00:02:37.446 PDT <Event Processor for GatewaySender_sender_ds_4_to_ds_1.0> tid=0x5c] SerialGatewaySender{id=sender_ds_4_to_ds_1,remoteDsId=1,isRunning =true,isPrimary =true} : Marking 11 events as possible duplicates
[info 2020/05/27 00:02:37.623 PDT <vm_19_thr_80_peer_4_4_host1_19147> tid=0x705] Stopped SerialGatewaySender{id=sender_ds_4_to_ds_2,remoteDsId=2,isRunning =false,isPrimary =true}
[info 2020/05/27 00:02:39.656 PDT <vm_19_thr_80_peer_4_4_host1_19147> tid=0x705] Stopped SerialGatewaySender{id=sender_ds_4_to_ds_1,remoteDsId=1,isRunning =false,isPrimary =true}`
Following the above log output, we see 16 events in in the `unprocessedEventMapSize` stat for the gateway sender in question (each sender has two dispatcher threads in this case, so 5 + 11 = 16).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] mivanac commented on pull request #5223: Revert "GEODE-7458: Adding option in gfsh command "start gateway send…
Posted by GitBox <gi...@apache.org>.
mivanac commented on pull request #5223:
URL: https://github.com/apache/geode/pull/5223#issuecomment-641398969
Hi,
this is not good practice, that due to your internal test, which are not part of the community,
commit is reverted.
I think that you need first, to push problematic test case to community, then we can revert commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] DonalEvans commented on pull request #5223: Revert "GEODE-7458: Adding option in gfsh command "start gateway send…
Posted by GitBox <gi...@apache.org>.
DonalEvans commented on pull request #5223:
URL: https://github.com/apache/geode/pull/5223#issuecomment-641496854
> Hi,
>
> this is not good practice, that due to your internal test, which are not part of the community,
> commit is reverted.
> I think that you need first, to push problematic test case to community, then we can revert commit.
You're correct, this is not best practice. I will close this PR until we are able to provide you with a test to reproduce the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] DonalEvans edited a comment on pull request #5223: Revert "GEODE-7458: Adding option in gfsh command "start gateway send…
Posted by GitBox <gi...@apache.org>.
DonalEvans edited a comment on pull request #5223:
URL: https://github.com/apache/geode/pull/5223#issuecomment-641366892
The reason for this revert is due to internal tests failing with non-empty serial gateway sender queues. While shutting down gateway senders, events are marked as possible duplicates and the queues are not cleared of these events:
`[info 2020/05/27 00:02:35.859 PDT <vm_19_thr_80_peer_4_4_host1_19147> tid=0x705] Stopped SerialGatewaySender{id=sender_ds_4_to_ds_3,remoteDsId=3,isRunning =false,isPrimary =true}`
`[info 2020/05/27 00:02:37.382 PDT <vm_17_thr_69_peer_4_2_host1_19135> tid=0x8df] Stopped SerialGatewaySender{id=sender_ds_4_to_ds_1,remoteDsId=1,isRunning =false,isPrimary =true}`
`[info 2020/05/27 00:02:37.432 PDT <Event Processor for GatewaySender_sender_ds_4_to_ds_1.1> tid=0x5f] SerialGatewaySender{id=sender_ds_4_to_ds_1,remoteDsId=1,isRunning =true,isPrimary =true} : Marking 5 events as possible duplicates`
`[info 2020/05/27 00:02:37.446 PDT <Event Processor for GatewaySender_sender_ds_4_to_ds_1.0> tid=0x5c] SerialGatewaySender{id=sender_ds_4_to_ds_1,remoteDsId=1,isRunning =true,isPrimary =true} : Marking 11 events as possible duplicates`
`[info 2020/05/27 00:02:37.623 PDT <vm_19_thr_80_peer_4_4_host1_19147> tid=0x705] Stopped SerialGatewaySender{id=sender_ds_4_to_ds_2,remoteDsId=2,isRunning =false,isPrimary =true}`
`[info 2020/05/27 00:02:39.656 PDT <vm_19_thr_80_peer_4_4_host1_19147> tid=0x705] Stopped SerialGatewaySender{id=sender_ds_4_to_ds_1,remoteDsId=1,isRunning =false,isPrimary =true}`
Following the above log output, we see 16 events in in the `unprocessedEventMapSize` stat for the gateway sender in question (each sender has two dispatcher threads in this case, so 5 + 11 = 16).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] DonalEvans closed pull request #5223: Revert "GEODE-7458: Adding option in gfsh command "start gateway send…
Posted by GitBox <gi...@apache.org>.
DonalEvans closed pull request #5223:
URL: https://github.com/apache/geode/pull/5223
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org