You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Juergen Donnerstag (JIRA)" <ji...@apache.org> on 2008/12/29 17:32:44 UTC

[jira] Commented: (WICKET-1975) Allow custom form components to be more easily created by removing final from certain methods.

    [ https://issues.apache.org/jira/browse/WICKET-1975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659583#action_12659583 ] 

Juergen Donnerstag commented on WICKET-1975:
--------------------------------------------

Could you please explain your usecase in more detail. "It is similar ..." is a little bit too vague. Thanks.

> Allow custom form components to be more easily created by removing final from certain methods.
> ----------------------------------------------------------------------------------------------
>
>                 Key: WICKET-1975
>                 URL: https://issues.apache.org/jira/browse/WICKET-1975
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Larry Zappaterrini
>            Priority: Minor
>
> I was perusing Wicket's Javadocs and I came across a link to an old thread: http://www.nabble.com/Why-add%28IBehavior%29-is-final--td7248198.html#a7248198
> The issue in that message thread was resolved by WICKET-94 with the final modifier being removed from from Component#add(IBehavior). I am currently trying to do something similar to the original author of the thread and I believe the same concession should be extended to FormComponent#add(IValidator) and FormComponent#setFieldType(Class<?>) due to similar arguments. In fact, might it make sense to look though the public final methods of FormComponent and only make final those that are absolutely necessary from an encapsulation standpoint?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.