You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Andrew Zhang (JIRA)" <ji...@apache.org> on 2006/07/24 11:47:16 UTC
[jira] Created: (HARMONY-961)
[classlib][nio]java.nio.channels.spi.SelectorProvider.inheritedChannel must
be implemented
[classlib][nio]java.nio.channels.spi.SelectorProvider.inheritedChannel must be implemented
------------------------------------------------------------------------------------------
Key: HARMONY-961
URL: http://issues.apache.org/jira/browse/HARMONY-961
Project: Harmony
Issue Type: Improvement
Components: Classlib
Reporter: Andrew Zhang
Hi,
java.nio.channels.spi.SelectorProvider.inheritedChannel() must be implemented.
As discussed on mailing-list, it must be implement in Linux. No evidence can be found that it can be implemented on windows.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-961)
[classlib][nio]java.nio.channels.spi.SelectorProvider.inheritedChannel must
be implemented
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-961?page=comments#action_12423826 ]
Paulex Yang commented on HARMONY-961:
-------------------------------------
Andrew, new patch applied at revision r426042, please verify the problem is fully resolved as you expected, thank you for the enhancement.
> [classlib][nio]java.nio.channels.spi.SelectorProvider.inheritedChannel must be implemented
> ------------------------------------------------------------------------------------------
>
> Key: HARMONY-961
> URL: http://issues.apache.org/jira/browse/HARMONY-961
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Attachments: luni.diff, luni.native.diff, nio.diff, nio_2.diff
>
>
> Hi,
> java.nio.channels.spi.SelectorProvider.inheritedChannel() must be implemented.
> As discussed on mailing-list, it must be implement in Linux. No evidence can be found that it can be implemented on windows.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-961)
[classlib][nio]java.nio.channels.spi.SelectorProvider.inheritedChannel must
be implemented
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-961?page=all ]
Andrew Zhang updated HARMONY-961:
---------------------------------
Attachment: luni.diff
luni.native.diff
nio.diff
Hello,
Would you please try my patch?
Thanks!
Best regards,
Andrew
> [classlib][nio]java.nio.channels.spi.SelectorProvider.inheritedChannel must be implemented
> ------------------------------------------------------------------------------------------
>
> Key: HARMONY-961
> URL: http://issues.apache.org/jira/browse/HARMONY-961
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Attachments: luni.diff, luni.native.diff, nio.diff
>
>
> Hi,
> java.nio.channels.spi.SelectorProvider.inheritedChannel() must be implemented.
> As discussed on mailing-list, it must be implement in Linux. No evidence can be found that it can be implemented on windows.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-961)
[classlib][nio]java.nio.channels.spi.SelectorProvider.inheritedChannel must
be implemented
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-961?page=all ]
Paulex Yang resolved HARMONY-961.
---------------------------------
Resolution: Fixed
Andrew, patch applied at revision r426019, thanks a lot for this enhancement, please verify the problem is resovled as you expected.
Please correct me if I'm wrong. Though I think this patch is workable (that's why I applied it), but I see some chance to refactor some codes from native to Java, especially after the FileDescriptor with underlying hysocket handler has been created, the native codes are mostly refactor and construct Java objects. IIRC it is an agreement of Harmony development to prefer Java codes, so would you please look more inside about the codes? Thank you.
> [classlib][nio]java.nio.channels.spi.SelectorProvider.inheritedChannel must be implemented
> ------------------------------------------------------------------------------------------
>
> Key: HARMONY-961
> URL: http://issues.apache.org/jira/browse/HARMONY-961
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Attachments: luni.diff, luni.native.diff, nio.diff
>
>
> Hi,
> java.nio.channels.spi.SelectorProvider.inheritedChannel() must be implemented.
> As discussed on mailing-list, it must be implement in Linux. No evidence can be found that it can be implemented on windows.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-961)
[classlib][nio]java.nio.channels.spi.SelectorProvider.inheritedChannel must
be implemented
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-961?page=all ]
Andrew Zhang updated HARMONY-961:
---------------------------------
Attachment: nio_2.diff
Hello Paulex,
Sorry for my carelessness. I forgot to update the code of SelectorProvider.inheritedChannel().
Would you please try nio_2.diff?
Thank you very much!
Best regards,
Andrew
> [classlib][nio]java.nio.channels.spi.SelectorProvider.inheritedChannel must be implemented
> ------------------------------------------------------------------------------------------
>
> Key: HARMONY-961
> URL: http://issues.apache.org/jira/browse/HARMONY-961
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Attachments: luni.diff, luni.native.diff, nio.diff, nio_2.diff
>
>
> Hi,
> java.nio.channels.spi.SelectorProvider.inheritedChannel() must be implemented.
> As discussed on mailing-list, it must be implement in Linux. No evidence can be found that it can be implemented on windows.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-961)
[classlib][nio]java.nio.channels.spi.SelectorProvider.inheritedChannel must
be implemented
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-961?page=comments#action_12423986 ]
Andrew Zhang commented on HARMONY-961:
--------------------------------------
Hi Paulex,
The fix looks good. Many thanks!
Best regards,
Andrew
> [classlib][nio]java.nio.channels.spi.SelectorProvider.inheritedChannel must be implemented
> ------------------------------------------------------------------------------------------
>
> Key: HARMONY-961
> URL: http://issues.apache.org/jira/browse/HARMONY-961
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Attachments: luni.diff, luni.native.diff, nio.diff, nio_2.diff
>
>
> Hi,
> java.nio.channels.spi.SelectorProvider.inheritedChannel() must be implemented.
> As discussed on mailing-list, it must be implement in Linux. No evidence can be found that it can be implemented on windows.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-961)
[classlib][nio]java.nio.channels.spi.SelectorProvider.inheritedChannel must
be implemented
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-961?page=comments#action_12423813 ]
Andrew Zhang commented on HARMONY-961:
--------------------------------------
Hi Paulex,
Thank you very much for your comments.
I'll consider your suggestions carefully, and if I decide to refactor the code, I'll raise a seperate JIRA.
Thanks!
Best regards,
Andrew
> [classlib][nio]java.nio.channels.spi.SelectorProvider.inheritedChannel must be implemented
> ------------------------------------------------------------------------------------------
>
> Key: HARMONY-961
> URL: http://issues.apache.org/jira/browse/HARMONY-961
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Attachments: luni.diff, luni.native.diff, nio.diff, nio_2.diff
>
>
> Hi,
> java.nio.channels.spi.SelectorProvider.inheritedChannel() must be implemented.
> As discussed on mailing-list, it must be implement in Linux. No evidence can be found that it can be implemented on windows.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-961)
[classlib][nio]java.nio.channels.spi.SelectorProvider.inheritedChannel must
be implemented
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-961?page=comments#action_12423805 ]
Paulex Yang commented on HARMONY-961:
-------------------------------------
- especially after the FileDescriptor with underlying hysocket handler has been created, the native codes are mostly *refactor*(Sorry, I meant reflection here) and construct Java objects.
> [classlib][nio]java.nio.channels.spi.SelectorProvider.inheritedChannel must be implemented
> ------------------------------------------------------------------------------------------
>
> Key: HARMONY-961
> URL: http://issues.apache.org/jira/browse/HARMONY-961
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Attachments: luni.diff, luni.native.diff, nio.diff
>
>
> Hi,
> java.nio.channels.spi.SelectorProvider.inheritedChannel() must be implemented.
> As discussed on mailing-list, it must be implement in Linux. No evidence can be found that it can be implemented on windows.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-961)
[classlib][nio]java.nio.channels.spi.SelectorProvider.inheritedChannel must
be implemented
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-961?page=all ]
Paulex Yang reassigned HARMONY-961:
-----------------------------------
Assignee: Paulex Yang
> [classlib][nio]java.nio.channels.spi.SelectorProvider.inheritedChannel must be implemented
> ------------------------------------------------------------------------------------------
>
> Key: HARMONY-961
> URL: http://issues.apache.org/jira/browse/HARMONY-961
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Attachments: luni.diff, luni.native.diff, nio.diff
>
>
> Hi,
> java.nio.channels.spi.SelectorProvider.inheritedChannel() must be implemented.
> As discussed on mailing-list, it must be implement in Linux. No evidence can be found that it can be implemented on windows.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-961)
[classlib][nio]java.nio.channels.spi.SelectorProvider.inheritedChannel must
be implemented
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-961?page=all ]
Paulex Yang closed HARMONY-961.
-------------------------------
Verified by Andrew.
> [classlib][nio]java.nio.channels.spi.SelectorProvider.inheritedChannel must be implemented
> ------------------------------------------------------------------------------------------
>
> Key: HARMONY-961
> URL: http://issues.apache.org/jira/browse/HARMONY-961
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Attachments: luni.diff, luni.native.diff, nio.diff, nio_2.diff
>
>
> Hi,
> java.nio.channels.spi.SelectorProvider.inheritedChannel() must be implemented.
> As discussed on mailing-list, it must be implement in Linux. No evidence can be found that it can be implemented on windows.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira