You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by kalyan kumar kalvagadda <kk...@cloudera.com> on 2017/02/15 17:01:36 UTC
Review Request 56709: SENTRY-1569 Added changes to sql scripts persist
Perm/Path change Adding missing files
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56709/
-----------------------------------------------------------
Review request for sentry, Alexander Kolbasov, Hao Hao, Mat Crocker, Vamsee Yarlagadda, and Vadim Spector.
Repository: sentry
Description
-------
SENTRY-1569 Added changes to sql scripts persist Perm/Path change Adding missing files
Diffs
-----
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 0606116a1d31c400fb6dadcd80a2284007117ab2
sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql be9a33e6b0904b7c8ec522906d967081631108d6
sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1c8848c30d0432ebdbd18b73a1d27c61d2b7bcae
sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql fc7b53f41e97fad5e5baeb254b686a0e8cc5b003
sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql ce807a5aee9d04e119dde32784cbe958bf933feb
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 36573771d84ff9c0d7683f20d7df75ae6be656b7
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql 5d88887c62e407dc1fdc0438ce11572a1419ab6d
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql b6108e72c97f9a7ed2afbe9f30f42c412d11f74b
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql d5b7d6eaff461931897a41ba7d38729cbd38b47d
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql f0c8cfb4174189fe270597c2525579b534778831
Diff: https://reviews.apache.org/r/56709/diff/
Testing
-------
Tested the scrips against db2, postgres, musql, oracle and derby databases.
Also ran SchemaToll test for deby.
Thanks,
kalyan kumar kalvagadda
Re: Review Request 56709: SENTRY-1569 Added changes to sql scripts
persist Perm/Path change Adding missing files
Posted by Hao Hao <ha...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56709/#review167953
-----------------------------------------------------------
Ship it!
Ship It!
- Hao Hao
On March 2, 2017, 12:15 a.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56709/
> -----------------------------------------------------------
>
> (Updated March 2, 2017, 12:15 a.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, Mat Crocker, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1569
> https://issues.apache.org/jira/browse/SENTRY-1569
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1569 Added changes to sql scripts persist Perm/Path change Adding missing files
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 0606116
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql be9a33e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1c8848c
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql fc7b53f
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql ce807a5
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 3657377
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql 5d88887
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql b6108e7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql d5b7d6e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql f0c8cfb
>
>
> Diff: https://reviews.apache.org/r/56709/diff/5/
>
>
> Testing
> -------
>
> Tested the scrips against db2, postgres, musql, oracle and derby databases.
>
> Also ran SchemaToll test for deby.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 56709: SENTRY-1569 Added changes to sql scripts
persist Perm/Path change Adding missing files
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56709/
-----------------------------------------------------------
(Updated March 2, 2017, 12:15 a.m.)
Review request for sentry, Alexander Kolbasov, Hao Hao, Mat Crocker, Vamsee Yarlagadda, and Vadim Spector.
Changes
-------
Changing charset and collate for column AUTHZ_OBJ_NAME in table AUTHZ_PATHS_MAPPING is causing issue. With this charset and collate, size of the AUTHZ_OBJ_NAME is going beyond 767 bytes. Innodb, MySQL Engines limits key size to 767 bytes. As a result we can not have index on AUTHZ_OBJ_NAME. AS the schema of table AUTHZ_PATHS_MAPPING is changing, we better handle it as part of that. Reverted the changes done for MAUTHZPATHSMAPPING_PATHS amd AUTHZ_PATHS_MAPPING.
Bugs: SENTRY-1569
https://issues.apache.org/jira/browse/SENTRY-1569
Repository: sentry
Description
-------
SENTRY-1569 Added changes to sql scripts persist Perm/Path change Adding missing files
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 0606116
sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql be9a33e
sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1c8848c
sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql fc7b53f
sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql ce807a5
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 3657377
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql 5d88887
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql b6108e7
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql d5b7d6e
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql f0c8cfb
Diff: https://reviews.apache.org/r/56709/diff/5/
Changes: https://reviews.apache.org/r/56709/diff/4-5/
Testing
-------
Tested the scrips against db2, postgres, musql, oracle and derby databases.
Also ran SchemaToll test for deby.
Thanks,
kalyan kumar kalvagadda
Re: Review Request 56709: SENTRY-1569 Added changes to sql scripts
persist Perm/Path change Adding missing files
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56709/
-----------------------------------------------------------
(Updated March 1, 2017, 11:16 p.m.)
Review request for sentry, Alexander Kolbasov, Hao Hao, Mat Crocker, Vamsee Yarlagadda, and Vadim Spector.
Changes
-------
Addressed Hao review comments.
Bugs: SENTRY-1569
https://issues.apache.org/jira/browse/SENTRY-1569
Repository: sentry
Description
-------
SENTRY-1569 Added changes to sql scripts persist Perm/Path change Adding missing files
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql 1829e2f
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 0606116
sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql be9a33e
sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1c8848c
sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql fc7b53f
sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql ce807a5
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 3657377
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql 5d88887
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql b6108e7
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql d5b7d6e
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql f0c8cfb
Diff: https://reviews.apache.org/r/56709/diff/4/
Changes: https://reviews.apache.org/r/56709/diff/3-4/
Testing
-------
Tested the scrips against db2, postgres, musql, oracle and derby databases.
Also ran SchemaToll test for deby.
Thanks,
kalyan kumar kalvagadda
Re: Review Request 56709: SENTRY-1569 Added changes to sql scripts
persist Perm/Path change Adding missing files
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56709/
-----------------------------------------------------------
(Updated Feb. 28, 2017, 1:20 a.m.)
Review request for sentry, Alexander Kolbasov, Hao Hao, Mat Crocker, Vamsee Yarlagadda, and Vadim Spector.
Changes
-------
Addressed review comments.
Bugs: SENTRY-1569
https://issues.apache.org/jira/browse/SENTRY-1569
Repository: sentry
Description
-------
SENTRY-1569 Added changes to sql scripts persist Perm/Path change Adding missing files
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 0606116
sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql be9a33e
sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1c8848c
sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql fc7b53f
sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql ce807a5
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 3657377
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql 5d88887
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql b6108e7
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql d5b7d6e
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql f0c8cfb
Diff: https://reviews.apache.org/r/56709/diff/
Testing
-------
Tested the scrips against db2, postgres, musql, oracle and derby databases.
Also ran SchemaToll test for deby.
Thanks,
kalyan kumar kalvagadda
Re: Review Request 56709: SENTRY-1569 Added changes to sql scripts
persist Perm/Path change Adding missing files
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56709/
-----------------------------------------------------------
(Updated Feb. 22, 2017, 11:40 p.m.)
Review request for sentry, Alexander Kolbasov, Hao Hao, Mat Crocker, Vamsee Yarlagadda, and Vadim Spector.
Changes
-------
Addressed review comments
Bugs: SENTRY-1569
https://issues.apache.org/jira/browse/SENTRY-1569
Repository: sentry
Description
-------
SENTRY-1569 Added changes to sql scripts persist Perm/Path change Adding missing files
Diffs
-----
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 0606116
sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql be9a33e
sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1c8848c
sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql fc7b53f
sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql ce807a5
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 3657377
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql 5d88887
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql b6108e7
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql d5b7d6e
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql f0c8cfb
Diff: https://reviews.apache.org/r/56709/diff/
Testing
-------
Tested the scrips against db2, postgres, musql, oracle and derby databases.
Also ran SchemaToll test for deby.
Thanks,
kalyan kumar kalvagadda
Re: Review Request 56709: SENTRY-1569 Added changes to sql scripts
persist Perm/Path change Adding missing files
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56709/
-----------------------------------------------------------
(Updated Feb. 22, 2017, 11:38 p.m.)
Review request for sentry, Alexander Kolbasov, Hao Hao, Mat Crocker, Vamsee Yarlagadda, and Vadim Spector.
Repository: sentry
Description
-------
SENTRY-1569 Added changes to sql scripts persist Perm/Path change Adding missing files
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 0606116
sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql be9a33e
sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1c8848c
sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql fc7b53f
sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql ce807a5
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 3657377
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql 5d88887
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql b6108e7
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql d5b7d6e
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql f0c8cfb
Diff: https://reviews.apache.org/r/56709/diff/
Testing
-------
Tested the scrips against db2, postgres, musql, oracle and derby databases.
Also ran SchemaToll test for deby.
Thanks,
kalyan kumar kalvagadda
Re: Review Request 56709: SENTRY-1569 Added changes to sql scripts
persist Perm/Path change Adding missing files
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
> On Feb. 22, 2017, 1:13 a.m., Hao Hao wrote:
> > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql, line 255
> > <https://reviews.apache.org/r/56709/diff/1/?file=1634523#file1634523line255>
> >
> > Can you put add the contraint into another queries as you did for 008-SENTRY-1569.mysql.sql?
I have not added constraint in 008-SENTRY-1569.mysql.sql as a seperate query. I just followed the convetion followed in th earlier sql statements.
> On Feb. 22, 2017, 1:13 a.m., Hao Hao wrote:
> > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql, line 265
> > <https://reviews.apache.org/r/56709/diff/1/?file=1634523#file1634523line265>
> >
> > add DEFAULT CHARSET=utf8
As we have provided the charset for PERM_CHANGE/PATH_CHANGE, I feel we don'r have to provide this again.
- kalyan kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56709/#review166277
-----------------------------------------------------------
On Feb. 22, 2017, 11:38 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56709/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2017, 11:38 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, Mat Crocker, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1569 Added changes to sql scripts persist Perm/Path change Adding missing files
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 0606116
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql be9a33e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1c8848c
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql fc7b53f
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql ce807a5
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 3657377
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql 5d88887
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql b6108e7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql d5b7d6e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql f0c8cfb
>
> Diff: https://reviews.apache.org/r/56709/diff/
>
>
> Testing
> -------
>
> Tested the scrips against db2, postgres, musql, oracle and derby databases.
>
> Also ran SchemaToll test for deby.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 56709: SENTRY-1569 Added changes to sql scripts
persist Perm/Path change Adding missing files
Posted by Hao Hao <ha...@cloudera.com>.
> On Feb. 22, 2017, 1:13 a.m., Hao Hao wrote:
> > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql, line 254
> > <https://reviews.apache.org/r/56709/diff/1/?file=1634523#file1634523line254>
> >
> > update the character and collation as well. e.g. `PERM_CHANGE` VARCHAR(4000) CHARACTER SET utf8 COLLATE utf8_bin NOT NULL
>
> kalyan kumar kalvagadda wrote:
> There are certain tables like MAUTHZPATHSMAPPING_PATHS amd AUTHZ_PATHS_MAPPING, where this is not followed. I feel, it should be addressed as well. Please confirm
Yes, could you please also add it at those places as well
- Hao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56709/#review166277
-----------------------------------------------------------
On Feb. 28, 2017, 1:20 a.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56709/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 1:20 a.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, Mat Crocker, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1569
> https://issues.apache.org/jira/browse/SENTRY-1569
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1569 Added changes to sql scripts persist Perm/Path change Adding missing files
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 0606116
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql be9a33e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1c8848c
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql fc7b53f
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql ce807a5
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 3657377
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql 5d88887
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql b6108e7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql d5b7d6e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql f0c8cfb
>
> Diff: https://reviews.apache.org/r/56709/diff/
>
>
> Testing
> -------
>
> Tested the scrips against db2, postgres, musql, oracle and derby databases.
>
> Also ran SchemaToll test for deby.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 56709: SENTRY-1569 Added changes to sql scripts
persist Perm/Path change Adding missing files
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
> On Feb. 22, 2017, 1:13 a.m., Hao Hao wrote:
> > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql
> > Lines 254 (patched)
> > <https://reviews.apache.org/r/56709/diff/1/?file=1634523#file1634523line254>
> >
> > update the character and collation as well. e.g. `PERM_CHANGE` VARCHAR(4000) CHARACTER SET utf8 COLLATE utf8_bin NOT NULL
>
> kalyan kumar kalvagadda wrote:
> There are certain tables like MAUTHZPATHSMAPPING_PATHS amd AUTHZ_PATHS_MAPPING, where this is not followed. I feel, it should be addressed as well. Please confirm
>
> Hao Hao wrote:
> Yes, could you please also add it at those places as well
Changing charset and collate for column AUTHZ_OBJ_NAME in table AUTHZ_PATHS_MAPPING is causing issue. With this charset and collate size of the column is going beyond 767 bytes. Innodb, MySQL Engines limits key size to 767 bytes. As a result we can not have index on AUTHZ_OBJ_NAME. AS the schema of table AUTHZ_PATHS_MAPPING is changing, we better handle it as part of that. I will revert the changes done for MAUTHZPATHSMAPPING_PATHS amd AUTHZ_PATHS_MAPPING.
- kalyan kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56709/#review166277
-----------------------------------------------------------
On March 1, 2017, 11:16 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56709/
> -----------------------------------------------------------
>
> (Updated March 1, 2017, 11:16 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, Mat Crocker, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1569
> https://issues.apache.org/jira/browse/SENTRY-1569
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1569 Added changes to sql scripts persist Perm/Path change Adding missing files
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql 1829e2f
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 0606116
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql be9a33e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1c8848c
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql fc7b53f
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql ce807a5
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 3657377
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql 5d88887
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql b6108e7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql d5b7d6e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql f0c8cfb
>
>
> Diff: https://reviews.apache.org/r/56709/diff/4/
>
>
> Testing
> -------
>
> Tested the scrips against db2, postgres, musql, oracle and derby databases.
>
> Also ran SchemaToll test for deby.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 56709: SENTRY-1569 Added changes to sql scripts
persist Perm/Path change Adding missing files
Posted by Hao Hao <ha...@cloudera.com>.
> On Feb. 22, 2017, 1:13 a.m., Hao Hao wrote:
> > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql
> > Lines 254 (patched)
> > <https://reviews.apache.org/r/56709/diff/1/?file=1634523#file1634523line254>
> >
> > update the character and collation as well. e.g. `PERM_CHANGE` VARCHAR(4000) CHARACTER SET utf8 COLLATE utf8_bin NOT NULL
>
> kalyan kumar kalvagadda wrote:
> There are certain tables like MAUTHZPATHSMAPPING_PATHS amd AUTHZ_PATHS_MAPPING, where this is not followed. I feel, it should be addressed as well. Please confirm
>
> Hao Hao wrote:
> Yes, could you please also add it at those places as well
>
> kalyan kumar kalvagadda wrote:
> Changing charset and collate for column AUTHZ_OBJ_NAME in table AUTHZ_PATHS_MAPPING is causing issue. With this charset and collate size of the column is going beyond 767 bytes. Innodb, MySQL Engines limits key size to 767 bytes. As a result we can not have index on AUTHZ_OBJ_NAME. AS the schema of table AUTHZ_PATHS_MAPPING is changing, we better handle it as part of that. I will revert the changes done for MAUTHZPATHSMAPPING_PATHS amd AUTHZ_PATHS_MAPPING.
Thanks a lot for the confirmation Kalyan, LGTM.
- Hao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56709/#review166277
-----------------------------------------------------------
On March 1, 2017, 11:16 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56709/
> -----------------------------------------------------------
>
> (Updated March 1, 2017, 11:16 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, Mat Crocker, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1569
> https://issues.apache.org/jira/browse/SENTRY-1569
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1569 Added changes to sql scripts persist Perm/Path change Adding missing files
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql 1829e2f
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 0606116
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql be9a33e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1c8848c
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql fc7b53f
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql ce807a5
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 3657377
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql 5d88887
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql b6108e7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql d5b7d6e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql f0c8cfb
>
>
> Diff: https://reviews.apache.org/r/56709/diff/4/
>
>
> Testing
> -------
>
> Tested the scrips against db2, postgres, musql, oracle and derby databases.
>
> Also ran SchemaToll test for deby.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 56709: SENTRY-1569 Added changes to sql scripts
persist Perm/Path change Adding missing files
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
> On Feb. 22, 2017, 1:13 a.m., Hao Hao wrote:
> > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql, line 254
> > <https://reviews.apache.org/r/56709/diff/1/?file=1634523#file1634523line254>
> >
> > update the character and collation as well. e.g. `PERM_CHANGE` VARCHAR(4000) CHARACTER SET utf8 COLLATE utf8_bin NOT NULL
There are certain tables like MAUTHZPATHSMAPPING_PATHS amd AUTHZ_PATHS_MAPPING, where this is not followed. I feel, it should be addressed as well. Please confirm
- kalyan kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56709/#review166277
-----------------------------------------------------------
On Feb. 28, 2017, 1:20 a.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56709/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 1:20 a.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, Mat Crocker, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1569
> https://issues.apache.org/jira/browse/SENTRY-1569
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1569 Added changes to sql scripts persist Perm/Path change Adding missing files
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 0606116
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql be9a33e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1c8848c
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql fc7b53f
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql ce807a5
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 3657377
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql 5d88887
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql b6108e7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql d5b7d6e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql f0c8cfb
>
> Diff: https://reviews.apache.org/r/56709/diff/
>
>
> Testing
> -------
>
> Tested the scrips against db2, postgres, musql, oracle and derby databases.
>
> Also ran SchemaToll test for deby.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 56709: SENTRY-1569 Added changes to sql scripts
persist Perm/Path change Adding missing files
Posted by Hao Hao <ha...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56709/#review166277
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql (line 16)
<https://reviews.apache.org/r/56709/#comment238197>
same here
sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql (line 231)
<https://reviews.apache.org/r/56709/#comment238201>
could you also add "DEFAULT CHARSET=utf8" here?
sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql (line 254)
<https://reviews.apache.org/r/56709/#comment238193>
update the character and collation as well. e.g. `PERM_CHANGE` VARCHAR(4000) CHARACTER SET utf8 COLLATE utf8_bin NOT NULL
sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql (line 255)
<https://reviews.apache.org/r/56709/#comment238194>
Can you put add the contraint into another queries as you did for 008-SENTRY-1569.mysql.sql?
sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql (line 263)
<https://reviews.apache.org/r/56709/#comment238195>
Same here.
sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql (line 265)
<https://reviews.apache.org/r/56709/#comment238200>
add DEFAULT CHARSET=utf8
- Hao Hao
On Feb. 15, 2017, 5:01 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56709/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2017, 5:01 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, Mat Crocker, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1569 Added changes to sql scripts persist Perm/Path change Adding missing files
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 0606116a1d31c400fb6dadcd80a2284007117ab2
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql be9a33e6b0904b7c8ec522906d967081631108d6
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1c8848c30d0432ebdbd18b73a1d27c61d2b7bcae
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql fc7b53f41e97fad5e5baeb254b686a0e8cc5b003
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql ce807a5aee9d04e119dde32784cbe958bf933feb
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql 36573771d84ff9c0d7683f20d7df75ae6be656b7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql 5d88887c62e407dc1fdc0438ce11572a1419ab6d
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql b6108e72c97f9a7ed2afbe9f30f42c412d11f74b
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql d5b7d6eaff461931897a41ba7d38729cbd38b47d
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql f0c8cfb4174189fe270597c2525579b534778831
>
> Diff: https://reviews.apache.org/r/56709/diff/
>
>
> Testing
> -------
>
> Tested the scrips against db2, postgres, musql, oracle and derby databases.
>
> Also ran SchemaToll test for deby.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>