You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/09/09 08:34:13 UTC

[GitHub] [arrow] pitrou commented on a change in pull request #8148: "ARROW-9104: [C++] Parquet encryption tests should write files to a temporary directory instead of the testing submodule's directory"

pitrou commented on a change in pull request #8148:
URL: https://github.com/apache/arrow/pull/8148#discussion_r485435374



##########
File path: cpp/src/parquet/test_encryption_util.h
##########
@@ -57,6 +57,7 @@ const char kFooterEncryptionKey[] = "0123456789012345";  // 128bit/16
 const char kColumnEncryptionKey1[] = "1234567890123450";
 const char kColumnEncryptionKey2[] = "1234567890123451";
 const char kFileName[] = "tester";
+const char kTempDir[] = "/tmp";

Review comment:
       This is not very customary on Windows. Can you use a cross-platform facility? For example, we have a facility to create temporary directories:
   https://github.com/apache/arrow/blob/master/cpp/src/arrow/util/io_util.h#L305




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org