You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by "srijeet0406 (via GitHub)" <gi...@apache.org> on 2023/06/23 00:14:50 UTC
[GitHub] [trafficcontrol] srijeet0406 opened a new pull request, #7595: Fix status code and alert structure for sslkeys endpoint, when no ssl keys are present.
srijeet0406 opened a new pull request, #7595:
URL: https://github.com/apache/trafficcontrol/pull/7595
<!--
Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
If this closes or relates to an existing issue, please reference it using one of the following:
Closes: #4393
Related: #ISSUE
If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://apache.org/security regarding vulnerability disclosure.
-->
This PR fixes https://github.com/apache/trafficcontrol/issues/4393.
<!-- **^ Add meaningful description above** --><hr/>
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this PR.
Feel free to add the name of a tool or script that is affected but not on the list.
-->
- Traffic Ops
## What is the best way to verify this PR?
<!-- Please include here ALL the steps necessary to test your PR.
If your PR has tests (and most should), provide the steps needed to run the tests.
If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. -->
Follow the steps in the related Github issue https://github.com/apache/trafficcontrol/issues/4393.
## If this is a bugfix, which Traffic Control versions contained the bug?
<!-- Delete this section if the PR is not a bugfix, or if the bug is only in the master branch.
Examples:
- 5.1.2
- 5.1.3 (RC1)
-->
- master
## PR submission checklist
- [ ] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
- [ ] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. -->
- [x] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus merged pull request #7595: Fix status code and alert structure for sslkeys endpoint, when no ssl keys are present.
Posted by "shamrickus (via GitHub)" <gi...@apache.org>.
shamrickus merged PR #7595:
URL: https://github.com/apache/trafficcontrol/pull/7595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7595: Fix status code and alert structure for sslkeys endpoint, when no ssl keys are present.
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7595:
URL: https://github.com/apache/trafficcontrol/pull/7595#issuecomment-1603465255
## [Codecov](https://app.codecov.io/gh/apache/trafficcontrol/pull/7595?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#7595](https://app.codecov.io/gh/apache/trafficcontrol/pull/7595?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (87dfcf3) into [master](https://app.codecov.io/gh/apache/trafficcontrol/commit/c1e70b7a7b55b240662b54ca41fc92f760fa94ff?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c1e70b7) will **decrease** coverage by `25.25%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #7595 +/- ##
=============================================
- Coverage 64.80% 39.56% -25.25%
Complexity 98 98
=============================================
Files 201 99 -102
Lines 8158 4648 -3510
Branches 898 90 -808
=============================================
- Hits 5287 1839 -3448
+ Misses 2689 2671 -18
+ Partials 182 138 -44
```
| Flag | Coverage Δ | |
|---|---|---|
| traffic_portal_v2 | `?` | |
| traffic_stats_unit | `10.14% <ø> (?)` | |
| unit_tests | `10.14% <ø> (-64.14%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 112 files with indirect coverage changes](https://app.codecov.io/gh/apache/trafficcontrol/pull/7595/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on pull request #7595: Fix status code and alert structure for sslkeys endpoint, when no ssl keys are present.
Posted by "zrhoffman (via GitHub)" <gi...@apache.org>.
zrhoffman commented on PR #7595:
URL: https://github.com/apache/trafficcontrol/pull/7595#issuecomment-1631509152
Reverted in 7d5cebef86 due to breaking `GET /deliveryservices/xmlId/{xmlId}/sslkeys` when SSL keys are not present. @srijeet0406 would you please re-PR #7595 now that we know to look out for this regression?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org