Adding origin of abort to connection structure

[Dan Poirier <po...@pobox.com>]

I was looking at

https://issues.apache.org/bugzilla/show_bug.cgi?id=48301

which asks for a way to distinguish in the log whether a connection was
aborted by the web server or the other end.  To do that, we'd need to
note the cause of the abort in the connection structure.

I was hoping to just use another non-zero value for connect->abort, but
it turns out that connect->abort is a 1-bit field.

In trunk we could just expand that field, or add another field.  But is
there a way we could add this feature in 2.2 without breaking the API?

Re: Adding origin of abort to connection structure

[Dan Poirier <po...@pobox.com>]

On 2010-05-03 at 14:23, Jeff Trawick <tr...@gmail.com> wrote:

> On Mon, May 3, 2010 at 2:16 PM, Dan Poirier <po...@pobox.com> wrote:
>> I was looking at
>>
>> https://issues.apache.org/bugzilla/show_bug.cgi?id=48301
>>
>> which asks for a way to distinguish in the log whether a connection was
>> aborted by the web server or the other end.  To do that, we'd need to
>> note the cause of the abort in the connection structure.
>
> Help me understand what server-aborted connection means, at least for
> connections that the web server is aware of.
>
> I guess it is a server-aborted connection when the server closes
> before the client during lingering close.  If the server encounters an
> I/O error writing to the client it is assumed to be client-aborted,
> but the client may not see it that way.

That's a really good question.

mod_dav will abort if it runs into an error part-way through returning a
multi-part response.  mod_ssl will abort if it can't set up an SSL
connection.  Otherwise, it looks like setting c->aborted mostly happens
when we get an error on a connection, which isn't really server-aborted.

But I'm not sure if that's what the bug reporter had in mind.  I'll
followup there.

Dan

Re: Adding origin of abort to connection structure

[Jeff Trawick <tr...@gmail.com>]

On Mon, May 3, 2010 at 2:16 PM, Dan Poirier <po...@pobox.com> wrote:
> I was looking at
>
> https://issues.apache.org/bugzilla/show_bug.cgi?id=48301
>
> which asks for a way to distinguish in the log whether a connection was
> aborted by the web server or the other end.  To do that, we'd need to
> note the cause of the abort in the connection structure.

Help me understand what server-aborted connection means, at least for
connections that the web server is aware of.

I guess it is a server-aborted connection when the server closes
before the client during lingering close.  If the server encounters an
I/O error writing to the client it is assumed to be client-aborted,
but the client may not see it that way.