You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Justin Sweeney (Jira)" <ji...@apache.org> on 2022/11/01 18:00:02 UTC

[jira] [Created] (SOLR-16516) Execute Github Action for Gradle Checks on All PRs

Justin Sweeney created SOLR-16516:
-------------------------------------

             Summary: Execute Github Action for Gradle Checks on All PRs
                 Key: SOLR-16516
                 URL: https://issues.apache.org/jira/browse/SOLR-16516
             Project: Solr
          Issue Type: Improvement
      Security Level: Public (Default Security Level. Issues are Public)
          Components: github
    Affects Versions: 9.1
            Reporter: Justin Sweeney


Currently the Solr Github Actions configuration that runs Gradle checks on PRs is setup to run on PRs of branches using the pattern `*`. This means the action will be run on all open PRs against any branch except branches containing `/`.

I'd propose that this should actually use the pattern `**` which will also run against branches containing `/`. At FullStory we are using branches with `/` in our fork so this is inhibiting checks running for us and I don't see a reason whey we wouldn't generally want that behavior given `/` is a reasonable character in branches.

More detail here on the branch filter syntax: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org