[GitHub] [ignite-3] AMashenkov commented on a change in pull request #401: IGNITE-13667: Add schema columns mapping from user order to system order

[GitBox <gi...@apache.org>]

AMashenkov commented on a change in pull request #401:
URL: https://github.com/apache/ignite-3/pull/401#discussion_r730996809



##########
File path: modules/schema/src/main/java/org/apache/ignite/internal/schema/Column.java
##########
@@ -24,15 +24,20 @@
 import org.jetbrains.annotations.NotNull;
 
 /**
- * Column description for a type schema. Column contains a column name, a column type and a nullability flag.
+ * Column descriptor which contains a column name, a type and a nullability flag.
  * <p>
  * Column instances are comparable in lexicographic order, native type first and then column name. Nullability

Review comment:
       We have to write a row in a specific order: key first, then value and fixlen columns first, then varlen.
   The order must be same for all the nodes.
   
   So, we must compare native type first, then column names. 
   But you are right, we can compare columnOrder instead of (or before) column name for simplicity. It will be faster and keep column order stable if one of columns will be renamed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org