You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "comphead (via GitHub)" <gi...@apache.org> on 2025/03/19 01:37:43 UTC
[PR] feat: enable iceberg compat tests, more tests for complex types [datafusion-comet]
comphead opened a new pull request, #1550:
URL: https://github.com/apache/datafusion-comet/pull/1550
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Part of #1454 .
## Rationale for this change
Enable Iceberg compat type tests, add more tests for complex types
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: enable iceberg compat tests, more tests for complex types [datafusion-comet]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead merged PR #1550:
URL: https://github.com/apache/datafusion-comet/pull/1550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: enable iceberg compat tests, more tests for complex types [datafusion-comet]
Posted by "parthchandra (via GitHub)" <gi...@apache.org>.
parthchandra commented on PR #1550:
URL: https://github.com/apache/datafusion-comet/pull/1550#issuecomment-2744647013
> > ```
> > struct
> > +- array
> > +- struct
> > ```
fyi, currently some tests in Spark SQL (e.g. "add a nested column at the end of the leaf struct column") fail because of structs like this with.
```
Caused by: org.apache.comet.CometNativeException: no entry found for key
[info] at comet::errors::init::{{closure}}(__internal__:0)
[info] at std::panicking::rust_panic_with_hook(__internal__:0)
[info] at std::panicking::begin_panic_handler::{{closure}}(__internal__:0)
[info] at std::sys::backtrace::__rust_end_short_backtrace(__internal__:0)
[info] at rust_begin_unwind(__internal__:0)
[info] at core::panicking::panic_fmt(__internal__:0)
[info] at core::option::expect_failed(__internal__:0)
[info] at comet::parquet::parquet_support::cast_struct_to_struct(__internal__:0)
[info] at comet::parquet::parquet_support::cast_array(__internal__:0)
[info] at comet::parquet::parquet_support::cast_struct_to_struct(__internal__:0)
[info] at comet::parquet::parquet_support::cast_array(__internal__:0)
[info] at comet::parquet::parquet_support::spark_parquet_convert(__internal__:0)
[info] at <core::iter::adapters::GenericShunt<I,R> as core::iter::traits::iterator::Iterator>::next(__internal__:0)
[info] at <comet::parquet::schema_adapter::SchemaMapping as datafusion::datasource::schema_adapter::SchemaMapper>::map_batch(__internal__:0)
[info] at <futures_util::stream::stream::map::Map<St,F> as futures_core::stream::Stream>::poll_next(__internal__:0)
[info] at <datafusion_datasource::file_stream::FileStream as futures_core::stream::Stream>::poll_next(__internal__:0)
[info] at Java_org_apache_comet_parquet_Native_readNextRecordBatch(__internal__:0)
[info] at <unknown>(__internal__:0)
[info] at org.apache.comet.parquet.Native.readNextRecordBatch(Native Method)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: enable iceberg compat tests, more tests for complex types [datafusion-comet]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on PR #1550:
URL: https://github.com/apache/datafusion-comet/pull/1550#issuecomment-2744701637
> > > ```
> > > struct
> > > +- array
> > > +- struct
> > > ```
>
> fyi, currently some tests in Spark SQL (e.g. "add a nested column at the end of the leaf struct column") fail because of structs like this with.
>
> ```
> Caused by: org.apache.comet.CometNativeException: no entry found for key
> [info] at comet::errors::init::{{closure}}(__internal__:0)
> [info] at std::panicking::rust_panic_with_hook(__internal__:0)
> [info] at std::panicking::begin_panic_handler::{{closure}}(__internal__:0)
> [info] at std::sys::backtrace::__rust_end_short_backtrace(__internal__:0)
> [info] at rust_begin_unwind(__internal__:0)
> [info] at core::panicking::panic_fmt(__internal__:0)
> [info] at core::option::expect_failed(__internal__:0)
> [info] at comet::parquet::parquet_support::cast_struct_to_struct(__internal__:0)
> [info] at comet::parquet::parquet_support::cast_array(__internal__:0)
> [info] at comet::parquet::parquet_support::cast_struct_to_struct(__internal__:0)
> [info] at comet::parquet::parquet_support::cast_array(__internal__:0)
> [info] at comet::parquet::parquet_support::spark_parquet_convert(__internal__:0)
> [info] at <core::iter::adapters::GenericShunt<I,R> as core::iter::traits::iterator::Iterator>::next(__internal__:0)
> [info] at <comet::parquet::schema_adapter::SchemaMapping as datafusion::datasource::schema_adapter::SchemaMapper>::map_batch(__internal__:0)
> [info] at <futures_util::stream::stream::map::Map<St,F> as futures_core::stream::Stream>::poll_next(__internal__:0)
> [info] at <datafusion_datasource::file_stream::FileStream as futures_core::stream::Stream>::poll_next(__internal__:0)
> [info] at Java_org_apache_comet_parquet_Native_readNextRecordBatch(__internal__:0)
> [info] at <unknown>(__internal__:0)
> [info] at org.apache.comet.parquet.Native.readNextRecordBatch(Native Method)
> ```
appreciate if you can mention those tests in #1551 so we can double check if they can pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: enable iceberg compat tests, more tests for complex types [datafusion-comet]
Posted by "parthchandra (via GitHub)" <gi...@apache.org>.
parthchandra commented on code in PR #1550:
URL: https://github.com/apache/datafusion-comet/pull/1550#discussion_r2017073486
##########
spark/src/main/scala/org/apache/spark/sql/comet/CometScanExec.scala:
##########
@@ -490,8 +490,7 @@ object CometScanExec extends DataTypeSupport {
// TODO add map
dt match {
case s: StructType => s.fields.map(_.dataType).forall(isTypeSupported)
- // TODO: Add nested array and iceberg compat support
- // case a: ArrayType => isTypeSupported(a.elementType)
+ case a: ArrayType => isTypeSupported(a.elementType)
Review Comment:
Are we sure about this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: enable iceberg compat tests, more tests for complex types [datafusion-comet]
Posted by "kazuyukitanimura (via GitHub)" <gi...@apache.org>.
kazuyukitanimura commented on code in PR #1550:
URL: https://github.com/apache/datafusion-comet/pull/1550#discussion_r2012997384
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2722,7 +2721,11 @@ object QueryPlanSerde extends Logging with ShimQueryPlanSerde with CometExprShim
case op
if isCometSink(op) && op.output.forall(a =>
- supportedDataType(a.dataType, allowComplex = true)) =>
+ supportedDataType(
+ a.dataType,
+ allowComplex =
+ usingDataFusionParquetExec(conf) || CometConf.COMET_CONVERT_FROM_PARQUET_ENABLED
Review Comment:
Why `COMET_CONVERT_FROM_*` is allowed only here but not other places?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: enable iceberg compat tests, more tests for complex types [datafusion-comet]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1550:
URL: https://github.com/apache/datafusion-comet/pull/1550#issuecomment-2735173935
## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1550?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `33.33333%` with `2 lines` in your changes missing coverage. Please review.
> Project coverage is 57.35%. Comparing base [(`f09f8af`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/f09f8af64c6599255e116a376f4f008f2fd63b43?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`05c3cd4`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/05c3cd46c922fb42b3dd243bab1b07bf2bbe7a2b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 90 commits behind head on main.
| [Files with missing lines](https://app.codecov.io/gh/apache/datafusion-comet/pull/1550?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../scala/org/apache/comet/serde/QueryPlanSerde.scala](https://app.codecov.io/gh/apache/datafusion-comet/pull/1550?src=pr&el=tree&filepath=spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fcomet%2Fserde%2FQueryPlanSerde.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9jb21ldC9zZXJkZS9RdWVyeVBsYW5TZXJkZS5zY2FsYQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/datafusion-comet/pull/1550?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ala/org/apache/spark/sql/comet/CometScanExec.scala](https://app.codecov.io/gh/apache/datafusion-comet/pull/1550?src=pr&el=tree&filepath=spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fcomet%2FCometScanExec.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvY29tZXQvQ29tZXRTY2FuRXhlYy5zY2FsYQ==) | 0.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/datafusion-comet/pull/1550?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #1550 +/- ##
============================================
+ Coverage 56.12% 57.35% +1.23%
+ Complexity 976 939 -37
============================================
Files 119 122 +3
Lines 11743 12143 +400
Branches 2251 2282 +31
============================================
+ Hits 6591 6965 +374
+ Misses 4012 4011 -1
- Partials 1140 1167 +27
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/datafusion-comet/pull/1550?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>🚀 New features to boost your workflow: </summary>
- ❄ [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: enable iceberg compat tests, more tests for complex types [datafusion-comet]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #1550:
URL: https://github.com/apache/datafusion-comet/pull/1550#discussion_r2012425292
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2722,7 +2721,10 @@ object QueryPlanSerde extends Logging with ShimQueryPlanSerde with CometExprShim
case op
if isCometSink(op) && op.output.forall(a =>
- supportedDataType(a.dataType, allowComplex = true)) =>
+ supportedDataType(
+ a.dataType,
+ allowComplex =
+ usingDataFusionParquetExec(conf) || op.isInstanceOf[CometSparkToColumnarExec])) =>
Review Comment:
@mbutrovich I think this check require attention.
It needs to work for `CometSparkToColumnarExec` as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: enable iceberg compat tests, more tests for complex types [datafusion-comet]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on PR #1550:
URL: https://github.com/apache/datafusion-comet/pull/1550#issuecomment-2741862047
> Great tests @comphead Do you think we need to add some cases with one more level of nesting -
>
> ```
> array
> +- struct
> +- array
> ```
>
> and
>
> ```
> struct
> +- array
> +- struct
> ```
>
> or would that be overkill?
Thanks @parthchandra I'll try to add them once I fx other tests currently failing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: enable iceberg compat tests, more tests for complex types [datafusion-comet]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #1550:
URL: https://github.com/apache/datafusion-comet/pull/1550#discussion_r2002258552
##########
spark/src/test/scala/org/apache/comet/exec/CometNativeReaderSuite.scala:
##########
@@ -63,4 +61,67 @@ class CometNativeReaderSuite extends CometTestBase with AdaptiveSparkPlanHelper
|""".stripMargin,
"select arr from tbl")
}
+
+ /*
Review Comment:
Followup ticket to fix schema issues for `native reader - read STRUCT of ARRAY fields` https://github.com/apache/datafusion-comet/issues/1551
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: enable iceberg compat tests, more tests for complex types [datafusion-comet]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on PR #1550:
URL: https://github.com/apache/datafusion-comet/pull/1550#issuecomment-2737322170
Not sure why test failed, it is okay on local
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: enable iceberg compat tests, more tests for complex types [datafusion-comet]
Posted by "parthchandra (via GitHub)" <gi...@apache.org>.
parthchandra commented on code in PR #1550:
URL: https://github.com/apache/datafusion-comet/pull/1550#discussion_r2017071919
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2722,7 +2721,11 @@ object QueryPlanSerde extends Logging with ShimQueryPlanSerde with CometExprShim
case op
if isCometSink(op) && op.output.forall(a =>
- supportedDataType(a.dataType, allowComplex = true)) =>
+ supportedDataType(
+ a.dataType,
+ allowComplex =
+ usingDataFusionParquetExec(conf) || CometConf.COMET_CONVERT_FROM_PARQUET_ENABLED
Review Comment:
This check seems fine. Could could get a complex type in a CometSink if either of these conditions is true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: enable iceberg compat tests, more tests for complex types [datafusion-comet]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #1550:
URL: https://github.com/apache/datafusion-comet/pull/1550#discussion_r2002258552
##########
spark/src/test/scala/org/apache/comet/exec/CometNativeReaderSuite.scala:
##########
@@ -63,4 +61,67 @@ class CometNativeReaderSuite extends CometTestBase with AdaptiveSparkPlanHelper
|""".stripMargin,
"select arr from tbl")
}
+
+ /*
Review Comment:
Followup ticket to fix schema issues for `native reader - read STRUCT of ARRAY fields`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: enable iceberg compat tests, more tests for complex types [datafusion-comet]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #1550:
URL: https://github.com/apache/datafusion-comet/pull/1550#discussion_r2020248798
##########
spark/src/main/scala/org/apache/spark/sql/comet/CometScanExec.scala:
##########
@@ -490,8 +490,7 @@ object CometScanExec extends DataTypeSupport {
// TODO add map
dt match {
case s: StructType => s.fields.map(_.dataType).forall(isTypeSupported)
- // TODO: Add nested array and iceberg compat support
- // case a: ArrayType => isTypeSupported(a.elementType)
+ case a: ArrayType => isTypeSupported(a.elementType)
Review Comment:
Thanks @parthchandra I'm planning to merge it and add more array tests as followup PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: enable iceberg compat tests, more tests for complex types [datafusion-comet]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #1550:
URL: https://github.com/apache/datafusion-comet/pull/1550#discussion_r2014693425
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2722,7 +2721,11 @@ object QueryPlanSerde extends Logging with ShimQueryPlanSerde with CometExprShim
case op
if isCometSink(op) && op.output.forall(a =>
- supportedDataType(a.dataType, allowComplex = true)) =>
+ supportedDataType(
+ a.dataType,
+ allowComplex =
+ usingDataFusionParquetExec(conf) || CometConf.COMET_CONVERT_FROM_PARQUET_ENABLED
Review Comment:
This allows complex types for native reader and if conversions enabled. For other cases complex types would fall back to Spark behavior.
@parthchandra @mbutrovich @andygrove please have a second look if this condition is okay or may be improved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: enable iceberg compat tests, more tests for complex types [datafusion-comet]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #1550:
URL: https://github.com/apache/datafusion-comet/pull/1550#discussion_r2017244901
##########
spark/src/main/scala/org/apache/spark/sql/comet/CometScanExec.scala:
##########
@@ -490,8 +490,7 @@ object CometScanExec extends DataTypeSupport {
// TODO add map
dt match {
case s: StructType => s.fields.map(_.dataType).forall(isTypeSupported)
- // TODO: Add nested array and iceberg compat support
- // case a: ArrayType => isTypeSupported(a.elementType)
+ case a: ArrayType => isTypeSupported(a.elementType)
Review Comment:
shouldn't we support a ArrayType for CometScanExec as well as the structure already supported?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: enable iceberg compat tests, more tests for complex types [datafusion-comet]
Posted by "parthchandra (via GitHub)" <gi...@apache.org>.
parthchandra commented on code in PR #1550:
URL: https://github.com/apache/datafusion-comet/pull/1550#discussion_r2019242229
##########
spark/src/main/scala/org/apache/spark/sql/comet/CometScanExec.scala:
##########
@@ -490,8 +490,7 @@ object CometScanExec extends DataTypeSupport {
// TODO add map
dt match {
case s: StructType => s.fields.map(_.dataType).forall(isTypeSupported)
- // TODO: Add nested array and iceberg compat support
- // case a: ArrayType => isTypeSupported(a.elementType)
+ case a: ArrayType => isTypeSupported(a.elementType)
Review Comment:
I'm not sure myself how well arrays are supported by the scans. I suppose we need to add more tests for arrays?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org