You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Diwaker Gupta (JIRA)" <ji...@codehaus.org> on 2013/01/25 19:38:13 UTC
[jira] (SUREFIRE-953) Multi-module build succeeds even if tests
time out
Diwaker Gupta created SUREFIRE-953:
--------------------------------------
Summary: Multi-module build succeeds even if tests time out
Key: SUREFIRE-953
URL: https://jira.codehaus.org/browse/SUREFIRE-953
Project: Maven Surefire
Issue Type: Bug
Components: Junit 4.x support, Maven Surefire Plugin
Affects Versions: 2.13
Environment: Ubuntu 12.04. OpenJDK 7u9.
Reporter: Diwaker Gupta
We have a multi-module Maven project. One of the modules has the following Surefire configuration:
{noformat}
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<parallel>classes</parallel>
<runOrder>random</runOrder>
<threadCount>1</threadCount>
<forkedProcessTimeoutInSeconds>300</forkedProcessTimeoutInSeconds>
</configuration>
</plugin>
{noformat}
Notice the 300s timeout. We've seen multiple instances where the build succeeds even if the tests time out. Here's an example:
{noformat}
[INFO] Reactor Summary:
[INFO]
[INFO] Project 1 ......................................... SUCCESS [4.742s]
[INFO] Project 2 ......................................... SUCCESS [5:15.220s]
{noformat}
Notice that Project 2 (which had the 300s timeout) above has run > 5 min. Earlier, in the log we see this:
{noformat}
mojoSucceeded org.apache.maven.plugins:maven-surefire-plugin:2.13(default-test)
[ERROR] There was a timeout or other error in the fork
[JENKINS] Recording test results
projectSucceeded <project 2 details>
{noformat}
So clearly Maven did hit a timeout and yet succeeded the build. I'm happy to provide any other information about our setup. I don't have an isolated, reproducible test case yet however.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (SUREFIRE-953) Multi-module build succeeds even if tests
time out
Posted by "Kristian Rosenvold (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/SUREFIRE-953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Rosenvold updated SUREFIRE-953:
----------------------------------------
Fix Version/s: 2.14
> Multi-module build succeeds even if tests time out
> --------------------------------------------------
>
> Key: SUREFIRE-953
> URL: https://jira.codehaus.org/browse/SUREFIRE-953
> Project: Maven Surefire
> Issue Type: Bug
> Components: Junit 4.x support, Maven Surefire Plugin
> Affects Versions: 2.13
> Environment: Ubuntu 12.04. OpenJDK 7u9.
> Reporter: Diwaker Gupta
> Fix For: 2.14
>
>
> We have a multi-module Maven project. One of the modules has the following Surefire configuration:
> {noformat}
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-surefire-plugin</artifactId>
> <configuration>
> <parallel>classes</parallel>
> <runOrder>random</runOrder>
> <threadCount>1</threadCount>
> <forkedProcessTimeoutInSeconds>300</forkedProcessTimeoutInSeconds>
> </configuration>
> </plugin>
> {noformat}
> Notice the 300s timeout. We've seen multiple instances where the build succeeds even if the tests time out. Here's an example:
> {noformat}
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Project 1 ......................................... SUCCESS [4.742s]
> [INFO] Project 2 ......................................... SUCCESS [5:15.220s]
> {noformat}
> Notice that Project 2 (which had the 300s timeout) above has run > 5 min. Earlier, in the log we see this:
> {noformat}
> mojoSucceeded org.apache.maven.plugins:maven-surefire-plugin:2.13(default-test)
> [ERROR] There was a timeout or other error in the fork
> [JENKINS] Recording test results
> projectSucceeded <project 2 details>
> {noformat}
> So clearly Maven did hit a timeout and yet succeeded the build. I'm happy to provide any other information about our setup. I don't have an isolated, reproducible test case yet however.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (SUREFIRE-953) Multi-module build succeeds even if tests
time out
Posted by "Andreas Gudian (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/SUREFIRE-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=319783#comment-319783 ]
Andreas Gudian commented on SUREFIRE-953:
-----------------------------------------
Hi Diwaker,
only when I set {{-Dmaven.test.failure.ignore=true}} as VM argument (e.g. through some option in Jenkins) or {{<testFailureIgnore>true</testFailureIgnore>}} in the pom, I can observe the behaviour you describe. As far as I can see it in the code, that is how it is supposed to work
If that you don't have {{testFailureIgnore}} enabled, and still experience the problem, than we clearly have a bug at hand - and we would need an isolated test case for a deeper analysis.
If you have {{testFailureIgnore}} enabled and feel that Surefire should behave differently, then let us know - good suggestions are always welcome around here.
> Multi-module build succeeds even if tests time out
> --------------------------------------------------
>
> Key: SUREFIRE-953
> URL: https://jira.codehaus.org/browse/SUREFIRE-953
> Project: Maven Surefire
> Issue Type: Bug
> Components: Junit 4.x support, Maven Surefire Plugin
> Affects Versions: 2.13
> Environment: Ubuntu 12.04. OpenJDK 7u9.
> Reporter: Diwaker Gupta
> Fix For: 2.14
>
>
> We have a multi-module Maven project. One of the modules has the following Surefire configuration:
> {noformat}
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-surefire-plugin</artifactId>
> <configuration>
> <parallel>classes</parallel>
> <runOrder>random</runOrder>
> <threadCount>1</threadCount>
> <forkedProcessTimeoutInSeconds>300</forkedProcessTimeoutInSeconds>
> </configuration>
> </plugin>
> {noformat}
> Notice the 300s timeout. We've seen multiple instances where the build succeeds even if the tests time out. Here's an example:
> {noformat}
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Project 1 ......................................... SUCCESS [4.742s]
> [INFO] Project 2 ......................................... SUCCESS [5:15.220s]
> {noformat}
> Notice that Project 2 (which had the 300s timeout) above has run > 5 min. Earlier, in the log we see this:
> {noformat}
> mojoSucceeded org.apache.maven.plugins:maven-surefire-plugin:2.13(default-test)
> [ERROR] There was a timeout or other error in the fork
> [JENKINS] Recording test results
> projectSucceeded <project 2 details>
> {noformat}
> So clearly Maven did hit a timeout and yet succeeded the build. I'm happy to provide any other information about our setup. I don't have an isolated, reproducible test case yet however.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (SUREFIRE-953) Multi-module build succeeds even if tests
time out
Posted by "Andreas Gudian (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/SUREFIRE-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=319787#comment-319787 ]
Andreas Gudian commented on SUREFIRE-953:
-----------------------------------------
See also SUREFIRE-920 (delivered with 2.13)
> Multi-module build succeeds even if tests time out
> --------------------------------------------------
>
> Key: SUREFIRE-953
> URL: https://jira.codehaus.org/browse/SUREFIRE-953
> Project: Maven Surefire
> Issue Type: Bug
> Components: Junit 4.x support, Maven Surefire Plugin
> Affects Versions: 2.13
> Environment: Ubuntu 12.04. OpenJDK 7u9.
> Reporter: Diwaker Gupta
> Fix For: 2.14
>
>
> We have a multi-module Maven project. One of the modules has the following Surefire configuration:
> {noformat}
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-surefire-plugin</artifactId>
> <configuration>
> <parallel>classes</parallel>
> <runOrder>random</runOrder>
> <threadCount>1</threadCount>
> <forkedProcessTimeoutInSeconds>300</forkedProcessTimeoutInSeconds>
> </configuration>
> </plugin>
> {noformat}
> Notice the 300s timeout. We've seen multiple instances where the build succeeds even if the tests time out. Here's an example:
> {noformat}
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Project 1 ......................................... SUCCESS [4.742s]
> [INFO] Project 2 ......................................... SUCCESS [5:15.220s]
> {noformat}
> Notice that Project 2 (which had the 300s timeout) above has run > 5 min. Earlier, in the log we see this:
> {noformat}
> mojoSucceeded org.apache.maven.plugins:maven-surefire-plugin:2.13(default-test)
> [ERROR] There was a timeout or other error in the fork
> [JENKINS] Recording test results
> projectSucceeded <project 2 details>
> {noformat}
> So clearly Maven did hit a timeout and yet succeeded the build. I'm happy to provide any other information about our setup. I don't have an isolated, reproducible test case yet however.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira