You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "turcsanyip (via GitHub)" <gi...@apache.org> on 2024/04/09 16:12:00 UTC

[PR] NIFI-12231 FetchSmb supports Move and Delete Completion Strategies [nifi]

turcsanyip opened a new pull request, #8617:
URL: https://github.com/apache/nifi/pull/8617

   # Summary
   
   [NIFI-12231](https://issues.apache.org/jira/browse/NIFI-12231)
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [ ] Pull Request based on current revision of the `main` branch
   - [ ] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
     - [ ] JDK 21
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NIFI-12231 FetchSmb supports Move and Delete Completion Strategies [nifi]

Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit closed pull request #8617: NIFI-12231 FetchSmb supports Move and Delete Completion Strategies
URL: https://github.com/apache/nifi/pull/8617


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NIFI-12231 FetchSmb supports Move and Delete Completion Strategies [nifi]

Posted by "turcsanyip (via GitHub)" <gi...@apache.org>.
turcsanyip commented on PR #8617:
URL: https://github.com/apache/nifi/pull/8617#issuecomment-2094368629

   @exceptionfactory I managed to fix the tests by changing the logic in FetchSmb.
   
   There were 2 overlapping sessions to the SMB server: one for reading the file and the other for executing the completions strategy (move or delete) in `commitAsync()`. I moved the commit out of the TWR block of the first session, so the "read" session gets closed before the "move/delete" session starts.
   
   Parallel sessions should not cause issues as the file handles are closed properly and it worked in my environments (ran flows connecting to Windows share and Samba share, ran integrations tests on Mac and Linux). Not sure what the docker environment is doing in Github CI but this change fixed it. I re-ran the integrations tests 3 times and all were green.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NIFI-12231 FetchSmb supports Move and Delete Completion Strategies [nifi]

Posted by "turcsanyip (via GitHub)" <gi...@apache.org>.
turcsanyip commented on PR #8617:
URL: https://github.com/apache/nifi/pull/8617#issuecomment-2057533064

   > The integration tests workflow failed on `FetchSmbIT` for the following tests:
   > 
   > ```
   > FetchSmbIT.testCompletionStrategyDelete:114 expected: <false> but was: <true>
   > FetchSmbIT.testCompletionStrategyMoveWithCreatingDirectory:149 expected: <false> but was: <true>
   > ```
   
   Thanks for the heads-up @exceptionfactory!
   I rerun the integration test on GitHub and got the same errors. So they are not intermittent.
   However, I did not manage to replicate it in my environments. It worked on Mac and now I also set up a similar environment to GitHub Actions (same OS, Java and Docker versions) but no luck.
   I pushed some changes in order to get more info and also modified the logic a bit (just trial-and-error approach). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org