You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/04/28 06:38:03 UTC
[GitHub] [incubator-seatunnel] tobezhou33 opened a new pull request, #1767: fix jdbc partition coloumn sql error
tobezhou33 opened a new pull request, #1767:
URL: https://github.com/apache/incubator-seatunnel/pull/1767
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
fix the jdbc add partition column then splicing the sql error because the quotation marks use error
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] BenJFan commented on pull request #1767: [Bug][flink-connector-jdbc]fix jdbc partition coloumn sql error
Posted by GitBox <gi...@apache.org>.
BenJFan commented on PR #1767:
URL: https://github.com/apache/incubator-seatunnel/pull/1767#issuecomment-1112824202
> Can we add UT or IT to cover this case?
Argge with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on pull request #1767: [Bug][flink-connector-jdbc]fix jdbc partition coloumn sql error
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #1767:
URL: https://github.com/apache/incubator-seatunnel/pull/1767#issuecomment-1111865076
Can we add UT or IT to cover this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] tobezhou33 closed pull request #1767: [Bug][flink-connector-jdbc]fix jdbc partition coloumn sql error
Posted by GitBox <gi...@apache.org>.
tobezhou33 closed pull request #1767: [Bug][flink-connector-jdbc]fix jdbc partition coloumn sql error
URL: https://github.com/apache/incubator-seatunnel/pull/1767
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on pull request #1767: [Bug][flink-connector-jdbc]fix jdbc partition coloumn sql error
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #1767:
URL: https://github.com/apache/incubator-seatunnel/pull/1767#issuecomment-1111864086
@BenJFan Please take a look, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] tobezhou33 commented on pull request #1767: [Bug][flink-connector-jdbc]fix jdbc partition coloumn sql error
Posted by GitBox <gi...@apache.org>.
tobezhou33 commented on PR #1767:
URL: https://github.com/apache/incubator-seatunnel/pull/1767#issuecomment-1114009946
i add ut for jdbcsource to test extendPartitionQuerySql method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] BenJFan commented on pull request #1767: [Bug][flink-connector-jdbc]fix jdbc partition coloumn sql error
Posted by GitBox <gi...@apache.org>.
BenJFan commented on PR #1767:
URL: https://github.com/apache/incubator-seatunnel/pull/1767#issuecomment-1112824201
> Can we add UT or IT to cover this case?
Argge with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] BenJFan commented on pull request #1767: [Bug][flink-connector-jdbc]fix jdbc partition coloumn sql error
Posted by GitBox <gi...@apache.org>.
BenJFan commented on PR #1767:
URL: https://github.com/apache/incubator-seatunnel/pull/1767#issuecomment-1118113416
Hi, in #1781 flink-jdbc connector use different way to support partition. So this PR maybe not neccessy, but you can review it and make your contribute on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org