You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hop.apache.org by GitBox <gi...@apache.org> on 2022/12/29 18:59:53 UTC

[GitHub] [hop] sramazzina opened a new pull request, #2112: issue#1931: Cleanup XML of transform Set Variable

sramazzina opened a new pull request, #2112:
URL: https://github.com/apache/hop/pull/2112

   Cleanup XML of transform Set Variable. 
   Some improvements on language string. 
   Added integration tests.
   
   
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
   - [ ] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`.
   - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable.
   
   To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
   - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hop] hansva commented on pull request #2112: issue#1931: Cleanup XML of transform Set Variable

Posted by GitBox <gi...@apache.org>.
hansva commented on PR #2112:
URL: https://github.com/apache/hop/pull/2112#issuecomment-1369050493

   @usbrandon , what is the reason for marking it as a draft?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hop] hansva commented on pull request #2112: issue#1931: Cleanup XML of transform Set Variable

Posted by GitBox <gi...@apache.org>.
hansva commented on PR #2112:
URL: https://github.com/apache/hop/pull/2112#issuecomment-1369631149

   Alright, I was just wondering as there was no discussion or reason here as to why it was changed to draft.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hop] sramazzina commented on pull request #2112: issue#1931: Cleanup XML of transform Set Variable

Posted by GitBox <gi...@apache.org>.
sramazzina commented on PR #2112:
URL: https://github.com/apache/hop/pull/2112#issuecomment-1369624433

   Brandon noticed that there are some imports that could be optimized. I didn't noticed that and I agree with him. I will take care about that today.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hop] hansva merged pull request #2112: issue#1931: Cleanup XML of transform Set Variable

Posted by GitBox <gi...@apache.org>.
hansva merged PR #2112:
URL: https://github.com/apache/hop/pull/2112


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org